From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] apply-patches.sh: detect missing patches
Date: Thu, 5 Sep 2013 10:04:59 +0200 [thread overview]
Message-ID: <20130905100459.13173009@skate> (raw)
In-Reply-To: <CAAXf6LV9HPWdzqV_F5zQ+aABtVxZGRRkhDszF2Qx8vyXMb+PhA@mail.gmail.com>
Dear Thomas De Schampheleire,
On Thu, 5 Sep 2013 09:03:33 +0200, Thomas De Schampheleire wrote:
> > Although I agree with the concept of checking for existence, I'm not
> > sure about the action to take.
> > Earlier in apply-patches.sh, if a patch is in an unsupported format,
> > it is simply skipped (and a message printed). I think the action in
> > that case should line up with the nonexisting patch case, so either
> > give a warning and continue, or an error and stop.
>
> Any input from others?
My general feeling is that when something goes wrong or looks wrong, we
should abort with an error, and not try to continue with something
more-or-less broken/incorrect.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-09-05 8:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 16:00 [Buildroot] [PATCH] apply-patches.sh: detect missing patches Ralph Siemsen
2013-08-23 10:31 ` Thomas De Schampheleire
2013-09-05 7:03 ` Thomas De Schampheleire
2013-09-05 8:04 ` Thomas Petazzoni [this message]
2013-09-05 8:35 ` Luca Ceresoli
2013-09-05 14:01 ` Yann E. MORIN
2013-09-05 19:20 ` Thomas De Schampheleire
2013-09-11 12:06 ` Ralph Siemsen
2013-09-12 8:08 ` Thomas De Schampheleire
2013-09-13 18:15 ` [Buildroot] [PATCH v2] " Ralph Siemsen
2013-09-13 18:27 ` Yann E. MORIN
2013-09-15 13:37 ` Ralph Siemsen
2013-09-15 14:13 ` [Buildroot] [PATCH v3] " Ralph Siemsen
2013-09-15 20:09 ` Peter Korsgaard
2013-09-16 7:11 ` Peter Korsgaard
2013-09-16 12:46 ` Ralph Siemsen
2013-09-16 20:50 ` Peter Korsgaard
2013-09-16 15:24 ` Thomas Petazzoni
2013-09-16 19:45 ` Ralph Siemsen
2013-09-16 20:07 ` Arnout Vandecappelle
2013-09-16 20:49 ` Peter Korsgaard
2013-09-16 20:51 ` Yann E. MORIN
2013-09-16 20:57 ` Peter Korsgaard
2013-09-16 12:36 ` Ralph Siemsen
2013-09-16 13:42 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130905100459.13173009@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox