From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] apply-patches.sh: detect missing patches
Date: Sun, 15 Sep 2013 22:09:45 +0200 [thread overview]
Message-ID: <8738p5lud2.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20130915141314.GA18166@harvey.netwinder.org> (Ralph Siemsen's message of "Sun, 15 Sep 2013 10:13:14 -0400")
>>>>> "Ralph" == Ralph Siemsen <ralphs@netwinder.org> writes:
Ralph> The "patch" command returns an error code only if patches fail
Ralph> to apply. Therefore the pipleline "cat <patchfile> | patch ..."
Ralph> does not fail, even if <patchfile> is missing. Fix this by
Ralph> adding an explicit check for patch file existence.
Ralph> Based on feedback from buildroot mailing list, also change the
Ralph> existing check for unsupported patch format into a fatal error.
Ralph> ---
Ralph> v1. original
Ralph> v2. error on unsupported patch formats
Ralph> v3. explicit exit calls
Committed, thanks.
You forgot to add your 'Signed-off-by' on the patch. I've added it for
you, hopefully that is OK?
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2013-09-15 20:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 16:00 [Buildroot] [PATCH] apply-patches.sh: detect missing patches Ralph Siemsen
2013-08-23 10:31 ` Thomas De Schampheleire
2013-09-05 7:03 ` Thomas De Schampheleire
2013-09-05 8:04 ` Thomas Petazzoni
2013-09-05 8:35 ` Luca Ceresoli
2013-09-05 14:01 ` Yann E. MORIN
2013-09-05 19:20 ` Thomas De Schampheleire
2013-09-11 12:06 ` Ralph Siemsen
2013-09-12 8:08 ` Thomas De Schampheleire
2013-09-13 18:15 ` [Buildroot] [PATCH v2] " Ralph Siemsen
2013-09-13 18:27 ` Yann E. MORIN
2013-09-15 13:37 ` Ralph Siemsen
2013-09-15 14:13 ` [Buildroot] [PATCH v3] " Ralph Siemsen
2013-09-15 20:09 ` Peter Korsgaard [this message]
2013-09-16 7:11 ` Peter Korsgaard
2013-09-16 12:46 ` Ralph Siemsen
2013-09-16 20:50 ` Peter Korsgaard
2013-09-16 15:24 ` Thomas Petazzoni
2013-09-16 19:45 ` Ralph Siemsen
2013-09-16 20:07 ` Arnout Vandecappelle
2013-09-16 20:49 ` Peter Korsgaard
2013-09-16 20:51 ` Yann E. MORIN
2013-09-16 20:57 ` Peter Korsgaard
2013-09-16 12:36 ` Ralph Siemsen
2013-09-16 13:42 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738p5lud2.fsf@dell.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox