From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] apply-patches.sh: detect missing patches
Date: Mon, 16 Sep 2013 22:07:02 +0200 [thread overview]
Message-ID: <523764E6.1050109@mind.be> (raw)
In-Reply-To: <20130916194547.GA1223@harvey.netwinder.org>
On 16/09/13 21:45, Ralph Siemsen wrote:
> Many of those packages actually build fine, because they explicitly apply only
> the contents of the debian/patches directory. For example from thttpd.mk:
>
> define THTTPD_DEBIAN_PATCHES
> if [ -d $(@D)/debian/patches ]; then \
> support/scripts/apply-patches.sh $(@D) $(@D)/debian/patches \*.patch; \
> fi
> endef
>
> The only broken packages are: cvs sysvinit liblockfile setserial
>
> So we have a couple of options:
> 1) revert the original change back to a warning, or
> 2) fixup the four broken packges using the same method.
> 3) something else.
>
> I'm not sure which way to go, please give me your thoughts.
The issue with e.g. cvs is not that the patch format is wrong, but
rather that the patch files don't have the .patch extension:
$ ls build/cvs-1.12.13/debian/patches/
10_rsc2log_fix 67_date_format_option
11_check_method_crash 68_DSA_external_passwd_file
12_rcs2log_POSIX_sort 69_ext_allowroot
14_ext_expansion 71_cvsbug_tmpfix
15_PATH_MAX_check 80_cvs-repouid-0.1
20_readdir_errno 81_fix_-l
21_getcwd_chroot 85_normalize_correct_roots
25_import-n-X 86_server_wrapper
30_quieten_syslog_errors 89_history_val-tag_world_writeable
31_ipv6 90zlib-read-compressed.diff
51_newlines_in_commit_template 93_homedir
55_keyword_alphanumerics 94_parseopts
56_extra_tags 95_flag_conflicted_copies
60_PAM_support 96_manpage_fixes
61_remove_-R_warning 97_cvs.info.typo
62_cvsrc_whitespace 98_fix_sparc_sigbus.diff
65_login_cvspass_message 99_copyright
66_64bit_crashfix
Of course, before your commit, all these patches (except the few ending
with .diff) were silently ignored, so we can wonder if these debian
patches are actually even necessary...
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2013-09-16 20:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 16:00 [Buildroot] [PATCH] apply-patches.sh: detect missing patches Ralph Siemsen
2013-08-23 10:31 ` Thomas De Schampheleire
2013-09-05 7:03 ` Thomas De Schampheleire
2013-09-05 8:04 ` Thomas Petazzoni
2013-09-05 8:35 ` Luca Ceresoli
2013-09-05 14:01 ` Yann E. MORIN
2013-09-05 19:20 ` Thomas De Schampheleire
2013-09-11 12:06 ` Ralph Siemsen
2013-09-12 8:08 ` Thomas De Schampheleire
2013-09-13 18:15 ` [Buildroot] [PATCH v2] " Ralph Siemsen
2013-09-13 18:27 ` Yann E. MORIN
2013-09-15 13:37 ` Ralph Siemsen
2013-09-15 14:13 ` [Buildroot] [PATCH v3] " Ralph Siemsen
2013-09-15 20:09 ` Peter Korsgaard
2013-09-16 7:11 ` Peter Korsgaard
2013-09-16 12:46 ` Ralph Siemsen
2013-09-16 20:50 ` Peter Korsgaard
2013-09-16 15:24 ` Thomas Petazzoni
2013-09-16 19:45 ` Ralph Siemsen
2013-09-16 20:07 ` Arnout Vandecappelle [this message]
2013-09-16 20:49 ` Peter Korsgaard
2013-09-16 20:51 ` Yann E. MORIN
2013-09-16 20:57 ` Peter Korsgaard
2013-09-16 12:36 ` Ralph Siemsen
2013-09-16 13:42 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523764E6.1050109@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox