* [Buildroot] Broken generation of locales
@ 2013-09-19 6:09 Thierry Bultel
2013-09-19 15:04 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Thierry Bultel @ 2013-09-19 6:09 UTC (permalink / raw)
To: buildroot
Hi,
When setting BR2_GENERATE_LOCALE, for instance like that:
BR2_GENERATE_LOCALE="fr_FR en_US es_ES es_ES.ISO-8859-1 hu_HU"
nothing is generated.
next patch fixes that issue:
diff --git a/Makefile b/Makefile
index 7997e3b..98afd7e 100644
--- a/Makefile
+++ b/Makefile
@@ -543,8 +543,8 @@ ifneq ($(GENERATE_LOCALE),)
target-generatelocales: host-localedef
$(Q)mkdir -p $(TARGET_DIR)/usr/lib/locale/
$(Q)for locale in $(GENERATE_LOCALE) ; do \
- inputfile=`echo $${locale} | cut -f1 -d'.' -s` ; \
- charmap=`echo $${locale} | cut -f2 -d'.' -s` ; \
+ inputfile=`echo $${locale} | cut -f1 -d'.'` ; \
+ charmap=`echo $${locale} | cut -s -f2 -d'.'` ; \
if test -z "$${charmap}" ; then \
charmap="UTF-8" ; \
fi ; \
Cheers
Thierry
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Buildroot] Broken generation of locales
2013-09-19 6:09 [Buildroot] Broken generation of locales Thierry Bultel
@ 2013-09-19 15:04 ` Thomas Petazzoni
2013-09-19 15:28 ` Thierry Bultel
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2013-09-19 15:04 UTC (permalink / raw)
To: buildroot
Dear Thierry Bultel,
On Thu, 19 Sep 2013 08:09:12 +0200, Thierry Bultel wrote:
> When setting BR2_GENERATE_LOCALE, for instance like that:
> BR2_GENERATE_LOCALE="fr_FR en_US es_ES es_ES.ISO-8859-1 hu_HU"
>
> nothing is generated.
>
> next patch fixes that issue:
>
> diff --git a/Makefile b/Makefile
> index 7997e3b..98afd7e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -543,8 +543,8 @@ ifneq ($(GENERATE_LOCALE),)
> target-generatelocales: host-localedef
> $(Q)mkdir -p $(TARGET_DIR)/usr/lib/locale/
> $(Q)for locale in $(GENERATE_LOCALE) ; do \
> - inputfile=`echo $${locale} | cut -f1 -d'.' -s` ; \
> - charmap=`echo $${locale} | cut -f2 -d'.' -s` ; \
> + inputfile=`echo $${locale} | cut -f1 -d'.'` ; \
> + charmap=`echo $${locale} | cut -s -f2 -d'.'` ; \
> if test -z "$${charmap}" ; then \
> charmap="UTF-8" ; \
> fi ; \
This exactly reverts commit 8e2696eab6a781727c09408528678d4d29edd7a3
which was merged in August. I've added Arnout in Cc so that you can
discuss the issue together and decide who wins :-)
Thanks,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread* [Buildroot] Broken generation of locales
2013-09-19 15:04 ` Thomas Petazzoni
@ 2013-09-19 15:28 ` Thierry Bultel
2013-09-19 19:12 ` Arnout Vandecappelle
0 siblings, 1 reply; 6+ messages in thread
From: Thierry Bultel @ 2013-09-19 15:28 UTC (permalink / raw)
To: buildroot
Hi Thomas,
This does not exactly revert the named commit, that
added 's' for both inputfile and charmap.
I pretend that the 's' option is mandatory for charmap only,
else inputfile is always empty:
inputfile:
thierry at thierry-desktop:~$ echo fr_FR | cut -f1 -d '.'
fr_FR
thierry at thierry-desktop:~$ echo fr_FR | cut -f1 -d '.' -s
thierry at thierry-desktop:~$
charmap:
thierry at thierry-desktop:~$ echo fr_FR.utf8 | cut -f2 -d '.'
utf8
thierry at thierry-desktop:~$ echo fr_FR.utf8 | cut -f2 -d '.' -s
utf8
thierry at thierry-desktop:~$ cut --version
cut (GNU coreutils) 7.4
Cheers
Thierry
Le 19/09/2013 17:04, Thomas Petazzoni a ?crit :
> Dear Thierry Bultel,
>
> On Thu, 19 Sep 2013 08:09:12 +0200, Thierry Bultel wrote:
>
>> When setting BR2_GENERATE_LOCALE, for instance like that:
>> BR2_GENERATE_LOCALE="fr_FR en_US es_ES es_ES.ISO-8859-1 hu_HU"
>>
>> nothing is generated.
>>
>> next patch fixes that issue:
>>
>> diff --git a/Makefile b/Makefile
>> index 7997e3b..98afd7e 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -543,8 +543,8 @@ ifneq ($(GENERATE_LOCALE),)
>> target-generatelocales: host-localedef
>> $(Q)mkdir -p $(TARGET_DIR)/usr/lib/locale/
>> $(Q)for locale in $(GENERATE_LOCALE) ; do \
>> - inputfile=`echo $${locale} | cut -f1 -d'.' -s` ; \
>> - charmap=`echo $${locale} | cut -f2 -d'.' -s` ; \
>> + inputfile=`echo $${locale} | cut -f1 -d'.'` ; \
>> + charmap=`echo $${locale} | cut -s -f2 -d'.'` ; \
>> if test -z "$${charmap}" ; then \
>> charmap="UTF-8" ; \
>> fi ; \
> This exactly reverts commit 8e2696eab6a781727c09408528678d4d29edd7a3
> which was merged in August. I've added Arnout in Cc so that you can
> discuss the issue together and decide who wins :-)
>
> Thanks,
>
> Thomas
^ permalink raw reply [flat|nested] 6+ messages in thread* [Buildroot] Broken generation of locales
2013-09-19 15:28 ` Thierry Bultel
@ 2013-09-19 19:12 ` Arnout Vandecappelle
2013-09-19 19:30 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Arnout Vandecappelle @ 2013-09-19 19:12 UTC (permalink / raw)
To: buildroot
On 19/09/13 17:28, Thierry Bultel wrote:
> Hi Thomas,
>
> This does not exactly revert the named commit, that
> added 's' for both inputfile and charmap.
>
> I pretend that the 's' option is mandatory for charmap only,
> else inputfile is always empty:
>
> inputfile:
>
> thierry at thierry-desktop:~$ echo fr_FR | cut -f1 -d '.'
> fr_FR
> thierry at thierry-desktop:~$ echo fr_FR | cut -f1 -d '.' -s
> thierry at thierry-desktop:~$
>
> charmap:
>
> thierry at thierry-desktop:~$ echo fr_FR.utf8 | cut -f2 -d '.'
> utf8
> thierry at thierry-desktop:~$ echo fr_FR.utf8 | cut -f2 -d '.' -s
> utf8
Ack that.
So this patch gets
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Note that you've caused Thomas's confusion by unnecessarily moving the
-s option in the charmap line.
Regards,
Arnout
[snip]
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] Broken generation of locales
2013-09-19 19:12 ` Arnout Vandecappelle
@ 2013-09-19 19:30 ` Thomas Petazzoni
2013-09-19 20:32 ` Arnout Vandecappelle
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2013-09-19 19:30 UTC (permalink / raw)
To: buildroot
Dear Arnout Vandecappelle,
On Thu, 19 Sep 2013 21:12:17 +0200, Arnout Vandecappelle wrote:
> Note that you've caused Thomas's confusion by unnecessarily moving the
> -s option in the charmap line.
Ah, yes. Thierry, can you resend a proper patch (i.e without moving the
-s option in the charmap line, and with a proper description and
Signed-off-by line) ?
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] Broken generation of locales
2013-09-19 19:30 ` Thomas Petazzoni
@ 2013-09-19 20:32 ` Arnout Vandecappelle
0 siblings, 0 replies; 6+ messages in thread
From: Arnout Vandecappelle @ 2013-09-19 20:32 UTC (permalink / raw)
To: buildroot
On 19/09/13 21:30, Thomas Petazzoni wrote:
> Dear Arnout Vandecappelle,
>
> On Thu, 19 Sep 2013 21:12:17 +0200, Arnout Vandecappelle wrote:
>
>> Note that you've caused Thomas's confusion by unnecessarily moving the
>> -s option in the charmap line.
>
> Ah, yes. Thierry, can you resend a proper patch (i.e without moving the
> -s option in the charmap line, and with a proper description and
> Signed-off-by line) ?
And don't forget to add my
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
:-)
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-09-19 20:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-19 6:09 [Buildroot] Broken generation of locales Thierry Bultel
2013-09-19 15:04 ` Thomas Petazzoni
2013-09-19 15:28 ` Thierry Bultel
2013-09-19 19:12 ` Arnout Vandecappelle
2013-09-19 19:30 ` Thomas Petazzoni
2013-09-19 20:32 ` Arnout Vandecappelle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox