[Buildroot] [PATCHv2] dhcpcd: needs MMU

[Buildroot] [PATCHv2] dhcpcd: needs MMU

[Thomas Petazzoni]

dhcpcd fails to build on non-MMU platforms, even with the
--disable-fork option:

  bind.o: In function `_daemonise':
  bind.c:(.text+0x62): undefined reference to `_fork'
  collect2: ld returned 1 exit status

Therefore, we make dhcpcd depend on MMU support, and remove the
non-MMU condition in the .mk file. More recent versions of dhcpcd do
support non-MMU properly, but this commit intends to be only a fix.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
v1 -> v2: remove non-MMU condition in .mk file, mentionned by Gustavo.
---
 package/dhcpcd/Config.in | 1 +
 package/dhcpcd/dhcpcd.mk | 4 ----
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/package/dhcpcd/Config.in b/package/dhcpcd/Config.in
index dbde548..ddbc6f4 100644
--- a/package/dhcpcd/Config.in
+++ b/package/dhcpcd/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_DHCPCD
 	depends on BR2_INET_IPV6
+	depends on BR2_USE_MMU # fork()
 	bool "dhcpcd"
 	help
 	  An RFC2131 compliant DHCP client
diff --git a/package/dhcpcd/dhcpcd.mk b/package/dhcpcd/dhcpcd.mk
index 5296db8..13810f3 100644
--- a/package/dhcpcd/dhcpcd.mk
+++ b/package/dhcpcd/dhcpcd.mk
@@ -9,10 +9,6 @@ DHCPCD_SOURCE = dhcpcd-$(DHCPCD_VERSION).tar.bz2
 DHCPCD_SITE = http://roy.marples.name/downloads/dhcpcd/
 DHCPCD_LICENSE = BSD-2c
 
-ifeq ($(BR2_USE_MMU),)
-	DHCPCD_CONFIG_OPT += --disable-fork
-endif
-
 define DHCPCD_CONFIGURE_CMDS
 	(cd $(@D); \
 	./configure \
-- 
1.8.1.2

[Buildroot] [PATCHv2] dhcpcd: needs MMU

[Yann E. MORIN]

Thomas, All,

On 2013-11-02 14:47 +0100, Thomas Petazzoni spake thusly:
> dhcpcd fails to build on non-MMU platforms, even with the
> --disable-fork option:
> 
>   bind.o: In function `_daemonise':
>   bind.c:(.text+0x62): undefined reference to `_fork'
>   collect2: ld returned 1 exit status
> 
> Therefore, we make dhcpcd depend on MMU support, and remove the
> non-MMU condition in the .mk file. More recent versions of dhcpcd do
> support non-MMU properly, but this commit intends to be only a fix.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

> ---
> v1 -> v2: remove non-MMU condition in .mk file, mentionned by Gustavo.
> ---
>  package/dhcpcd/Config.in | 1 +
>  package/dhcpcd/dhcpcd.mk | 4 ----
>  2 files changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/package/dhcpcd/Config.in b/package/dhcpcd/Config.in
> index dbde548..ddbc6f4 100644
> --- a/package/dhcpcd/Config.in
> +++ b/package/dhcpcd/Config.in
> @@ -1,5 +1,6 @@
>  config BR2_PACKAGE_DHCPCD
>  	depends on BR2_INET_IPV6
> +	depends on BR2_USE_MMU # fork()
>  	bool "dhcpcd"
>  	help
>  	  An RFC2131 compliant DHCP client
> diff --git a/package/dhcpcd/dhcpcd.mk b/package/dhcpcd/dhcpcd.mk
> index 5296db8..13810f3 100644
> --- a/package/dhcpcd/dhcpcd.mk
> +++ b/package/dhcpcd/dhcpcd.mk
> @@ -9,10 +9,6 @@ DHCPCD_SOURCE = dhcpcd-$(DHCPCD_VERSION).tar.bz2
>  DHCPCD_SITE = http://roy.marples.name/downloads/dhcpcd/
>  DHCPCD_LICENSE = BSD-2c
>  
> -ifeq ($(BR2_USE_MMU),)
> -	DHCPCD_CONFIG_OPT += --disable-fork
> -endif
> -
>  define DHCPCD_CONFIGURE_CMDS
>  	(cd $(@D); \
>  	./configure \
> -- 
> 1.8.1.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCHv2] dhcpcd: needs MMU

[Samuel Martin]

2013/11/2 Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

> dhcpcd fails to build on non-MMU platforms, even with the
> --disable-fork option:
>
>   bind.o: In function `_daemonise':
>   bind.c:(.text+0x62): undefined reference to `_fork'
>   collect2: ld returned 1 exit status
>
> Therefore, we make dhcpcd depend on MMU support, and remove the
> non-MMU condition in the .mk file. More recent versions of dhcpcd do
> support non-MMU properly, but this commit intends to be only a fix.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>
Acked-by: Samuel Martin <s.martin49@gmail.com>

Regards,

-- 
Samuel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20131102/27da748b/attachment-0001.html>

[Buildroot] [PATCHv2] dhcpcd: needs MMU

[Thomas Petazzoni]

Dear Thomas Petazzoni,

On Sat,  2 Nov 2013 14:47:01 +0100, Thomas Petazzoni wrote:
> dhcpcd fails to build on non-MMU platforms, even with the
> --disable-fork option:
> 
>   bind.o: In function `_daemonise':
>   bind.c:(.text+0x62): undefined reference to `_fork'
>   collect2: ld returned 1 exit status
> 
> Therefore, we make dhcpcd depend on MMU support, and remove the
> non-MMU condition in the .mk file. More recent versions of dhcpcd do
> support non-MMU properly, but this commit intends to be only a fix.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> v1 -> v2: remove non-MMU condition in .mk file, mentionned by Gustavo.
> ---
>  package/dhcpcd/Config.in | 1 +
>  package/dhcpcd/dhcpcd.mk | 4 ----
>  2 files changed, 1 insertion(+), 4 deletions(-)

Committed to for-peter-2013.11, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com