From: Andi Shyti <andi@etezian.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] scripts: apply-patches: don't stop if no patch is found for a package
Date: Tue, 5 Nov 2013 21:17:53 +0100 [thread overview]
Message-ID: <20131105201752.GC17791@jack.whiskey> (raw)
In-Reply-To: <52793E3A.5060802@mind.be>
Hi Arnout,
> >If no patch is available for a specific package it doesn't mean
> >that is necessarily an error, perhaps there is no need to apply
> >any patches. Therefore, don't stop the build by returning '1',
> >but go ahead.
>
> This is in fact intentional, because it indicates that there is
> something wrong with the configuration. When you specify in your
> configuration that some specific patch directory should be used, but
> that directory doesn't exist, then it probably means you made a
> mistake in your configuration.
>
> Can you give an example of a specific situation where you had a
> problem with this check?
this happens when for example you want to get as cross compiler
the daily snapshot instead of a specific version.
The build stops with an error because of that 'exit 1' since it
doesn't find any gcc-20131105 patch directory (i think the
snapshot is called so).
Andi
next prev parent reply other threads:[~2013-11-05 20:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 13:00 [Buildroot] [PATCH] scripts: apply-patches: don't stop if no patch is found for a package Andi Shyti
2013-11-05 18:51 ` Arnout Vandecappelle
2013-11-05 20:17 ` Andi Shyti [this message]
2013-11-06 21:32 ` Arnout Vandecappelle
2013-11-06 22:16 ` Thomas Petazzoni
2013-11-06 22:59 ` [Buildroot] [PATCH] gcc: use generic infrastructure for patches Arnout Vandecappelle
2013-11-06 23:13 ` Thomas Petazzoni
2013-11-06 23:17 ` Peter Korsgaard
2013-11-06 23:20 ` Arnout Vandecappelle
2013-11-06 23:23 ` Arnout Vandecappelle
2013-11-07 1:19 ` Andi Shyti
2013-11-06 23:40 ` [Buildroot] [PATCH] scripts: apply-patches: don't stop if no patch is found for a package Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131105201752.GC17791@jack.whiskey \
--to=andi@etezian.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox