From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] scripts: apply-patches: don't stop if no patch is found for a package
Date: Tue, 05 Nov 2013 19:51:38 +0100 [thread overview]
Message-ID: <52793E3A.5060802@mind.be> (raw)
In-Reply-To: <1383656430-29160-1-git-send-email-andi@etezian.org>
On 05/11/13 14:00, Andi Shyti wrote:
> If no patch is available for a specific package it doesn't mean
> that is necessarily an error, perhaps there is no need to apply
> any patches. Therefore, don't stop the build by returning '1',
> but go ahead.
This is in fact intentional, because it indicates that there is
something wrong with the configuration. When you specify in your
configuration that some specific patch directory should be used, but that
directory doesn't exist, then it probably means you made a mistake in
your configuration.
Can you give an example of a specific situation where you had a problem
with this check?
Regards,
Arnout
>
> Signed-off-by: Andi Shyti <andi@etezian.org>
> ---
> support/scripts/apply-patches.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/support/scripts/apply-patches.sh b/support/scripts/apply-patches.sh
> index ff72b45..aabab4f 100755
> --- a/support/scripts/apply-patches.sh
> +++ b/support/scripts/apply-patches.sh
> @@ -43,7 +43,7 @@ if [ ! -d "${builddir}" ] ; then
> fi
> if [ ! -d "${patchdir}" ] ; then
> echo "Aborting. '${patchdir}' is not a directory."
> - exit 1
> + exit
> fi
>
> # Remove any rejects present BEFORE patching - Because if there are
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2013-11-05 18:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 13:00 [Buildroot] [PATCH] scripts: apply-patches: don't stop if no patch is found for a package Andi Shyti
2013-11-05 18:51 ` Arnout Vandecappelle [this message]
2013-11-05 20:17 ` Andi Shyti
2013-11-06 21:32 ` Arnout Vandecappelle
2013-11-06 22:16 ` Thomas Petazzoni
2013-11-06 22:59 ` [Buildroot] [PATCH] gcc: use generic infrastructure for patches Arnout Vandecappelle
2013-11-06 23:13 ` Thomas Petazzoni
2013-11-06 23:17 ` Peter Korsgaard
2013-11-06 23:20 ` Arnout Vandecappelle
2013-11-06 23:23 ` Arnout Vandecappelle
2013-11-07 1:19 ` Andi Shyti
2013-11-06 23:40 ` [Buildroot] [PATCH] scripts: apply-patches: don't stop if no patch is found for a package Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52793E3A.5060802@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox