Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi@etezian.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] scripts: apply-patches: don't stop if no patch is found for a package
Date: Thu, 7 Nov 2013 00:40:13 +0100	[thread overview]
Message-ID: <20131106234013.GA9149@jack.whiskey> (raw)
In-Reply-To: <527AB58A.9050506@mind.be>

> >this happens when for example you want to get as cross compiler
> >the daily snapshot instead of a specific version.
> >
> >The build stops with an error because of that 'exit 1' since it
> >doesn't find any gcc-20131105 patch directory (i think the
> >snapshot is called so).
> 
>  That's a bug in the gcc package then :-)
> 
>  It should actually be converted to using the default patch strategy
> instead of post-patch hooks. Let me look into it...

Thanks for looking into it, please add me in CC when you come to
a solution.

Anyway one solution could be to check whether the gcc chosen is a
snapshot or not, something similar:

diff --git a/support/scripts/apply-patches.sh
b/support/scripts/apply-patches.sh
index ff72b45..12f384c 100755
--- a/support/scripts/apply-patches.sh
+++ b/support/scripts/apply-patches.sh
@@ -42,6 +42,11 @@ if [ ! -d "${builddir}" ] ; then
     exit 1
 fi
 if [ ! -d "${patchdir}" ] ; then
+    if grep -q BR2_GCC_VERSION_SNAP=y .config; then
+       echo "Warning: no patch can be applied to the daily snapshot."
+        exit
+    fi
+
     echo "Aborting.  '${patchdir}' is not a directory."
     exit 1
 fi

looks like a hack, but it's the fastest thing that comes to my
mind :)

Andi

      parent reply	other threads:[~2013-11-06 23:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-05 13:00 [Buildroot] [PATCH] scripts: apply-patches: don't stop if no patch is found for a package Andi Shyti
2013-11-05 18:51 ` Arnout Vandecappelle
2013-11-05 20:17   ` Andi Shyti
2013-11-06 21:32     ` Arnout Vandecappelle
2013-11-06 22:16       ` Thomas Petazzoni
2013-11-06 22:59       ` [Buildroot] [PATCH] gcc: use generic infrastructure for patches Arnout Vandecappelle
2013-11-06 23:13         ` Thomas Petazzoni
2013-11-06 23:17           ` Peter Korsgaard
2013-11-06 23:20           ` Arnout Vandecappelle
2013-11-06 23:23             ` Arnout Vandecappelle
2013-11-07  1:19         ` Andi Shyti
2013-11-06 23:40       ` Andi Shyti [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131106234013.GA9149@jack.whiskey \
    --to=andi@etezian.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox