* [Buildroot] [PATCH] Mark MIPS I, II, III and IV as deprecated
@ 2013-11-20 10:42 Vicente Olivert Riera
2013-11-20 11:09 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Vicente Olivert Riera @ 2013-11-20 10:42 UTC (permalink / raw)
To: buildroot
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
arch/Config.in.mips | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/Config.in.mips b/arch/Config.in.mips
index d70fd63..43af33c 100644
--- a/arch/Config.in.mips
+++ b/arch/Config.in.mips
@@ -12,14 +12,16 @@ choice
config BR2_mips_1
bool "mips I (generic)"
- depends on !BR2_ARCH_IS_64
+ depends on !BR2_ARCH_IS_64 && BR2_DEPRECATED
config BR2_mips_2
bool "mips II"
- depends on !BR2_ARCH_IS_64
+ depends on !BR2_ARCH_IS_64 && BR2_DEPRECATED
config BR2_mips_3
bool "mips III"
+ depends on BR2_DEPRECATED
config BR2_mips_4
bool "mips IV"
+ depends on BR2_DEPRECATED
config BR2_mips_32
bool "mips 32"
depends on !BR2_ARCH_IS_64
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] Mark MIPS I, II, III and IV as deprecated
2013-11-20 10:42 [Buildroot] [PATCH] Mark MIPS I, II, III and IV as deprecated Vicente Olivert Riera
@ 2013-11-20 11:09 ` Thomas Petazzoni
2013-11-20 11:51 ` Vicente Olivert Riera
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2013-11-20 11:09 UTC (permalink / raw)
To: buildroot
Dear Vicente Olivert Riera,
On Wed, 20 Nov 2013 10:42:53 +0000, Vicente Olivert Riera wrote:
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
> arch/Config.in.mips | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/Config.in.mips b/arch/Config.in.mips
> index d70fd63..43af33c 100644
> --- a/arch/Config.in.mips
> +++ b/arch/Config.in.mips
> @@ -12,14 +12,16 @@ choice
>
> config BR2_mips_1
> bool "mips I (generic)"
> - depends on !BR2_ARCH_IS_64
> + depends on !BR2_ARCH_IS_64 && BR2_DEPRECATED
> config BR2_mips_2
> bool "mips II"
> - depends on !BR2_ARCH_IS_64
> + depends on !BR2_ARCH_IS_64 && BR2_DEPRECATED
> config BR2_mips_3
> bool "mips III"
> + depends on BR2_DEPRECATED
> config BR2_mips_4
> bool "mips IV"
> + depends on BR2_DEPRECATED
> config BR2_mips_32
> bool "mips 32"
> depends on !BR2_ARCH_IS_64
The commit log should explain *why* we're deprecating these CPU
variants.
Moreover, if we deprecate mips_1 and mips_3, then there should be some
change in:
choice
prompt "Target Architecture Variant"
depends on BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el
default BR2_mips_3 if BR2_mips
default BR2_mips_1 if BR2_mipsel
default BR2_mips_64 if BR2_mips64 || BR2_mips64el
help
at the beginning of Config.in.mips
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread* [Buildroot] [PATCH] Mark MIPS I, II, III and IV as deprecated
2013-11-20 11:09 ` Thomas Petazzoni
@ 2013-11-20 11:51 ` Vicente Olivert Riera
0 siblings, 0 replies; 3+ messages in thread
From: Vicente Olivert Riera @ 2013-11-20 11:51 UTC (permalink / raw)
To: buildroot
On 11/20/2013 11:09 AM, Thomas Petazzoni wrote:
> Dear Vicente Olivert Riera,
>
> On Wed, 20 Nov 2013 10:42:53 +0000, Vicente Olivert Riera wrote:
>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>> ---
>> arch/Config.in.mips | 6 ++++--
>> 1 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/Config.in.mips b/arch/Config.in.mips
>> index d70fd63..43af33c 100644
>> --- a/arch/Config.in.mips
>> +++ b/arch/Config.in.mips
>> @@ -12,14 +12,16 @@ choice
>>
>> config BR2_mips_1
>> bool "mips I (generic)"
>> - depends on !BR2_ARCH_IS_64
>> + depends on !BR2_ARCH_IS_64 && BR2_DEPRECATED
>> config BR2_mips_2
>> bool "mips II"
>> - depends on !BR2_ARCH_IS_64
>> + depends on !BR2_ARCH_IS_64 && BR2_DEPRECATED
>> config BR2_mips_3
>> bool "mips III"
>> + depends on BR2_DEPRECATED
>> config BR2_mips_4
>> bool "mips IV"
>> + depends on BR2_DEPRECATED
>> config BR2_mips_32
>> bool "mips 32"
>> depends on !BR2_ARCH_IS_64
>
> The commit log should explain *why* we're deprecating these CPU
> variants.
>
> Moreover, if we deprecate mips_1 and mips_3, then there should be some
> change in:
>
> choice
> prompt "Target Architecture Variant"
> depends on BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el
> default BR2_mips_3 if BR2_mips
> default BR2_mips_1 if BR2_mipsel
> default BR2_mips_64 if BR2_mips64 || BR2_mips64el
> help
>
> at the beginning of Config.in.mips
>
> Thomas
>
Thanks for your help Thomas. I have sent a V2.
--
Vincent
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-20 11:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-20 10:42 [Buildroot] [PATCH] Mark MIPS I, II, III and IV as deprecated Vicente Olivert Riera
2013-11-20 11:09 ` Thomas Petazzoni
2013-11-20 11:51 ` Vicente Olivert Riera
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox