* [Buildroot] [PATCH v2 1/2] qt: Disable QtScript on MIPS64
@ 2013-11-27 13:42 Vicente Olivert Riera
2013-11-27 13:42 ` [Buildroot] [PATCH v2 2/2] grantlee: Disable " Vicente Olivert Riera
2013-11-27 14:03 ` [Buildroot] [PATCH v2 1/2] qt: Disable QtScript " Thomas Petazzoni
0 siblings, 2 replies; 10+ messages in thread
From: Vicente Olivert Riera @ 2013-11-27 13:42 UTC (permalink / raw)
To: buildroot
There is no support for MIPS64 in QtScript right now, so buildroot
upstream suggested to disable the possibility of enabling QtScript on
MIPS64 as a quick fix for the 2013.11 release:
http://lists.busybox.net/pipermail/buildroot/2013-November/083157.html
A proposed fix to add support for MIPS64 has already been sent to Qt:
https://bugreports.qt-project.org/browse/QTBUG-35030
Fixes:
http://autobuild.buildroot.net/results/fd7/fd7e7e53290f235b540ed5f3c784e2584fdb41e0/
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
package/qt/Config.in | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/package/qt/Config.in b/package/qt/Config.in
index 2651d55..6fd1c94 100644
--- a/package/qt/Config.in
+++ b/package/qt/Config.in
@@ -385,6 +385,7 @@ config BR2_PACKAGE_QT_OPENSSL
config BR2_PACKAGE_QT_SCRIPT
bool "Script Module"
+ depends on !BR2_mips64el && !BR2_mips64
default y
help
Build the Qt Script module.
--
1.7.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 2/2] grantlee: Disable on MIPS64
2013-11-27 13:42 [Buildroot] [PATCH v2 1/2] qt: Disable QtScript on MIPS64 Vicente Olivert Riera
@ 2013-11-27 13:42 ` Vicente Olivert Riera
2013-11-27 14:03 ` [Buildroot] [PATCH v2 1/2] qt: Disable QtScript " Thomas Petazzoni
1 sibling, 0 replies; 10+ messages in thread
From: Vicente Olivert Riera @ 2013-11-27 13:42 UTC (permalink / raw)
To: buildroot
This package selects BR2_PACKAGE_QT_SCRIPT which is not supported on MIPS64
Acked-by: Markos Chandras <markos.chandras@imgtec.com>
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
package/grantlee/Config.in | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/package/grantlee/Config.in b/package/grantlee/Config.in
index 84afad2..e7383fb 100644
--- a/package/grantlee/Config.in
+++ b/package/grantlee/Config.in
@@ -1,5 +1,6 @@
config BR2_PACKAGE_GRANTLEE
bool "grantlee"
+ depends on !BR2_mips64el && !BR2_mips64
select BR2_PACKAGE_QT_STL
select BR2_PACKAGE_QT_SCRIPT
select BR2_PACKAGE_QT_GUI_MODULE
--
1.7.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 1/2] qt: Disable QtScript on MIPS64
2013-11-27 13:42 [Buildroot] [PATCH v2 1/2] qt: Disable QtScript on MIPS64 Vicente Olivert Riera
2013-11-27 13:42 ` [Buildroot] [PATCH v2 2/2] grantlee: Disable " Vicente Olivert Riera
@ 2013-11-27 14:03 ` Thomas Petazzoni
2013-11-27 17:11 ` Vicente Olivert Riera
1 sibling, 1 reply; 10+ messages in thread
From: Thomas Petazzoni @ 2013-11-27 14:03 UTC (permalink / raw)
To: buildroot
Dear Vicente Olivert Riera,
On Wed, 27 Nov 2013 13:42:40 +0000, Vicente Olivert Riera wrote:
> There is no support for MIPS64 in QtScript right now, so buildroot
> upstream suggested to disable the possibility of enabling QtScript on
> MIPS64 as a quick fix for the 2013.11 release:
>
> http://lists.busybox.net/pipermail/buildroot/2013-November/083157.html
>
> A proposed fix to add support for MIPS64 has already been sent to Qt:
>
> https://bugreports.qt-project.org/browse/QTBUG-35030
>
> Fixes:
>
> http://autobuild.buildroot.net/results/fd7/fd7e7e53290f235b540ed5f3c784e2584fdb41e0/
>
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
> package/qt/Config.in | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/package/qt/Config.in b/package/qt/Config.in
> index 2651d55..6fd1c94 100644
> --- a/package/qt/Config.in
> +++ b/package/qt/Config.in
> @@ -385,6 +385,7 @@ config BR2_PACKAGE_QT_OPENSSL
>
> config BR2_PACKAGE_QT_SCRIPT
> bool "Script Module"
> + depends on !BR2_mips64el && !BR2_mips64
> default y
> help
> Build the Qt Script module.
QtScript doesn't build because it uses JavaScriptCore, right? So maybe
we can re-use the existing BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT option,
which already lists which platforms are supported by JavaScriptCore in
Qt4, no?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 1/2] qt: Disable QtScript on MIPS64
2013-11-27 14:03 ` [Buildroot] [PATCH v2 1/2] qt: Disable QtScript " Thomas Petazzoni
@ 2013-11-27 17:11 ` Vicente Olivert Riera
0 siblings, 0 replies; 10+ messages in thread
From: Vicente Olivert Riera @ 2013-11-27 17:11 UTC (permalink / raw)
To: buildroot
On 11/27/2013 02:03 PM, Thomas Petazzoni wrote:
> Dear Vicente Olivert Riera,
>
> On Wed, 27 Nov 2013 13:42:40 +0000, Vicente Olivert Riera wrote:
>> There is no support for MIPS64 in QtScript right now, so buildroot
>> upstream suggested to disable the possibility of enabling QtScript on
>> MIPS64 as a quick fix for the 2013.11 release:
>>
>> http://lists.busybox.net/pipermail/buildroot/2013-November/083157.html
>>
>> A proposed fix to add support for MIPS64 has already been sent to Qt:
>>
>> https://bugreports.qt-project.org/browse/QTBUG-35030
>>
>> Fixes:
>>
>> http://autobuild.buildroot.net/results/fd7/fd7e7e53290f235b540ed5f3c784e2584fdb41e0/
>>
>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>> ---
>> package/qt/Config.in | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/package/qt/Config.in b/package/qt/Config.in
>> index 2651d55..6fd1c94 100644
>> --- a/package/qt/Config.in
>> +++ b/package/qt/Config.in
>> @@ -385,6 +385,7 @@ config BR2_PACKAGE_QT_OPENSSL
>>
>> config BR2_PACKAGE_QT_SCRIPT
>> bool "Script Module"
>> + depends on !BR2_mips64el && !BR2_mips64
>> default y
>> help
>> Build the Qt Script module.
>
> QtScript doesn't build because it uses JavaScriptCore, right? So maybe
> we can re-use the existing BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT option,
> which already lists which platforms are supported by JavaScriptCore in
> Qt4, no?
>
> Best regards,
>
> Thomas
>
Yes, we can do that. V2 patches sent.
Thank you!
--
Vincent
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 1/2] qt: Disable QtScript on MIPS64
@ 2013-11-27 17:10 Vicente Olivert Riera
2013-11-28 10:26 ` Markos Chandras
2013-11-28 12:07 ` Thomas Petazzoni
0 siblings, 2 replies; 10+ messages in thread
From: Vicente Olivert Riera @ 2013-11-27 17:10 UTC (permalink / raw)
To: buildroot
There is no support for MIPS64 in QtScript right now, so buildroot
upstream suggested to disable the possibility of enabling QtScript on
MIPS64 as a quick fix for the 2013.11 release:
http://lists.busybox.net/pipermail/buildroot/2013-November/083157.html
QtScript doesn't build because it uses JavaScriptCore, so we re-use the
existing BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT option which already lists
which platforms are supported by JavaScriptCore in Qt4.
In addition, a proposed fix to add support for MIPS64 has already been
sent to Qt:
https://bugreports.qt-project.org/browse/QTBUG-35030
Fixes:
http://autobuild.buildroot.net/results/fd7/fd7e7e53290f235b540ed5f3c784e2584fdb41e0/
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
package/qt/Config.in | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/package/qt/Config.in b/package/qt/Config.in
index 2651d55..dd2b6d9 100644
--- a/package/qt/Config.in
+++ b/package/qt/Config.in
@@ -385,6 +385,7 @@ config BR2_PACKAGE_QT_OPENSSL
config BR2_PACKAGE_QT_SCRIPT
bool "Script Module"
+ depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
default y
help
Build the Qt Script module.
--
1.7.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 1/2] qt: Disable QtScript on MIPS64
2013-11-27 17:10 Vicente Olivert Riera
@ 2013-11-28 10:26 ` Markos Chandras
2013-11-28 10:28 ` Markos Chandras
2013-11-28 12:07 ` Thomas Petazzoni
1 sibling, 1 reply; 10+ messages in thread
From: Markos Chandras @ 2013-11-28 10:26 UTC (permalink / raw)
To: buildroot
On 11/27/2013 05:10 PM, Vicente Olivert Riera wrote:
> There is no support for MIPS64 in QtScript right now, so buildroot
> upstream suggested to disable the possibility of enabling QtScript on
> MIPS64 as a quick fix for the 2013.11 release:
>
> http://lists.busybox.net/pipermail/buildroot/2013-November/083157.html
>
> QtScript doesn't build because it uses JavaScriptCore, so we re-use the
> existing BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT option which already lists
> which platforms are supported by JavaScriptCore in Qt4.
>
> In addition, a proposed fix to add support for MIPS64 has already been
> sent to Qt:
>
> https://bugreports.qt-project.org/browse/QTBUG-35030
>
> Fixes:
>
> http://autobuild.buildroot.net/results/fd7/fd7e7e53290f235b540ed5f3c784e2584fdb41e0/
>
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
> package/qt/Config.in | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/package/qt/Config.in b/package/qt/Config.in
> index 2651d55..dd2b6d9 100644
> --- a/package/qt/Config.in
> +++ b/package/qt/Config.in
> @@ -385,6 +385,7 @@ config BR2_PACKAGE_QT_OPENSSL
>
> config BR2_PACKAGE_QT_SCRIPT
> bool "Script Module"
> + depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
> default y
> help
> Build the Qt Script module.
>
Technically, this set of patches should have been "v3" because there is
a confusion now on which patch series is the good one.
Having said that, it looks good to me.
--
markos
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 1/2] qt: Disable QtScript on MIPS64
2013-11-28 10:26 ` Markos Chandras
@ 2013-11-28 10:28 ` Markos Chandras
2013-11-28 10:48 ` Vicente Olivert Riera
0 siblings, 1 reply; 10+ messages in thread
From: Markos Chandras @ 2013-11-28 10:28 UTC (permalink / raw)
To: buildroot
On 11/28/2013 10:26 AM, Markos Chandras wrote:
> On 11/27/2013 05:10 PM, Vicente Olivert Riera wrote:
>> There is no support for MIPS64 in QtScript right now, so buildroot
>> upstream suggested to disable the possibility of enabling QtScript on
>> MIPS64 as a quick fix for the 2013.11 release:
>>
>>
>> http://lists.busybox.net/pipermail/buildroot/2013-November/083157.html
>>
>> QtScript doesn't build because it uses JavaScriptCore, so we re-use the
>> existing BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT option which already lists
>> which platforms are supported by JavaScriptCore in Qt4.
>>
>> In addition, a proposed fix to add support for MIPS64 has already been
>> sent to Qt:
>>
>> https://bugreports.qt-project.org/browse/QTBUG-35030
>>
>> Fixes:
>>
>>
>> http://autobuild.buildroot.net/results/fd7/fd7e7e53290f235b540ed5f3c784e2584fdb41e0/
>>
>>
>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>> ---
>> package/qt/Config.in | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/package/qt/Config.in b/package/qt/Config.in
>> index 2651d55..dd2b6d9 100644
>> --- a/package/qt/Config.in
>> +++ b/package/qt/Config.in
>> @@ -385,6 +385,7 @@ config BR2_PACKAGE_QT_OPENSSL
>>
>> config BR2_PACKAGE_QT_SCRIPT
>> bool "Script Module"
>> + depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
>> default y
>> help
>> Build the Qt Script module.
>>
>
> Technically, this set of patches should have been "v3" because there is
> a confusion now on which patch series is the good one.
>
> Having said that, it looks good to me.
>
The Subject is no longer accurate. You are not disabling this package
just for MIPS64 but on other arches as well.
--
markos
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 1/2] qt: Disable QtScript on MIPS64
2013-11-28 10:28 ` Markos Chandras
@ 2013-11-28 10:48 ` Vicente Olivert Riera
0 siblings, 0 replies; 10+ messages in thread
From: Vicente Olivert Riera @ 2013-11-28 10:48 UTC (permalink / raw)
To: buildroot
On 11/28/2013 10:28 AM, Markos Chandras wrote:
> On 11/28/2013 10:26 AM, Markos Chandras wrote:
>> On 11/27/2013 05:10 PM, Vicente Olivert Riera wrote:
>>> There is no support for MIPS64 in QtScript right now, so buildroot
>>> upstream suggested to disable the possibility of enabling QtScript on
>>> MIPS64 as a quick fix for the 2013.11 release:
>>>
>>>
>>> http://lists.busybox.net/pipermail/buildroot/2013-November/083157.html
>>>
>>> QtScript doesn't build because it uses JavaScriptCore, so we re-use the
>>> existing BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT option which already lists
>>> which platforms are supported by JavaScriptCore in Qt4.
>>>
>>> In addition, a proposed fix to add support for MIPS64 has already been
>>> sent to Qt:
>>>
>>> https://bugreports.qt-project.org/browse/QTBUG-35030
>>>
>>> Fixes:
>>>
>>>
>>> http://autobuild.buildroot.net/results/fd7/fd7e7e53290f235b540ed5f3c784e2584fdb41e0/
>>>
>>>
>>>
>>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>>> ---
>>> package/qt/Config.in | 1 +
>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/package/qt/Config.in b/package/qt/Config.in
>>> index 2651d55..dd2b6d9 100644
>>> --- a/package/qt/Config.in
>>> +++ b/package/qt/Config.in
>>> @@ -385,6 +385,7 @@ config BR2_PACKAGE_QT_OPENSSL
>>>
>>> config BR2_PACKAGE_QT_SCRIPT
>>> bool "Script Module"
>>> + depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
>>> default y
>>> help
>>> Build the Qt Script module.
>>>
>>
>> Technically, this set of patches should have been "v3" because there is
>> a confusion now on which patch series is the good one.
>>
>> Having said that, it looks good to me.
>>
> The Subject is no longer accurate. You are not disabling this package
> just for MIPS64 but on other arches as well.
>
V3 sent with the subject amended. Please, take a look.
Thanks :-)
--
Vincent
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 1/2] qt: Disable QtScript on MIPS64
2013-11-27 17:10 Vicente Olivert Riera
2013-11-28 10:26 ` Markos Chandras
@ 2013-11-28 12:07 ` Thomas Petazzoni
2013-11-28 13:49 ` Vicente Olivert Riera
1 sibling, 1 reply; 10+ messages in thread
From: Thomas Petazzoni @ 2013-11-28 12:07 UTC (permalink / raw)
To: buildroot
Dear Vicente Olivert Riera,
On Wed, 27 Nov 2013 17:10:06 +0000, Vicente Olivert Riera wrote:
> diff --git a/package/qt/Config.in b/package/qt/Config.in
> index 2651d55..dd2b6d9 100644
> --- a/package/qt/Config.in
> +++ b/package/qt/Config.in
> @@ -385,6 +385,7 @@ config BR2_PACKAGE_QT_OPENSSL
>
> config BR2_PACKAGE_QT_SCRIPT
> bool "Script Module"
> + depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
I'm wondering if we shouldn't rename this option to something more
exact: ARCH_SUPPORTS_JAVASCRIPTCORE. But I don't know, and we don't
have well established best practices for this kind of things.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 1/2] qt: Disable QtScript on MIPS64
2013-11-28 12:07 ` Thomas Petazzoni
@ 2013-11-28 13:49 ` Vicente Olivert Riera
0 siblings, 0 replies; 10+ messages in thread
From: Vicente Olivert Riera @ 2013-11-28 13:49 UTC (permalink / raw)
To: buildroot
On 11/28/2013 12:07 PM, Thomas Petazzoni wrote:
> Dear Vicente Olivert Riera,
>
> On Wed, 27 Nov 2013 17:10:06 +0000, Vicente Olivert Riera wrote:
>
>> diff --git a/package/qt/Config.in b/package/qt/Config.in
>> index 2651d55..dd2b6d9 100644
>> --- a/package/qt/Config.in
>> +++ b/package/qt/Config.in
>> @@ -385,6 +385,7 @@ config BR2_PACKAGE_QT_OPENSSL
>>
>> config BR2_PACKAGE_QT_SCRIPT
>> bool "Script Module"
>> + depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
>
> I'm wondering if we shouldn't rename this option to something more
> exact: ARCH_SUPPORTS_JAVASCRIPTCORE. But I don't know, and we don't
> have well established best practices for this kind of things.
>
> Thomas
>
Maybe we could keep it as is by now, apply the quick fix for the next
release, and decide what to do in the future. What do you think?
--
Vincent
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2013-11-28 13:49 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-27 13:42 [Buildroot] [PATCH v2 1/2] qt: Disable QtScript on MIPS64 Vicente Olivert Riera
2013-11-27 13:42 ` [Buildroot] [PATCH v2 2/2] grantlee: Disable " Vicente Olivert Riera
2013-11-27 14:03 ` [Buildroot] [PATCH v2 1/2] qt: Disable QtScript " Thomas Petazzoni
2013-11-27 17:11 ` Vicente Olivert Riera
-- strict thread matches above, loose matches on Subject: below --
2013-11-27 17:10 Vicente Olivert Riera
2013-11-28 10:26 ` Markos Chandras
2013-11-28 10:28 ` Markos Chandras
2013-11-28 10:48 ` Vicente Olivert Riera
2013-11-28 12:07 ` Thomas Petazzoni
2013-11-28 13:49 ` Vicente Olivert Riera
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox