[Buildroot] [PATCH] toolchain: Allow ld64.so linker

[Buildroot] [PATCH] toolchain: Allow ld64.so linker

[Anton Blanchard]

From: Jeremy Kerr <jk@ozlabs.org>
    
Expand the glibc dynamic linker check to allow ld64.so.
    
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Signed-off-by: Anton Blanchard <anton@samba.org>
---

diff --git a/toolchain/helpers.mk b/toolchain/helpers.mk
index a8944ce..faa9d90 100644
--- a/toolchain/helpers.mk
+++ b/toolchain/helpers.mk
@@ -204,7 +204,7 @@ check_glibc_rpc_feature = \
 #
 check_glibc = \
 	SYSROOT_DIR="$(strip $1)"; \
-	if test `find $${SYSROOT_DIR}/ -maxdepth 2 -name 'ld-linux*.so.*' -o -name 'ld.so.*' | wc -l` -eq 0 ; then \
+	if test `find $${SYSROOT_DIR}/ -maxdepth 2 -name 'ld-linux*.so.*' -o -name 'ld.so.*' -o -name 'ld64.so.*' | wc -l` -eq 0 ; then \
 		echo "Incorrect selection of the C library"; \
 		exit -1; \
 	fi; \

[Buildroot] [PATCH] toolchain: Allow ld64.so linker

[Thomas Petazzoni]

Dear Anton Blanchard,

On Mon, 2 Dec 2013 17:23:11 +1100, Anton Blanchard wrote:
> From: Jeremy Kerr <jk@ozlabs.org>
>     
> Expand the glibc dynamic linker check to allow ld64.so.

Can you add to the commit log the specific toolchain/situation for
which this is needed? The external toolchain logic is full of special
cases, and I very often read the commit logs to find out why such or
such special case was added.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] toolchain: Allow ld64.so linker

[Anton Blanchard]

Hi Thomas,

> Can you add to the commit log the specific toolchain/situation for
> which this is needed? The external toolchain logic is full of special
> cases, and I very often read the commit logs to find out why such or
> such special case was added.

Definitely. How does this look?

--
From: Jeremy Kerr <jk@ozlabs.org>

The glibc dynamic linkers for ppc64 and s390x are named ld64.so.*
so modify the check_glibc check to match them.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Signed-off-by: Anton Blanchard <anton@samba.org>
---

diff --git a/toolchain/helpers.mk b/toolchain/helpers.mk
index a8944ce..faa9d90 100644
--- a/toolchain/helpers.mk
+++ b/toolchain/helpers.mk
@@ -204,7 +204,7 @@ check_glibc_rpc_feature = \
 #
 check_glibc = \
 	SYSROOT_DIR="$(strip $1)"; \
-	if test `find $${SYSROOT_DIR}/ -maxdepth 2 -name 'ld-linux*.so.*' -o -name 'ld.so.*' | wc -l` -eq 0 ; then \
+	if test `find $${SYSROOT_DIR}/ -maxdepth 2 -name 'ld-linux*.so.*' -o -name 'ld.so.*' -o -name 'ld64.so.*' | wc -l` -eq 0 ; then \
 		echo "Incorrect selection of the C library"; \
 		exit -1; \
 	fi; \

[Buildroot] [PATCH] toolchain: Allow ld64.so linker

[Thomas Petazzoni]

Dear Anton Blanchard,

On Tue, 3 Dec 2013 22:14:37 +1100, Anton Blanchard wrote:
> 
> Hi Thomas,
> 
> > Can you add to the commit log the specific toolchain/situation for
> > which this is needed? The external toolchain logic is full of special
> > cases, and I very often read the commit logs to find out why such or
> > such special case was added.
> 
> Definitely. How does this look?

Perfect. Can you just resubmit just the patch (without this discussion
above it), so that our patchwork picks up a good version of it, that
the BR maintainer can apply?

Also, just curious, are you actually using Buildroot for ppc64 or s390x
machines?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] toolchain: Allow ld64.so linker

[Anton Blanchard]

From: Jeremy Kerr <jk@ozlabs.org>

The glibc dynamic linkers for ppc64 and s390x are named ld64.so.*
so modify the check_glibc test to match them.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Signed-off-by: Anton Blanchard <anton@samba.org>
---

diff --git a/toolchain/helpers.mk b/toolchain/helpers.mk
index a8944ce..faa9d90 100644
--- a/toolchain/helpers.mk
+++ b/toolchain/helpers.mk
@@ -204,7 +204,7 @@ check_glibc_rpc_feature = \
 #
 check_glibc = \
 	SYSROOT_DIR="$(strip $1)"; \
-	if test `find $${SYSROOT_DIR}/ -maxdepth 2 -name 'ld-linux*.so.*' -o -name 'ld.so.*' | wc -l` -eq 0 ; then \
+	if test `find $${SYSROOT_DIR}/ -maxdepth 2 -name 'ld-linux*.so.*' -o -name 'ld.so.*' -o -name 'ld64.so.*' | wc -l` -eq 0 ; then \
 		echo "Incorrect selection of the C library"; \
 		exit -1; \
 	fi; \

[Buildroot] [PATCH] toolchain: Allow ld64.so linker

[Thomas Petazzoni]

Dear Anton Blanchard,

On Tue, 3 Dec 2013 22:26:13 +1100, Anton Blanchard wrote:
> From: Jeremy Kerr <jk@ozlabs.org>
> 
> The glibc dynamic linkers for ppc64 and s390x are named ld64.so.*
> so modify the check_glibc test to match them.
> 
> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
> Signed-off-by: Anton Blanchard <anton@samba.org>

Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] toolchain: Allow ld64.so linker

[Anton Blanchard]

Hi Thomas,

> Perfect. Can you just resubmit just the patch (without this discussion
> above it), so that our patchwork picks up a good version of it, that
> the BR maintainer can apply?

Sure, I just resubmitted and it looks to have hit patchwork already.

> Also, just curious, are you actually using Buildroot for ppc64 or
> s390x machines?

Yes, we used buildroot to bootstrap ppc64le.

Anton

[Buildroot] [PATCH] toolchain: Allow ld64.so linker

[Peter Korsgaard]

>>>>> "Anton" == Anton Blanchard <anton@samba.org> writes:

 > From: Jeremy Kerr <jk@ozlabs.org>
 > The glibc dynamic linkers for ppc64 and s390x are named ld64.so.*
 > so modify the check_glibc test to match them.

 > Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
 > Signed-off-by: Anton Blanchard <anton@samba.org>

Committed, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] toolchain: Allow ld64.so linker

[Thomas Petazzoni]

Dear Anton Blanchard,

On Tue, 3 Dec 2013 22:28:46 +1100, Anton Blanchard wrote:

> > Perfect. Can you just resubmit just the patch (without this discussion
> > above it), so that our patchwork picks up a good version of it, that
> > the BR maintainer can apply?
> 
> Sure, I just resubmitted and it looks to have hit patchwork already.

Thanks!

> > Also, just curious, are you actually using Buildroot for ppc64 or
> > s390x machines?
> 
> Yes, we used buildroot to bootstrap ppc64le.

Cool. Will you submit other patches to enable ppc64/ppc64le ?

Another question: is it possible to mention under the umbrella of which
company this work has been done, in a public way? We're always looking
for some good success stories around Buildroot usage.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com