* [Buildroot] [PATCH] toolchain: Allow ld64.so linker
@ 2013-12-03 11:26 Anton Blanchard
2013-12-03 11:28 ` Thomas Petazzoni
2013-12-03 12:11 ` Peter Korsgaard
0 siblings, 2 replies; 9+ messages in thread
From: Anton Blanchard @ 2013-12-03 11:26 UTC (permalink / raw)
To: buildroot
From: Jeremy Kerr <jk@ozlabs.org>
The glibc dynamic linkers for ppc64 and s390x are named ld64.so.*
so modify the check_glibc test to match them.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Signed-off-by: Anton Blanchard <anton@samba.org>
---
diff --git a/toolchain/helpers.mk b/toolchain/helpers.mk
index a8944ce..faa9d90 100644
--- a/toolchain/helpers.mk
+++ b/toolchain/helpers.mk
@@ -204,7 +204,7 @@ check_glibc_rpc_feature = \
#
check_glibc = \
SYSROOT_DIR="$(strip $1)"; \
- if test `find $${SYSROOT_DIR}/ -maxdepth 2 -name 'ld-linux*.so.*' -o -name 'ld.so.*' | wc -l` -eq 0 ; then \
+ if test `find $${SYSROOT_DIR}/ -maxdepth 2 -name 'ld-linux*.so.*' -o -name 'ld.so.*' -o -name 'ld64.so.*' | wc -l` -eq 0 ; then \
echo "Incorrect selection of the C library"; \
exit -1; \
fi; \
^ permalink raw reply related [flat|nested] 9+ messages in thread* [Buildroot] [PATCH] toolchain: Allow ld64.so linker
2013-12-03 11:26 [Buildroot] [PATCH] toolchain: Allow ld64.so linker Anton Blanchard
@ 2013-12-03 11:28 ` Thomas Petazzoni
2013-12-03 12:11 ` Peter Korsgaard
1 sibling, 0 replies; 9+ messages in thread
From: Thomas Petazzoni @ 2013-12-03 11:28 UTC (permalink / raw)
To: buildroot
Dear Anton Blanchard,
On Tue, 3 Dec 2013 22:26:13 +1100, Anton Blanchard wrote:
> From: Jeremy Kerr <jk@ozlabs.org>
>
> The glibc dynamic linkers for ppc64 and s390x are named ld64.so.*
> so modify the check_glibc test to match them.
>
> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
> Signed-off-by: Anton Blanchard <anton@samba.org>
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] toolchain: Allow ld64.so linker
2013-12-03 11:26 [Buildroot] [PATCH] toolchain: Allow ld64.so linker Anton Blanchard
2013-12-03 11:28 ` Thomas Petazzoni
@ 2013-12-03 12:11 ` Peter Korsgaard
1 sibling, 0 replies; 9+ messages in thread
From: Peter Korsgaard @ 2013-12-03 12:11 UTC (permalink / raw)
To: buildroot
>>>>> "Anton" == Anton Blanchard <anton@samba.org> writes:
> From: Jeremy Kerr <jk@ozlabs.org>
> The glibc dynamic linkers for ppc64 and s390x are named ld64.so.*
> so modify the check_glibc test to match them.
> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
> Signed-off-by: Anton Blanchard <anton@samba.org>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] toolchain: Allow ld64.so linker
@ 2013-12-02 6:23 Anton Blanchard
2013-12-02 10:09 ` Thomas Petazzoni
0 siblings, 1 reply; 9+ messages in thread
From: Anton Blanchard @ 2013-12-02 6:23 UTC (permalink / raw)
To: buildroot
From: Jeremy Kerr <jk@ozlabs.org>
Expand the glibc dynamic linker check to allow ld64.so.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Signed-off-by: Anton Blanchard <anton@samba.org>
---
diff --git a/toolchain/helpers.mk b/toolchain/helpers.mk
index a8944ce..faa9d90 100644
--- a/toolchain/helpers.mk
+++ b/toolchain/helpers.mk
@@ -204,7 +204,7 @@ check_glibc_rpc_feature = \
#
check_glibc = \
SYSROOT_DIR="$(strip $1)"; \
- if test `find $${SYSROOT_DIR}/ -maxdepth 2 -name 'ld-linux*.so.*' -o -name 'ld.so.*' | wc -l` -eq 0 ; then \
+ if test `find $${SYSROOT_DIR}/ -maxdepth 2 -name 'ld-linux*.so.*' -o -name 'ld.so.*' -o -name 'ld64.so.*' | wc -l` -eq 0 ; then \
echo "Incorrect selection of the C library"; \
exit -1; \
fi; \
^ permalink raw reply related [flat|nested] 9+ messages in thread* [Buildroot] [PATCH] toolchain: Allow ld64.so linker
2013-12-02 6:23 Anton Blanchard
@ 2013-12-02 10:09 ` Thomas Petazzoni
2013-12-03 11:14 ` Anton Blanchard
0 siblings, 1 reply; 9+ messages in thread
From: Thomas Petazzoni @ 2013-12-02 10:09 UTC (permalink / raw)
To: buildroot
Dear Anton Blanchard,
On Mon, 2 Dec 2013 17:23:11 +1100, Anton Blanchard wrote:
> From: Jeremy Kerr <jk@ozlabs.org>
>
> Expand the glibc dynamic linker check to allow ld64.so.
Can you add to the commit log the specific toolchain/situation for
which this is needed? The external toolchain logic is full of special
cases, and I very often read the commit logs to find out why such or
such special case was added.
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] toolchain: Allow ld64.so linker
2013-12-02 10:09 ` Thomas Petazzoni
@ 2013-12-03 11:14 ` Anton Blanchard
2013-12-03 11:21 ` Thomas Petazzoni
0 siblings, 1 reply; 9+ messages in thread
From: Anton Blanchard @ 2013-12-03 11:14 UTC (permalink / raw)
To: buildroot
Hi Thomas,
> Can you add to the commit log the specific toolchain/situation for
> which this is needed? The external toolchain logic is full of special
> cases, and I very often read the commit logs to find out why such or
> such special case was added.
Definitely. How does this look?
--
From: Jeremy Kerr <jk@ozlabs.org>
The glibc dynamic linkers for ppc64 and s390x are named ld64.so.*
so modify the check_glibc check to match them.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Signed-off-by: Anton Blanchard <anton@samba.org>
---
diff --git a/toolchain/helpers.mk b/toolchain/helpers.mk
index a8944ce..faa9d90 100644
--- a/toolchain/helpers.mk
+++ b/toolchain/helpers.mk
@@ -204,7 +204,7 @@ check_glibc_rpc_feature = \
#
check_glibc = \
SYSROOT_DIR="$(strip $1)"; \
- if test `find $${SYSROOT_DIR}/ -maxdepth 2 -name 'ld-linux*.so.*' -o -name 'ld.so.*' | wc -l` -eq 0 ; then \
+ if test `find $${SYSROOT_DIR}/ -maxdepth 2 -name 'ld-linux*.so.*' -o -name 'ld.so.*' -o -name 'ld64.so.*' | wc -l` -eq 0 ; then \
echo "Incorrect selection of the C library"; \
exit -1; \
fi; \
^ permalink raw reply related [flat|nested] 9+ messages in thread* [Buildroot] [PATCH] toolchain: Allow ld64.so linker
2013-12-03 11:14 ` Anton Blanchard
@ 2013-12-03 11:21 ` Thomas Petazzoni
2013-12-03 11:28 ` Anton Blanchard
0 siblings, 1 reply; 9+ messages in thread
From: Thomas Petazzoni @ 2013-12-03 11:21 UTC (permalink / raw)
To: buildroot
Dear Anton Blanchard,
On Tue, 3 Dec 2013 22:14:37 +1100, Anton Blanchard wrote:
>
> Hi Thomas,
>
> > Can you add to the commit log the specific toolchain/situation for
> > which this is needed? The external toolchain logic is full of special
> > cases, and I very often read the commit logs to find out why such or
> > such special case was added.
>
> Definitely. How does this look?
Perfect. Can you just resubmit just the patch (without this discussion
above it), so that our patchwork picks up a good version of it, that
the BR maintainer can apply?
Also, just curious, are you actually using Buildroot for ppc64 or s390x
machines?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] toolchain: Allow ld64.so linker
2013-12-03 11:21 ` Thomas Petazzoni
@ 2013-12-03 11:28 ` Anton Blanchard
2013-12-03 12:16 ` Thomas Petazzoni
0 siblings, 1 reply; 9+ messages in thread
From: Anton Blanchard @ 2013-12-03 11:28 UTC (permalink / raw)
To: buildroot
Hi Thomas,
> Perfect. Can you just resubmit just the patch (without this discussion
> above it), so that our patchwork picks up a good version of it, that
> the BR maintainer can apply?
Sure, I just resubmitted and it looks to have hit patchwork already.
> Also, just curious, are you actually using Buildroot for ppc64 or
> s390x machines?
Yes, we used buildroot to bootstrap ppc64le.
Anton
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] toolchain: Allow ld64.so linker
2013-12-03 11:28 ` Anton Blanchard
@ 2013-12-03 12:16 ` Thomas Petazzoni
0 siblings, 0 replies; 9+ messages in thread
From: Thomas Petazzoni @ 2013-12-03 12:16 UTC (permalink / raw)
To: buildroot
Dear Anton Blanchard,
On Tue, 3 Dec 2013 22:28:46 +1100, Anton Blanchard wrote:
> > Perfect. Can you just resubmit just the patch (without this discussion
> > above it), so that our patchwork picks up a good version of it, that
> > the BR maintainer can apply?
>
> Sure, I just resubmitted and it looks to have hit patchwork already.
Thanks!
> > Also, just curious, are you actually using Buildroot for ppc64 or
> > s390x machines?
>
> Yes, we used buildroot to bootstrap ppc64le.
Cool. Will you submit other patches to enable ppc64/ppc64le ?
Another question: is it possible to mention under the umbrella of which
company this work has been done, in a public way? We're always looking
for some good success stories around Buildroot usage.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-12-03 12:16 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-03 11:26 [Buildroot] [PATCH] toolchain: Allow ld64.so linker Anton Blanchard
2013-12-03 11:28 ` Thomas Petazzoni
2013-12-03 12:11 ` Peter Korsgaard
-- strict thread matches above, loose matches on Subject: below --
2013-12-02 6:23 Anton Blanchard
2013-12-02 10:09 ` Thomas Petazzoni
2013-12-03 11:14 ` Anton Blanchard
2013-12-03 11:21 ` Thomas Petazzoni
2013-12-03 11:28 ` Anton Blanchard
2013-12-03 12:16 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox