* [Buildroot] [PATCH] uclibc: snapshot: add BSD obsolete signal functions
@ 2014-01-02 11:53 Baruch Siach
2014-01-02 12:23 ` Thomas Petazzoni
2014-01-10 23:10 ` Peter Korsgaard
0 siblings, 2 replies; 4+ messages in thread
From: Baruch Siach @ 2014-01-02 11:53 UTC (permalink / raw)
To: buildroot
Fixes
http://autobuild.buildroot.net/results/70b/70b79ca0aa97ed451a5679029955ed3709c84b67/.
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
package/uclibc/uClibc-snapshot.config | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/uclibc/uClibc-snapshot.config b/package/uclibc/uClibc-snapshot.config
index 9ca3f9ea983d..890aefd8ec59 100644
--- a/package/uclibc/uClibc-snapshot.config
+++ b/package/uclibc/uClibc-snapshot.config
@@ -152,7 +152,7 @@ UCLIBC_LINUX_SPECIFIC=y
UCLIBC_HAS_GNU_ERROR=y
UCLIBC_BSD_SPECIFIC=y
UCLIBC_HAS_BSD_ERR=y
-# UCLIBC_HAS_OBSOLETE_BSD_SIGNAL is not set
+UCLIBC_HAS_OBSOLETE_BSD_SIGNAL=y
# UCLIBC_HAS_OBSOLETE_SYSV_SIGNAL is not set
# UCLIBC_NTP_LEGACY is not set
# UCLIBC_SV4_DEPRECATED is not set
--
1.8.5.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] uclibc: snapshot: add BSD obsolete signal functions
2014-01-02 11:53 [Buildroot] [PATCH] uclibc: snapshot: add BSD obsolete signal functions Baruch Siach
@ 2014-01-02 12:23 ` Thomas Petazzoni
2014-01-02 12:33 ` Baruch Siach
2014-01-10 23:10 ` Peter Korsgaard
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2014-01-02 12:23 UTC (permalink / raw)
To: buildroot
Dear Baruch Siach,
On Thu, 2 Jan 2014 13:53:03 +0200, Baruch Siach wrote:
> Fixes
> http://autobuild.buildroot.net/results/70b/70b79ca0aa97ed451a5679029955ed3709c84b67/.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> package/uclibc/uClibc-snapshot.config | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/uclibc/uClibc-snapshot.config b/package/uclibc/uClibc-snapshot.config
> index 9ca3f9ea983d..890aefd8ec59 100644
> --- a/package/uclibc/uClibc-snapshot.config
> +++ b/package/uclibc/uClibc-snapshot.config
> @@ -152,7 +152,7 @@ UCLIBC_LINUX_SPECIFIC=y
> UCLIBC_HAS_GNU_ERROR=y
> UCLIBC_BSD_SPECIFIC=y
> UCLIBC_HAS_BSD_ERR=y
> -# UCLIBC_HAS_OBSOLETE_BSD_SIGNAL is not set
> +UCLIBC_HAS_OBSOLETE_BSD_SIGNAL=y
We don't have this option enabled in the uClibc-0.9.33.config. Is there
a reason why it should be enabled for the uClibc-snapshot.config and
not for uClibc-0.9.33.config ? Does netsnmp builds with uClibc 0.9.33
on some other architecture?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] uclibc: snapshot: add BSD obsolete signal functions
2014-01-02 12:23 ` Thomas Petazzoni
@ 2014-01-02 12:33 ` Baruch Siach
0 siblings, 0 replies; 4+ messages in thread
From: Baruch Siach @ 2014-01-02 12:33 UTC (permalink / raw)
To: buildroot
Hi Thomas,
On Thu, Jan 02, 2014 at 01:23:18PM +0100, Thomas Petazzoni wrote:
> On Thu, 2 Jan 2014 13:53:03 +0200, Baruch Siach wrote:
> > Fixes
> > http://autobuild.buildroot.net/results/70b/70b79ca0aa97ed451a5679029955ed3709c84b67/.
> >
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > ---
> > package/uclibc/uClibc-snapshot.config | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/package/uclibc/uClibc-snapshot.config b/package/uclibc/uClibc-snapshot.config
> > index 9ca3f9ea983d..890aefd8ec59 100644
> > --- a/package/uclibc/uClibc-snapshot.config
> > +++ b/package/uclibc/uClibc-snapshot.config
> > @@ -152,7 +152,7 @@ UCLIBC_LINUX_SPECIFIC=y
> > UCLIBC_HAS_GNU_ERROR=y
> > UCLIBC_BSD_SPECIFIC=y
> > UCLIBC_HAS_BSD_ERR=y
> > -# UCLIBC_HAS_OBSOLETE_BSD_SIGNAL is not set
> > +UCLIBC_HAS_OBSOLETE_BSD_SIGNAL=y
>
> We don't have this option enabled in the uClibc-0.9.33.config. Is there
> a reason why it should be enabled for the uClibc-snapshot.config and
> not for uClibc-0.9.33.config ? Does netsnmp builds with uClibc 0.9.33
> on some other architecture?
The netsnmp configure scripts tests for sighold(). This test fails when
UCLIBC_HAS_OBSOLETE_BSD_SIGNAL is disabled. In this case the code in
apps/snmpnetstat/if.c uses the alternative sigblock() API. This has been
removed completely from uClibc after 0.9.33 with commit 5aa7aa7fa7ec2a
(signal: remove sigblock, siggetmask and sigsetmask). That's why we need
UCLIBC_HAS_OBSOLETE_BSD_SIGNAL for netsnmp to build only when uClibc snapshot
is selected.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] uclibc: snapshot: add BSD obsolete signal functions
2014-01-02 11:53 [Buildroot] [PATCH] uclibc: snapshot: add BSD obsolete signal functions Baruch Siach
2014-01-02 12:23 ` Thomas Petazzoni
@ 2014-01-10 23:10 ` Peter Korsgaard
1 sibling, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2014-01-10 23:10 UTC (permalink / raw)
To: buildroot
>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
> Fixes
> http://autobuild.buildroot.net/results/70b/70b79ca0aa97ed451a5679029955ed3709c84b67/.
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-01-10 23:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-02 11:53 [Buildroot] [PATCH] uclibc: snapshot: add BSD obsolete signal functions Baruch Siach
2014-01-02 12:23 ` Thomas Petazzoni
2014-01-02 12:33 ` Baruch Siach
2014-01-10 23:10 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox