From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] linux: only depend on host-lzop if needed
Date: Tue, 28 Jan 2014 23:14:37 +0100 [thread overview]
Message-ID: <20140128231437.22b6a7ee@skate> (raw)
In-Reply-To: <1d22a1ff0f39a4b4e8fe4186cf9696a44a01e20f.1390744549.git.yann.morin.1998@free.fr>
Dear Yann E. MORIN,
On Sun, 26 Jan 2014 14:56:27 +0100, Yann E. MORIN wrote:
> +ifeq ($(call KCONFIG_GET_OPT,CONFIG_KERNEL_LZO,$(call qstrip,$(KERNEL_SOURCE_CONFIG))),y)
> +LINUX_DEPENDENCIES += host-lzop
> +endif
Do this works reliably? KERNEL_SOURCE_CONFIG typically points to a
minimal defconfig file (say arch/arm/configs/mvebu_defconfig). So if
CONFIG_KERNEL_LZO is the default choice for the kernel, it will not
appear in the defconfig, and therefore the piece of code above will not
realize that we need host-lzop, because the test is done before "make
mvebu_defconfig" is executed and turns it back into a full
configuration file.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-01-28 22:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-26 13:56 [Buildroot] [PATCH 0/2] linux: do not always depend on host-lzop Yann E. MORIN
2014-01-26 13:56 ` [Buildroot] [PATCH 1/2] packages infra: add function to get a Kconfig option Yann E. MORIN
2014-01-26 20:02 ` Peter Korsgaard
2014-01-26 20:25 ` Yann E. MORIN
2014-01-26 22:14 ` Peter Korsgaard
2014-01-26 20:33 ` Yann E. MORIN
2014-01-27 21:48 ` Arnout Vandecappelle
2014-01-26 13:56 ` [Buildroot] [PATCH 2/2] linux: only depend on host-lzop if needed Yann E. MORIN
2014-01-26 20:23 ` Peter Korsgaard
2014-01-27 21:51 ` Arnout Vandecappelle
2014-01-28 22:14 ` Thomas Petazzoni [this message]
2014-01-28 22:17 ` Peter Korsgaard
2014-01-28 22:20 ` Thomas Petazzoni
2014-01-28 22:24 ` Peter Korsgaard
2014-01-28 22:21 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140128231437.22b6a7ee@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox