Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] packages infra: add function to get a Kconfig option
Date: Sun, 26 Jan 2014 23:14:45 +0100	[thread overview]
Message-ID: <87y522z8yy.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20140126202538.GC1752@free.fr> (Yann E. MORIN's message of "Sun,  26 Jan 2014 21:25:38 +0100")

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

Hi,

 >> Should this perhaps use $(SED)?

 > $(SED) is 'sed -i -e'

 > And we don't want to replace in-place!

 > BTW, that $(SED) is 'sed -i -e' is really bugging me everytime I need
 > to use sed.

 > I thionk we should introduce:
 >   SED := sed -e
 >   SEDI := sed -i -e

 > We unfortunately have that many calls to $(SED) here and there... We'd
 > need to audit and replace all of them.

Hmm, yes - Agreed (even though I don't think we really need a SEDI). I
don't really know why we added -i to SED, but I agree that it isn't
really nice (it dates back to the 2d523c23 mega commit).


 >> Sorry, I'm probably missing something, but I don't right away see why we
 >> don't just use:
 >> 
 >> $(SED) -n 's/^$(1)=//p' $(2)

 > Oh, I just copied and adapted the commands in the lines above, from
 > KCONFIG_SET_OPT or KCONFIG_ENABLE_OPT.

Ahh, ok - Then I prefer the simple variant then - I believe it behaves
identical but is directly obvious (to me).

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2014-01-26 22:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-26 13:56 [Buildroot] [PATCH 0/2] linux: do not always depend on host-lzop Yann E. MORIN
2014-01-26 13:56 ` [Buildroot] [PATCH 1/2] packages infra: add function to get a Kconfig option Yann E. MORIN
2014-01-26 20:02   ` Peter Korsgaard
2014-01-26 20:25     ` Yann E. MORIN
2014-01-26 22:14       ` Peter Korsgaard [this message]
2014-01-26 20:33     ` Yann E. MORIN
2014-01-27 21:48   ` Arnout Vandecappelle
2014-01-26 13:56 ` [Buildroot] [PATCH 2/2] linux: only depend on host-lzop if needed Yann E. MORIN
2014-01-26 20:23   ` Peter Korsgaard
2014-01-27 21:51   ` Arnout Vandecappelle
2014-01-28 22:14   ` Thomas Petazzoni
2014-01-28 22:17     ` Peter Korsgaard
2014-01-28 22:20       ` Thomas Petazzoni
2014-01-28 22:24         ` Peter Korsgaard
2014-01-28 22:21     ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y522z8yy.fsf@dell.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox