Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] packages infra: add function to get a Kconfig option
Date: Sun, 26 Jan 2014 21:02:52 +0100	[thread overview]
Message-ID: <87wqhm1pg3.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <b68b4ce8c5017701344c6f32a993de7d3e26802b.1390744549.git.yann.morin.1998@free.fr> (Yann E. MORIN's message of "Sun, 26 Jan 2014 14:56:26 +0100")

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > From: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > We so far have no mean to get the value from a Kconfig option from the
 > .config file of a package (eg. linux, busybox...).

 > Add a new function that returns the unmangled value of an option.
 > It expect two arguments:
 >   - the Kconfig option name (complete, with leading CONFIG if necessary)
 >   - the .config file to get it from

 > Note that, if the Kconfig option is a string, the returned value will
 > contain the leading and trailing double-quotes.

 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > ---
 >  package/pkg-utils.mk | 6 ++++++
 >  1 file changed, 6 insertions(+)

 > diff --git a/package/pkg-utils.mk b/package/pkg-utils.mk
 > index 851575c..2f70acc 100644
 > --- a/package/pkg-utils.mk
 > +++ b/package/pkg-utils.mk
 > @@ -52,6 +52,12 @@ define KCONFIG_DISABLE_OPT
 >  	echo "# $(1) is not set" >> $(2)
 >  endef
 
 > +# Note: we do not indent this, since we want to avoid any leading
 > +# space or tabs when calling this function
 > +define KCONFIG_GET_OPT
 > +$(shell sed -e "/\\<$(1)\\>=\\(.*\\)$$/!d; s//\\1/" $(2))

Should this perhaps use $(SED)?

Sorry, I'm probably missing something, but I don't right away see why we
don't just use:

$(SED) -n 's/^$(1)=//p' $(2)

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2014-01-26 20:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-26 13:56 [Buildroot] [PATCH 0/2] linux: do not always depend on host-lzop Yann E. MORIN
2014-01-26 13:56 ` [Buildroot] [PATCH 1/2] packages infra: add function to get a Kconfig option Yann E. MORIN
2014-01-26 20:02   ` Peter Korsgaard [this message]
2014-01-26 20:25     ` Yann E. MORIN
2014-01-26 22:14       ` Peter Korsgaard
2014-01-26 20:33     ` Yann E. MORIN
2014-01-27 21:48   ` Arnout Vandecappelle
2014-01-26 13:56 ` [Buildroot] [PATCH 2/2] linux: only depend on host-lzop if needed Yann E. MORIN
2014-01-26 20:23   ` Peter Korsgaard
2014-01-27 21:51   ` Arnout Vandecappelle
2014-01-28 22:14   ` Thomas Petazzoni
2014-01-28 22:17     ` Peter Korsgaard
2014-01-28 22:20       ` Thomas Petazzoni
2014-01-28 22:24         ` Peter Korsgaard
2014-01-28 22:21     ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wqhm1pg3.fsf@dell.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox