* [Buildroot] [PATCH] libtorrent: disable on ARC arch @ 2014-02-10 11:27 Anton Kolesov 2014-02-10 11:33 ` Thomas De Schampheleire 0 siblings, 1 reply; 8+ messages in thread From: Anton Kolesov @ 2014-02-10 11:27 UTC (permalink / raw) To: buildroot Libtorrent has dependencies on atomic operations. However ARC GCC doesn't implement those at the moment so package should be disabled. This fixes: http://autobuild.buildroot.net/results/51414e22c8ea47c38df20d864526a370c5a895d7/ Signed-off-by: Anton Kolesov <anton.kolesov@synopsys.com> --- package/libtorrent/Config.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/package/libtorrent/Config.in b/package/libtorrent/Config.in index a7e358d..6c8d09d 100644 --- a/package/libtorrent/Config.in +++ b/package/libtorrent/Config.in @@ -2,6 +2,8 @@ config BR2_PACKAGE_LIBTORRENT bool "libtorrent" depends on BR2_INSTALL_LIBSTDCPP depends on BR2_TOOLCHAIN_HAS_THREADS + # ARC GCC doesn't support atomic instructions required by this lib + depends on !BR2_arc select BR2_PACKAGE_LIBSIGC help BitTorrent library written in C++ for *nix -- 1.8.4.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH] libtorrent: disable on ARC arch 2014-02-10 11:27 [Buildroot] [PATCH] libtorrent: disable on ARC arch Anton Kolesov @ 2014-02-10 11:33 ` Thomas De Schampheleire 2014-02-10 12:17 ` Thomas Petazzoni 0 siblings, 1 reply; 8+ messages in thread From: Thomas De Schampheleire @ 2014-02-10 11:33 UTC (permalink / raw) To: buildroot Hi Anton, On Mon, Feb 10, 2014 at 12:27 PM, Anton Kolesov <anton.kolesov@synopsys.com> wrote: > Libtorrent has dependencies on atomic operations. However ARC GCC doesn't > implement those at the moment so package should be disabled. > > This fixes: > http://autobuild.buildroot.net/results/51414e22c8ea47c38df20d864526a370c5a895d7/ > > Signed-off-by: Anton Kolesov <anton.kolesov@synopsys.com> > --- > package/libtorrent/Config.in | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/package/libtorrent/Config.in b/package/libtorrent/Config.in > index a7e358d..6c8d09d 100644 > --- a/package/libtorrent/Config.in > +++ b/package/libtorrent/Config.in > @@ -2,6 +2,8 @@ config BR2_PACKAGE_LIBTORRENT > bool "libtorrent" > depends on BR2_INSTALL_LIBSTDCPP > depends on BR2_TOOLCHAIN_HAS_THREADS > + # ARC GCC doesn't support atomic instructions required by this lib > + depends on !BR2_arc > select BR2_PACKAGE_LIBSIGC > help > BitTorrent library written in C++ for *nix This extra 'depends on' should be repeated on the comment about toolchain options below, so that this comment is only visible when the actual package is visible. Have a look at http://buildroot.uclibc.org/downloads/manual/manual.html#dependencies-target-toolchain-options (Note: you don't have to repeat the "# ARG GCC doesn't support ..." on the comment) Best regards, Thomas ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH] libtorrent: disable on ARC arch 2014-02-10 11:33 ` Thomas De Schampheleire @ 2014-02-10 12:17 ` Thomas Petazzoni 2014-02-10 12:39 ` [Buildroot] [PATCH v2] " Anton Kolesov 0 siblings, 1 reply; 8+ messages in thread From: Thomas Petazzoni @ 2014-02-10 12:17 UTC (permalink / raw) To: buildroot Thomas, Anton, On Mon, 10 Feb 2014 12:33:06 +0100, Thomas De Schampheleire wrote: > > + # ARC GCC doesn't support atomic instructions required by this lib > > + depends on !BR2_arc Wrong indentation: one tab should be used. > > select BR2_PACKAGE_LIBSIGC > > help > > BitTorrent library written in C++ for *nix > > This extra 'depends on' should be repeated on the comment about > toolchain options below, so that this comment is only visible when the > actual package is visible. > Have a look at http://buildroot.uclibc.org/downloads/manual/manual.html#dependencies-target-toolchain-options > > (Note: you don't have to repeat the "# ARG GCC doesn't support ..." on > the comment) And this additional dependency should be propagated to the reverse dependencies of libtorrent, i.e the rtorrent package. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH v2] libtorrent: disable on ARC arch 2014-02-10 12:17 ` Thomas Petazzoni @ 2014-02-10 12:39 ` Anton Kolesov 2014-02-10 12:53 ` Thomas Petazzoni 0 siblings, 1 reply; 8+ messages in thread From: Anton Kolesov @ 2014-02-10 12:39 UTC (permalink / raw) To: buildroot Is that better? Libtorrent has dependencies on atomic operations. However ARC GCC doesn't implement those at the moment so package should be disabled. Rtorrent depends on libtorrent. This fixes: http://autobuild.buildroot.net/results/51414e22c8ea47c38df20d864526a370c5a895d7/ Signed-off-by: Anton Kolesov <anton.kolesov@synopsys.com> --- package/libtorrent/Config.in | 3 +++ package/rtorrent/Config.in | 1 + 2 files changed, 4 insertions(+) diff --git a/package/libtorrent/Config.in b/package/libtorrent/Config.in index a7e358d..a21bf95 100644 --- a/package/libtorrent/Config.in +++ b/package/libtorrent/Config.in @@ -2,6 +2,8 @@ config BR2_PACKAGE_LIBTORRENT bool "libtorrent" depends on BR2_INSTALL_LIBSTDCPP depends on BR2_TOOLCHAIN_HAS_THREADS + # ARC GCC doesn't support atomic instructions required by this lib + depends on !BR2_arc select BR2_PACKAGE_LIBSIGC help BitTorrent library written in C++ for *nix @@ -10,3 +12,4 @@ config BR2_PACKAGE_LIBTORRENT comment "libtorrent needs a toolchain w/ C++, threads" depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS + depends on !BR2_arc diff --git a/package/rtorrent/Config.in b/package/rtorrent/Config.in index 0f39a92..f2dc47b 100644 --- a/package/rtorrent/Config.in +++ b/package/rtorrent/Config.in @@ -17,3 +17,4 @@ config BR2_PACKAGE_RTORRENT comment "rtorrent needs a toolchain w/ C++, threads, wchar" depends on BR2_USE_MMU depends on !(BR2_INSTALL_LIBSTDCPP && BR2_USE_WCHAR && BR2_TOOLCHAIN_HAS_THREADS) + depends on !BR2_arc -- 1.8.4.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH v2] libtorrent: disable on ARC arch 2014-02-10 12:39 ` [Buildroot] [PATCH v2] " Anton Kolesov @ 2014-02-10 12:53 ` Thomas Petazzoni 2014-02-10 14:09 ` [Buildroot] [PATCH v3] " Anton Kolesov 0 siblings, 1 reply; 8+ messages in thread From: Thomas Petazzoni @ 2014-02-10 12:53 UTC (permalink / raw) To: buildroot Dear Anton Kolesov, On Mon, 10 Feb 2014 16:39:42 +0400, Anton Kolesov wrote: > Is that better? This "Is that better?" shouldn't be part of the commit log. Instead, it should be below the "---" sign. > > Libtorrent has dependencies on atomic operations. However ARC GCC doesn't > implement those at the moment so package should be disabled. Rtorrent > depends on libtorrent. > > This fixes: > http://autobuild.buildroot.net/results/51414e22c8ea47c38df20d864526a370c5a895d7/ > > Signed-off-by: Anton Kolesov <anton.kolesov@synopsys.com> > --- > package/libtorrent/Config.in | 3 +++ > package/rtorrent/Config.in | 1 + > 2 files changed, 4 insertions(+) > > diff --git a/package/libtorrent/Config.in b/package/libtorrent/Config.in > index a7e358d..a21bf95 100644 > --- a/package/libtorrent/Config.in > +++ b/package/libtorrent/Config.in > @@ -2,6 +2,8 @@ config BR2_PACKAGE_LIBTORRENT > bool "libtorrent" > depends on BR2_INSTALL_LIBSTDCPP > depends on BR2_TOOLCHAIN_HAS_THREADS > + # ARC GCC doesn't support atomic instructions required by this lib > + depends on !BR2_arc > select BR2_PACKAGE_LIBSIGC > help > BitTorrent library written in C++ for *nix > @@ -10,3 +12,4 @@ config BR2_PACKAGE_LIBTORRENT > > comment "libtorrent needs a toolchain w/ C++, threads" > depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS > + depends on !BR2_arc > diff --git a/package/rtorrent/Config.in b/package/rtorrent/Config.in > index 0f39a92..f2dc47b 100644 > --- a/package/rtorrent/Config.in > +++ b/package/rtorrent/Config.in > @@ -17,3 +17,4 @@ config BR2_PACKAGE_RTORRENT > comment "rtorrent needs a toolchain w/ C++, threads, wchar" > depends on BR2_USE_MMU > depends on !(BR2_INSTALL_LIBSTDCPP && BR2_USE_WCHAR && BR2_TOOLCHAIN_HAS_THREADS) > + depends on !BR2_arc It should also be propagated as a dependency of the BR2_PACKAGE_RTORRENT option itself, so that this package cannot be selected on ARC. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH v3] libtorrent: disable on ARC arch 2014-02-10 12:53 ` Thomas Petazzoni @ 2014-02-10 14:09 ` Anton Kolesov 2014-02-10 14:24 ` Thomas Petazzoni 2014-02-10 14:42 ` Peter Korsgaard 0 siblings, 2 replies; 8+ messages in thread From: Anton Kolesov @ 2014-02-10 14:09 UTC (permalink / raw) To: buildroot Libtorrent has dependencies on atomic operations. However ARC GCC doesn't implement those at the moment so package should be disabled. Rtorrent depends on libtorrent. This fixes: http://autobuild.buildroot.net/results/51414e22c8ea47c38df20d864526a370c5a895d7/ Signed-off-by: Anton Kolesov <anton.kolesov@synopsys.com> --- package/libtorrent/Config.in | 3 +++ package/rtorrent/Config.in | 3 +++ 2 files changed, 6 insertions(+) diff --git a/package/libtorrent/Config.in b/package/libtorrent/Config.in index a7e358d..a21bf95 100644 --- a/package/libtorrent/Config.in +++ b/package/libtorrent/Config.in @@ -2,6 +2,8 @@ config BR2_PACKAGE_LIBTORRENT bool "libtorrent" depends on BR2_INSTALL_LIBSTDCPP depends on BR2_TOOLCHAIN_HAS_THREADS + # ARC GCC doesn't support atomic instructions required by this lib + depends on !BR2_arc select BR2_PACKAGE_LIBSIGC help BitTorrent library written in C++ for *nix @@ -10,3 +12,4 @@ config BR2_PACKAGE_LIBTORRENT comment "libtorrent needs a toolchain w/ C++, threads" depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS + depends on !BR2_arc diff --git a/package/rtorrent/Config.in b/package/rtorrent/Config.in index 0f39a92..fa81cde 100644 --- a/package/rtorrent/Config.in +++ b/package/rtorrent/Config.in @@ -4,6 +4,8 @@ config BR2_PACKAGE_RTORRENT depends on BR2_USE_WCHAR depends on BR2_TOOLCHAIN_HAS_THREADS depends on BR2_USE_MMU # fork() + # ARC GCC doesn't support atomic instructions required by libtorrent + depends on !BR2_arc select BR2_PACKAGE_LIBCURL select BR2_PACKAGE_LIBSIGC select BR2_PACKAGE_LIBTORRENT @@ -17,3 +19,4 @@ config BR2_PACKAGE_RTORRENT comment "rtorrent needs a toolchain w/ C++, threads, wchar" depends on BR2_USE_MMU depends on !(BR2_INSTALL_LIBSTDCPP && BR2_USE_WCHAR && BR2_TOOLCHAIN_HAS_THREADS) + depends on !BR2_arc -- 1.8.4.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH v3] libtorrent: disable on ARC arch 2014-02-10 14:09 ` [Buildroot] [PATCH v3] " Anton Kolesov @ 2014-02-10 14:24 ` Thomas Petazzoni 2014-02-10 14:42 ` Peter Korsgaard 1 sibling, 0 replies; 8+ messages in thread From: Thomas Petazzoni @ 2014-02-10 14:24 UTC (permalink / raw) To: buildroot Dear Anton Kolesov, On Mon, 10 Feb 2014 18:09:41 +0400, Anton Kolesov wrote: > Libtorrent has dependencies on atomic operations. However ARC GCC doesn't > implement those at the moment so package should be disabled. Rtorrent > depends on libtorrent. > > This fixes: > http://autobuild.buildroot.net/results/51414e22c8ea47c38df20d864526a370c5a895d7/ > > Signed-off-by: Anton Kolesov <anton.kolesov@synopsys.com> > --- > package/libtorrent/Config.in | 3 +++ > package/rtorrent/Config.in | 3 +++ > 2 files changed, 6 insertions(+) Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH v3] libtorrent: disable on ARC arch 2014-02-10 14:09 ` [Buildroot] [PATCH v3] " Anton Kolesov 2014-02-10 14:24 ` Thomas Petazzoni @ 2014-02-10 14:42 ` Peter Korsgaard 1 sibling, 0 replies; 8+ messages in thread From: Peter Korsgaard @ 2014-02-10 14:42 UTC (permalink / raw) To: buildroot >>>>> "Anton" == Anton Kolesov <anton.kolesov@synopsys.com> writes: > Libtorrent has dependencies on atomic operations. However ARC GCC doesn't > implement those at the moment so package should be disabled. Rtorrent > depends on libtorrent. > This fixes: > http://autobuild.buildroot.net/results/51414e22c8ea47c38df20d864526a370c5a895d7/ > Signed-off-by: Anton Kolesov <anton.kolesov@synopsys.com> Committed, thanks. -- Bye, Peter Korsgaard ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-02-10 14:42 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-02-10 11:27 [Buildroot] [PATCH] libtorrent: disable on ARC arch Anton Kolesov 2014-02-10 11:33 ` Thomas De Schampheleire 2014-02-10 12:17 ` Thomas Petazzoni 2014-02-10 12:39 ` [Buildroot] [PATCH v2] " Anton Kolesov 2014-02-10 12:53 ` Thomas Petazzoni 2014-02-10 14:09 ` [Buildroot] [PATCH v3] " Anton Kolesov 2014-02-10 14:24 ` Thomas Petazzoni 2014-02-10 14:42 ` Peter Korsgaard
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox