From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] udev: update udev to new virtual package infra.
Date: Mon, 17 Feb 2014 11:49:06 +0100 [thread overview]
Message-ID: <20140217114906.5b6aab4a@skate> (raw)
In-Reply-To: <1392632536-16714-2-git-send-email-eric.le.bihan.dev@free.fr>
Dear Eric Le Bihan,
On Mon, 17 Feb 2014 11:22:15 +0100, Eric Le Bihan wrote:
> -ifeq ($(BR2_PACKAGE_EUDEV),y)
> -UDEV_DEPENDENCIES += eudev
> -endif
> -
> -ifeq ($(BR2_PACKAGE_SYSTEMD),y)
> -UDEV_DEPENDENCIES += systemd
> -endif
> +UDEV_DEPENDENCIES = $(call qstrip,$(BR2_PACKAGE_PROVIDES_UDEV))
>
> ifeq ($(UDEV_DEPENDENCIES),)
> define UDEV_CONFIGURE_CMDS
> - echo "No Udev implementation selected. Configuration error."
> + $(error No Udev implementation selected. Configuration error)
> exit 1
> endef
> endif
Why are we doing this check in UDEV_CONFIGURE_CMDS ? I believe we can
simply do:
ifeq ($(<foo>_DEPENDENCIES),)
$(error No <foo> implementation selected)
endif
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-02-17 10:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 10:22 [Buildroot] [PATCH 0/2] systemd/udev/eudev polishing Eric Le Bihan
2014-02-17 10:22 ` [Buildroot] [PATCH 1/2] udev: update udev to new virtual package infra Eric Le Bihan
2014-02-17 10:49 ` Thomas Petazzoni [this message]
2014-02-17 14:33 ` Eric Le Bihan
2014-02-17 14:37 ` Thomas Petazzoni
2014-02-17 15:07 ` Eric Le Bihan
2014-02-18 10:03 ` Eric Le Bihan
2014-02-18 10:06 ` Thomas Petazzoni
2014-02-17 10:22 ` [Buildroot] [PATCH 2/2] systemd: enable required kernel features Eric Le Bihan
2014-02-17 10:57 ` Thomas Petazzoni
2014-02-17 14:37 ` Eric Le Bihan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140217114906.5b6aab4a@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox