Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Le Bihan <eric.le.bihan.dev@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] udev: update udev to new virtual package infra.
Date: Mon, 17 Feb 2014 16:07:17 +0100	[thread overview]
Message-ID: <20140217150714.GC4920@pc-eric> (raw)
In-Reply-To: <20140217153745.1e5683e9@skate>

On Mon, Feb 17, 2014 at 03:37:45PM +0100, Thomas Petazzoni wrote:
> Dear Eric Le Bihan,
>
> On Mon, 17 Feb 2014 15:33:13 +0100, Eric Le Bihan wrote:
>
> > > Why are we doing this check in UDEV_CONFIGURE_CMDS ? I believe we can
> > > simply do:
> > >
> > > ifeq ($(<foo>_DEPENDENCIES),)
> > > $(error No <foo> implementation selected)
> > > endif
> > I followed the example in package/opengl/libegl/libegl.mk, but I mixed the
> > Makefile control function $(error text...) and some Shell script without
> > thinking...
> >
> > I will revert it to the pure shell version to be coherent.
>
> I guess you mean "to the pure make version", according to what you say
> below, right?
>
No. I was thinking about keeping the shell version for this series and making
the change in the new series that would update all the virtual packages, but
thinking twice about it, it is better to make it now (patches could be applied
in any order).

Best regards,
ELB

  reply	other threads:[~2014-02-17 15:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-17 10:22 [Buildroot] [PATCH 0/2] systemd/udev/eudev polishing Eric Le Bihan
2014-02-17 10:22 ` [Buildroot] [PATCH 1/2] udev: update udev to new virtual package infra Eric Le Bihan
2014-02-17 10:49   ` Thomas Petazzoni
2014-02-17 14:33     ` Eric Le Bihan
2014-02-17 14:37       ` Thomas Petazzoni
2014-02-17 15:07         ` Eric Le Bihan [this message]
2014-02-18 10:03         ` Eric Le Bihan
2014-02-18 10:06           ` Thomas Petazzoni
2014-02-17 10:22 ` [Buildroot] [PATCH 2/2] systemd: enable required kernel features Eric Le Bihan
2014-02-17 10:57   ` Thomas Petazzoni
2014-02-17 14:37     ` Eric Le Bihan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140217150714.GC4920@pc-eric \
    --to=eric.le.bihan.dev@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox