From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] udev: update udev to new virtual package infra.
Date: Tue, 18 Feb 2014 11:06:37 +0100 [thread overview]
Message-ID: <20140218110637.4d9ba6c7@skate> (raw)
In-Reply-To: <20140218100331.GA6731@pc-eric>
Dear Eric Le Bihan,
On Tue, 18 Feb 2014 11:03:33 +0100, Eric Le Bihan wrote:
> I've made some further testing and unfortunately, the pure "make" solution
> does not work. The test on <foo>_DEPENDENCIES is performed when the Makefile
> is evaluated, whether <foo> virtual package is selected or not.
>
> If virtual package <foo> is not selected, <foo>_DEPENDENCIES will be empty, so
> the test is true and the error message is displayed. That's not what we want.
>
> Using <foo>_CONFIGURE_CMDS, the test will only be performed if the package is
> selected.
Then, just improve the test so that the test against the dependencies
is only made when the virtual package is selected:
ifeq ($(BR2_PACKAGE_<virtual package>),y)
ifeq ($(<virtual package>_DEPENDENCIES),)
$(error "Something wrong going on!")
endif
endif
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-02-18 10:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 10:22 [Buildroot] [PATCH 0/2] systemd/udev/eudev polishing Eric Le Bihan
2014-02-17 10:22 ` [Buildroot] [PATCH 1/2] udev: update udev to new virtual package infra Eric Le Bihan
2014-02-17 10:49 ` Thomas Petazzoni
2014-02-17 14:33 ` Eric Le Bihan
2014-02-17 14:37 ` Thomas Petazzoni
2014-02-17 15:07 ` Eric Le Bihan
2014-02-18 10:03 ` Eric Le Bihan
2014-02-18 10:06 ` Thomas Petazzoni [this message]
2014-02-17 10:22 ` [Buildroot] [PATCH 2/2] systemd: enable required kernel features Eric Le Bihan
2014-02-17 10:57 ` Thomas Petazzoni
2014-02-17 14:37 ` Eric Le Bihan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140218110637.4d9ba6c7@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox