[Buildroot] [PATCH 1/2] lvm2: add readline bump fix patch

[Buildroot] [PATCH 1/2] lvm2: add readline bump fix patch

[Gustavo Zacarias]

Fixes:
http://autobuild.buildroot.net/results/d6f/d6f4d388c62ec2137560aabbff46c4a30c584e18/

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 package/lvm2/lvm2-001-readline-deprecated.patch | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 package/lvm2/lvm2-001-readline-deprecated.patch

diff --git a/package/lvm2/lvm2-001-readline-deprecated.patch b/package/lvm2/lvm2-001-readline-deprecated.patch
new file mode 100644
index 0000000..15dc626
--- /dev/null
+++ b/package/lvm2/lvm2-001-readline-deprecated.patch
@@ -0,0 +1,19 @@
+The CPPFunction typedef (among others) have been deprecated in favour of
+specific prototyped typedefs since readline 4.2.
+They've been working since because compatibility typedefs have been
+until they were removed in readline 6.3.
+
+Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
+
+diff -Nura LVM2.2.02.103.orig/tools/lvm.c LVM2.2.02.103/tools/lvm.c
+--- LVM2.2.02.103.orig/tools/lvm.c	2014-03-01 16:10:57.902422044 -0300
++++ LVM2.2.02.103/tools/lvm.c	2014-03-01 16:11:34.791598230 -0300
+@@ -185,7 +185,7 @@
+ 	char *input = NULL, *args[MAX_ARGS], **argv;
+ 
+ 	rl_readline_name = "lvm";
+-	rl_attempted_completion_function = (CPPFunction *) _completion;
++	rl_attempted_completion_function = (rl_completion_func_t *) _completion;
+ 
+ 	_read_history(cmd);
+ 
-- 
1.8.3.2

[Buildroot] [PATCH 2/2] parted: add readline bump fix patch

[Gustavo Zacarias]

Fixes:
http://autobuild.buildroot.net/results/1e9/1e90929bfaf617381d490dc0b99f333968624ce7/

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 package/parted/parted-001-readline-deprecated.patch | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 package/parted/parted-001-readline-deprecated.patch

diff --git a/package/parted/parted-001-readline-deprecated.patch b/package/parted/parted-001-readline-deprecated.patch
new file mode 100644
index 0000000..989c029
--- /dev/null
+++ b/package/parted/parted-001-readline-deprecated.patch
@@ -0,0 +1,19 @@
+The CPPFunction typedef (among others) have been deprecated in favour of
+specific prototyped typedefs since readline 4.2.
+They've been working since because compatibility typedefs have been
+until they were removed in readline 6.3.
+
+Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
+
+diff -Nura parted-3.1.orig/parted/ui.c parted-3.1/parted/ui.c
+--- parted-3.1.orig/parted/ui.c	2014-03-01 16:11:41.970827134 -0300
++++ parted-3.1/parted/ui.c	2014-03-01 16:11:55.540259786 -0300
+@@ -1474,7 +1474,7 @@
+ #ifdef HAVE_LIBREADLINE
+   if (!opt_script_mode) {
+     rl_initialize ();
+-    rl_attempted_completion_function = (CPPFunction*) complete_function;
++    rl_attempted_completion_function = (rl_completion_func_t *) complete_function;
+     readline_state.in_readline = 0;
+   }
+ #endif
-- 
1.8.3.2

[Buildroot] [PATCH 1/2] lvm2: add readline bump fix patch

[Thomas Petazzoni]

Dear Gustavo Zacarias,

On Sat,  1 Mar 2014 16:21:03 -0300, Gustavo Zacarias wrote:

> +The CPPFunction typedef (among others) have been deprecated in favour of

s/have/has/

> +specific prototyped typedefs since readline 4.2.
> +They've been working since because compatibility typedefs have been
> +until they were removed in readline 6.3.

I don't understand this last sentence. Is it my english that it too
limited, or because the sentence doesn't make sense? :-)

Same question for PATCH 2/2, which has the same issue.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/2] lvm2: add readline bump fix patch

[Gustavo Zacarias]

On 03/01/2014 04:42 PM, Thomas Petazzoni wrote:

> Dear Gustavo Zacarias,
> 
> On Sat,  1 Mar 2014 16:21:03 -0300, Gustavo Zacarias wrote:
> 
>> +The CPPFunction typedef (among others) have been deprecated in favour of
> 
> s/have/has/
> 
>> +specific prototyped typedefs since readline 4.2.
>> +They've been working since because compatibility typedefs have been
>> +until they were removed in readline 6.3.
> 
> I don't understand this last sentence. Is it my english that it too
> limited, or because the sentence doesn't make sense? :-)
> 
> Same question for PATCH 2/2, which has the same issue.

Pff i'm still on vacation ;)
AFAIK 'have' is valid since i'm talking of many though i'm focusing on
just one in the patch.
"They've been working" (the typedefs) "since" (the deprecation) "because
compatibility typedefs have been" (+ in place... missing that) until
they were removed in readline 6.3
Regards.

[Buildroot] [PATCH 1/2] lvm2: add readline bump fix patch

[Thomas Petazzoni]

Dear Gustavo Zacarias,

On Sat, 01 Mar 2014 16:46:50 -0300, Gustavo Zacarias wrote:
> On 03/01/2014 04:42 PM, Thomas Petazzoni wrote:
> 
> > Dear Gustavo Zacarias,
> > 
> > On Sat,  1 Mar 2014 16:21:03 -0300, Gustavo Zacarias wrote:
> > 
> >> +The CPPFunction typedef (among others) have been deprecated in favour of
> > 
> > s/have/has/
> > 
> >> +specific prototyped typedefs since readline 4.2.
> >> +They've been working since because compatibility typedefs have been
> >> +until they were removed in readline 6.3.
> > 
> > I don't understand this last sentence. Is it my english that it too
> > limited, or because the sentence doesn't make sense? :-)
> > 
> > Same question for PATCH 2/2, which has the same issue.
> 
> Pff i'm still on vacation ;)
> AFAIK 'have' is valid since i'm talking of many though i'm focusing on
> just one in the patch.
> "They've been working" (the typedefs) "since" (the deprecation) "because
> compatibility typedefs have been" (+ in place... missing that) until
> they were removed in readline 6.3

May I request new patches that fix these minor issues?

Thanks :-)

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com