From: Eric Le Bihan <eric.le.bihan.dev@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] systemd: Build legacy pc files when liblogging is
Date: Mon, 14 Apr 2014 11:35:46 +0200 [thread overview]
Message-ID: <20140414093546.GB5385@pc-eric> (raw)
In-Reply-To: <5347ACFD.907@imgtec.com>
On Fri, Apr 11, 2014 at 09:51:09AM +0100, Vicente Olivert Riera wrote:
> On 04/10/2014 10:18 PM, Peter Korsgaard wrote:
> >>>>>>"Eric" == Eric Le Bihan <eric.le.bihan.dev@free.fr> writes:
> >
> >Hi,
> >
> > > Maybe some other packages depend on these compatibility libraries, so instead
> > > of referring to BR2_PACKAGE_LIBLOGGING in systemd.mk, it would be best to add
> > > a generic configuration option to systemd, as done for berkeleydb with
> > > BR2_PACKAGE_BERKELEYDB_COMPAT185. It could be named BR2_PACKAGE_SYSTEMD_COMPAT.
> >
> > > Then, in package/liblogging/Config.in, we would have:
> >
> > > select BR2_PACKAGE_SYSTEMD_COMPAT if BR2_INIT_SYSTEMD
> >
> > > And this would be removed when liblogging is fixed upstream.
> >
> >Yes, I agree.
> >
> > > What do think of this?
> >
> >Care to send an updated patch series doing that?
> >
>
> I didn't do that in purpose, because I thought it would be a good
> idea to catch those packages that still look for legacy systemd
> files, so we could tell upstream about that, as I did for
> liblogging.
I posted an implementation of BR2_PACKAGE_SYSTEMD_COMPAT. If other packages
depend on the old libsystemd-*.so, I think this will allow us to catch them
too, as they will not select this new symbol yet.
>
> If we put that option as a generic one, then we will never remove it
> from there and we will be using the not-default systemd config
> forever.
As a reminder, I added a comment in the log about this.
Best regards,
ELB
prev parent reply other threads:[~2014-04-14 9:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 15:59 [Buildroot] [PATCH 1/2] systemd: Build legacy pc files when liblogging is Vicente Olivert Riera
2014-04-10 15:59 ` [Buildroot] [PATCH 2/2] liblogging: Depend on systemd Vicente Olivert Riera
2014-04-10 21:17 ` Peter Korsgaard
2014-04-10 17:50 ` [Buildroot] [PATCH 1/2] systemd: Build legacy pc files when liblogging is Eric Le Bihan
2014-04-10 21:18 ` Peter Korsgaard
2014-04-11 8:51 ` Vicente Olivert Riera
2014-04-14 9:35 ` Eric Le Bihan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140414093546.GB5385@pc-eric \
--to=eric.le.bihan.dev@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox