From: Eric Le Bihan <eric.le.bihan.dev@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] smack: new package.
Date: Mon, 21 Apr 2014 13:56:07 +0200 [thread overview]
Message-ID: <20140421115606.GA4082@milhouse> (raw)
In-Reply-To: <20140421121901.743513ef@skate>
Hi!
On Mon, Apr 21, 2014 at 12:19:01PM +0200, Thomas Petazzoni wrote:
> Dear Eric Le Bihan,
>
> On Sun, 20 Apr 2014 20:54:03 +0200, Eric Le Bihan wrote:
>
> > diff --git a/package/smack/Config.in b/package/smack/Config.in
> > new file mode 100644
> > index 0000000..971b79a
> > --- /dev/null
> > +++ b/package/smack/Config.in
> > @@ -0,0 +1,28 @@
> > +config BR2_PACKAGE_SMACK
> > + bool "smack"
>
> Dependency on !BR2_PREFER_STATIC_LIB was missing, due to <dlfcn.h>
> usage. Remember to build test your packages with
> http://autobuild.buildroot.org/toolchains/configs/free-electrons/bfin-linux-uclibc.config
> (to test !MMU) and
> http://autobuild.buildroot.org/toolchains/configs/free-electrons/bfin-uclinux.config
> (to test !MMU and BR2_PREFER_STATIC_LIB).
Thanks for the polishing! Wouldn't it be useful to add a stanza in the
docs/manual/contribute.txt about performing some compliancy tests using these
two configurations before submitting new packages? Are there any other
criteria that could fit compliancy tests/checklist?
Best regards,
ELB
next prev parent reply other threads:[~2014-04-21 11:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-20 18:54 [Buildroot] [PATCH 0/2] SMACK: mandatory access control Eric Le Bihan
2014-04-20 18:54 ` [Buildroot] [PATCH 1/2] smack: new package Eric Le Bihan
2014-04-21 10:19 ` Thomas Petazzoni
2014-04-21 11:56 ` Eric Le Bihan [this message]
2014-04-21 11:55 ` Thomas Petazzoni
2014-04-21 12:49 ` Thomas De Schampheleire
2014-04-24 20:14 ` Peter Korsgaard
2014-04-25 7:16 ` Thomas Petazzoni
2014-04-20 18:54 ` [Buildroot] [PATCH 2/2] systemd: add SMACK support option Eric Le Bihan
2014-06-08 14:33 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140421115606.GA4082@milhouse \
--to=eric.le.bihan.dev@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox