From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] ti-gfx: pkg-config should also set parent include dir
Date: Fri, 30 May 2014 22:27:18 +0200 [thread overview]
Message-ID: <20140530222718.5cb42dd5@free-electrons.com> (raw)
In-Reply-To: <CAEBucnDa_EjmUu2buXEA16by0_Wck+sp-RF1Rajc8uSOswb_Zg@mail.gmail.com>
Dear Spenser Gilliland,
On Fri, 30 May 2014 14:57:19 -0500, Spenser Gilliland wrote:
> > Yes, Qt5's cmake files assume /usr/include not /usr/include/GLES2.
> >
> > I added -I${includedir} instead of removing only "GLES2" because then
> nothing will break,
> > and the other .pc file also sets both dirs.
> > But it seems common practice is to not add the uppercase dir names in the
> pkg-congig file.
You should fix your e-mail client, as it very badly handles quotations.
> This patch won't break anything. But it would be nice if you could go back
> and reverify this just to be sure.
>
> My reasoning is that, /usr/include is a default include dir which all
> compilers should use automatically. There should not be a need to
> manually specify it.
Agreed, and therefore I'd like to understand in more details why the
patch is needed. We typically don't commit things we don't understand
why they are needed :)
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-05-30 20:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 15:00 [Buildroot] [PATCH 1/1] ti-gfx: pkg-config should also set parent include dir Peter Kümmel
2014-05-30 15:31 ` Spenser Gilliland
2014-05-30 15:55 ` Peter Kümmel
2014-05-30 19:57 ` Spenser Gilliland
2014-05-30 20:27 ` Thomas Petazzoni [this message]
2014-05-30 20:41 ` Peter Kümmel
2014-05-30 20:52 ` Peter Korsgaard
2014-05-30 21:29 ` Peter Kümmel
2014-05-30 21:41 ` Peter Korsgaard
2014-05-31 4:34 ` Peter Kümmel
2014-05-31 9:37 ` Yann E. MORIN
2014-05-31 9:39 ` Yann E. MORIN
2014-05-31 11:48 ` Peter Korsgaard
2014-05-30 20:57 ` Yann E. MORIN
2014-05-30 21:16 ` Peter Kümmel
2014-05-30 21:23 ` Yann E. MORIN
2014-05-30 21:39 ` Peter Kümmel
2014-05-30 21:42 ` Yann E. MORIN
2014-05-30 20:32 ` Peter Kümmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140530222718.5cb42dd5@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox