Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Peter Kümmel" <syntheticpp@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] ti-gfx: pkg-config should also set parent include dir
Date: Fri, 30 May 2014 23:29:55 +0200	[thread overview]
Message-ID: <5388F853.1020406@gmx.net> (raw)
In-Reply-To: <8761kn7zw8.fsf@dell.be.48ers.dk>

On 30.05.2014 22:52, Peter Korsgaard wrote:
>>>>>> "Peter" == Peter K?mmel <syntheticpp@gmx.net> writes:
>
> Hi,
>
>   >> Agreed, and therefore I'd like to understand in more details why the
>   >> patch is needed. We typically don't commit things we don't understand
>   >> why they are needed :)
>
>   > In short: anybody assumes "#include <GLES2/gl2.h>" works when the search
>   > paths of pkg-config are used. But when pkg-config reports /usr/include/GLES2
>   > gl2.h could not be found, because there is no /usr/include/GLES2/GLES2/gl2.h.
>
>   > Until now this doesn't pop up because by chance the directory GLES2
>   > resides in /usr/include and this path is added by most by build systems.
>   > But the cmake configure scripts of Qt5 test for "GLES2/gl2.h" only in the path
>   > reported by pkg-config.
>
> But $SYSROOT/usr/include is the standard include path, so gcc
> automatically looks there. What exactly doesn't work for you?

See my last mail with the cmake code.

Overall I think it is the best solution that pkg-config reports
a path which in combination with the uppercase prefix in #include
makes it possible to include an OpenGL header without being dependent
on any implicit set include paths.

I don't know if Ubuntu is a reference here, but when you install gles2
     sudo apt-get install libgles2-mesa-dev
and have a look at the.pc file,
     cat /usr/lib/x86_64-linux-gnu/pkgconfig/glesv2.pc
(or gl.pc) you see, that there also the path to the dir containing GLES2 is set:

prefix=/usr
exec_prefix=${prefix}
libdir=${prefix}/lib/x86_64-linux-gnu
includedir=${prefix}/include

Name: glesv2
Description: Mesa OpenGL ES 2.0 library
Requires.private:
Version: 9.0.3
Libs: -L${libdir} -lGLESv2
Libs.private: -lm -lpthread -ldl
Cflags: -I${includedir}


>
> This is exactly the same as E.G. #include <sys/stat.h> for open(2).
>

  reply	other threads:[~2014-05-30 21:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-30 15:00 [Buildroot] [PATCH 1/1] ti-gfx: pkg-config should also set parent include dir Peter Kümmel
2014-05-30 15:31 ` Spenser Gilliland
2014-05-30 15:55   ` Peter Kümmel
2014-05-30 19:57     ` Spenser Gilliland
2014-05-30 20:27       ` Thomas Petazzoni
2014-05-30 20:41         ` Peter Kümmel
2014-05-30 20:52           ` Peter Korsgaard
2014-05-30 21:29             ` Peter Kümmel [this message]
2014-05-30 21:41               ` Peter Korsgaard
2014-05-31  4:34                 ` Peter Kümmel
2014-05-31  9:37                   ` Yann E. MORIN
2014-05-31  9:39                     ` Yann E. MORIN
2014-05-31 11:48                       ` Peter Korsgaard
2014-05-30 20:57           ` Yann E. MORIN
2014-05-30 21:16             ` Peter Kümmel
2014-05-30 21:23               ` Yann E. MORIN
2014-05-30 21:39                 ` Peter Kümmel
2014-05-30 21:42                   ` Yann E. MORIN
2014-05-30 20:32       ` Peter Kümmel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5388F853.1020406@gmx.net \
    --to=syntheticpp@gmx.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox