From: "Peter Kümmel" <syntheticpp@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] ti-gfx: pkg-config should also set parent include dir
Date: Fri, 30 May 2014 17:55:08 +0200 [thread overview]
Message-ID: <5388A9DC.1010204@gmx.net> (raw)
In-Reply-To: <CAEBucnAiAtrF1uthDyuTPyS5TF8OQdSBchCLZOwRuLJ+ZP67wg@mail.gmail.com>
On 30.05.2014 17:31, Spenser Gilliland wrote:
> Peter,
>
> On May 30, 2014 10:00 AM, "Peter K?mmel" <syntheticpp at gmx.net <mailto:syntheticpp@gmx.net>> wrote:
> >
> > Signed-off-by: Peter K?mmel <syntheticpp at gmx.net <mailto:syntheticpp@gmx.net>>
> > ---
> > package/ti-gfx/glesv2.pc | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/package/ti-gfx/glesv2.pc b/package/ti-gfx/glesv2.pc
> > index 4c70aec..c3846d0 100644
> > --- a/package/ti-gfx/glesv2.pc
> > +++ b/package/ti-gfx/glesv2.pc
> > @@ -8,4 +8,4 @@ Description: TI Graphics SDK implementation of OpenGL ESv2
> > Version: 1.9.2188537
> > Requires:
> > Libs: -L${libdir} -lGLESv2 -lGLES_CM -lsrv_um -lusc -lEGL -lIMGegl
> > -Cflags: -I${includedir}/GLES2
> > +Cflags: -I${includedir}/GLES2 -I${includedir}
> > --
> > 1.9.1
> >
> >
>
> Does this fix a package for you? The includedir var should be /usr/include which is a default include path.
Yes, Qt5's cmake files assume /usr/include not /usr/include/GLES2.
I added -I${includedir} instead of removing only "GLES2" because then nothing will break,
and the other .pc file also sets both dirs.
But it seems common practice is to not add the uppercase dir names in the pkg-congig file.
Peter
>
> Thanks,
> Spenser _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net <mailto:buildroot@busybox.net>
> > http://lists.busybox.net/mailman/listinfo/buildroot
>
next prev parent reply other threads:[~2014-05-30 15:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 15:00 [Buildroot] [PATCH 1/1] ti-gfx: pkg-config should also set parent include dir Peter Kümmel
2014-05-30 15:31 ` Spenser Gilliland
2014-05-30 15:55 ` Peter Kümmel [this message]
2014-05-30 19:57 ` Spenser Gilliland
2014-05-30 20:27 ` Thomas Petazzoni
2014-05-30 20:41 ` Peter Kümmel
2014-05-30 20:52 ` Peter Korsgaard
2014-05-30 21:29 ` Peter Kümmel
2014-05-30 21:41 ` Peter Korsgaard
2014-05-31 4:34 ` Peter Kümmel
2014-05-31 9:37 ` Yann E. MORIN
2014-05-31 9:39 ` Yann E. MORIN
2014-05-31 11:48 ` Peter Korsgaard
2014-05-30 20:57 ` Yann E. MORIN
2014-05-30 21:16 ` Peter Kümmel
2014-05-30 21:23 ` Yann E. MORIN
2014-05-30 21:39 ` Peter Kümmel
2014-05-30 21:42 ` Yann E. MORIN
2014-05-30 20:32 ` Peter Kümmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5388A9DC.1010204@gmx.net \
--to=syntheticpp@gmx.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox