From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] alsaequal: new package
Date: Wed, 6 Aug 2014 10:00:41 +0200 [thread overview]
Message-ID: <20140806100041.107a2524@free-electrons.com> (raw)
In-Reply-To: <53E1442A.9020302@barkynet.com>
Dear Martin Bark,
On Tue, 05 Aug 2014 21:52:58 +0100, Martin Bark wrote:
> > Description + Signed-off-by.
>
> Some of these patches are copies from debian patches hence they lack the
> description and Signed-off-by. I'll fix this and resubmit.
No problem with patches coming from Debian, but please indicate where
they are coming from.
> > Same comments here for $(TARGET_MAKE_ENV) and $(TARGET_CONFIGURE_OPTS)
> > as the ones made on the 'caps' package.
> >
> > So there's really no build dependency on ladspa or caps in alsaequal ?
>
> alsaequal loads the caps 10 band equaliser at runtime hence caps is not
> a build dependency but is a dependency in Config.in.
Ok. Maybe put a comment about this somewhere in the Config.in or .mk
file.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-08-06 8:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 21:19 [Buildroot] [PATCH 1/3] ladspa-sdk: new package Martin Bark
2014-04-24 21:19 ` [Buildroot] [PATCH 2/3] caps: " Martin Bark
2014-08-04 20:28 ` Thomas Petazzoni
2014-08-05 20:51 ` Martin Bark
2014-04-24 21:19 ` [Buildroot] [PATCH 3/3] alsaequal: " Martin Bark
2014-08-04 20:32 ` Thomas Petazzoni
2014-08-05 20:52 ` Martin Bark
2014-08-06 8:00 ` Thomas Petazzoni [this message]
2014-08-04 20:23 ` [Buildroot] [PATCH 1/3] ladspa-sdk: " Thomas Petazzoni
2014-08-05 20:50 ` Martin Bark
2014-08-06 7:59 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140806100041.107a2524@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox