Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] odhcploc: new package
@ 2014-08-09 18:06 Floris Bos
  2014-08-10  7:03 ` Thomas De Schampheleire
  2014-08-17 19:34 ` Thomas Petazzoni
  0 siblings, 2 replies; 5+ messages in thread
From: Floris Bos @ 2014-08-09 18:06 UTC (permalink / raw)
  To: buildroot

Adds odhcploc, a network utility to scan for (rogue) DHCP servers.

Signed-off-by: Floris Bos <bos@je-eigen-domein.nl>
---
 package/Config.in            |  1 +
 package/odhcploc/Config.in   |  8 ++++++++
 package/odhcploc/odhcploc.mk | 21 +++++++++++++++++++++
 3 files changed, 30 insertions(+)
 create mode 100644 package/odhcploc/Config.in
 create mode 100644 package/odhcploc/odhcploc.mk

diff --git a/package/Config.in b/package/Config.in
index 4520ba6..7bb8fc0 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1031,6 +1031,7 @@ endif
 	source "package/noip/Config.in"
 	source "package/ntp/Config.in"
 	source "package/nuttcp/Config.in"
+	source "package/odhcploc/Config.in"
 	source "package/olsr/Config.in"
 	source "package/openntpd/Config.in"
 	source "package/openobex/Config.in"
diff --git a/package/odhcploc/Config.in b/package/odhcploc/Config.in
new file mode 100644
index 0000000..74bf363
--- /dev/null
+++ b/package/odhcploc/Config.in
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_ODHCPLOC
+	bool "odhcploc"
+	help
+	  Open DHCP Locate (ODHCPLoc) is program to locate and
+	  display active DHCP servers on a subnet.
+	  Can be used to scan for rogue DHCP servers.
+
+	  http://odhcploc.sourceforge.net/
diff --git a/package/odhcploc/odhcploc.mk b/package/odhcploc/odhcploc.mk
new file mode 100644
index 0000000..d99247c
--- /dev/null
+++ b/package/odhcploc/odhcploc.mk
@@ -0,0 +1,21 @@
+################################################################################
+#
+# odhcploc
+#
+################################################################################
+
+ODHCPLOC_VERSION = 20111021
+ODHCPLOC_SOURCE = odhcploc-$(ODHCPLOC_VERSION).tar.gz
+ODHCPLOC_SITE = http://downloads.sourceforge.net/project/odhcploc/$(ODHCPLOC_VERSION)
+ODHCPLOC_LICENSE = ISC
+ODHCPLOC_LICENSE_FILES = COPYING
+
+define ODHCPLOC_BUILD_CMDS
+     $(MAKE) CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all
+endef
+
+define ODHCPLOC_INSTALL_TARGET_CMDS
+     $(INSTALL) -D -m 0755 $(@D)/odhcploc $(TARGET_DIR)/usr/bin/odhcploc
+endef
+
+$(eval $(generic-package))
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/1] odhcploc: new package
  2014-08-09 18:06 [Buildroot] [PATCH 1/1] odhcploc: new package Floris Bos
@ 2014-08-10  7:03 ` Thomas De Schampheleire
  2014-08-17 19:34 ` Thomas Petazzoni
  1 sibling, 0 replies; 5+ messages in thread
From: Thomas De Schampheleire @ 2014-08-10  7:03 UTC (permalink / raw)
  To: buildroot

Floris Bos <bos@je-eigen-domein.nl> schreef:
>Adds odhcploc, a network utility to scan for (rogue) DHCP servers.
>
>Signed-off-by: Floris Bos <bos@je-eigen-domein.nl>
>---
> package/Config.in            |  1 +
> package/odhcploc/Config.in   |  8 ++++++++
> package/odhcploc/odhcploc.mk | 21 +++++++++++++++++++++
> 3 files changed, 30 insertions(+)
> create mode 100644 package/odhcploc/Config.in
> create mode 100644 package/odhcploc/odhcploc.mk
>
>diff --git a/package/Config.in b/package/Config.in
>index 4520ba6..7bb8fc0 100644
>--- a/package/Config.in
>+++ b/package/Config.in
>@@ -1031,6 +1031,7 @@ endif
> 	source "package/noip/Config.in"
> 	source "package/ntp/Config.in"
> 	source "package/nuttcp/Config.in"
>+	source "package/odhcploc/Config.in"
> 	source "package/olsr/Config.in"
> 	source "package/openntpd/Config.in"
> 	source "package/openobex/Config.in"
>diff --git a/package/odhcploc/Config.in b/package/odhcploc/Config.in
>new file mode 100644
>index 0000000..74bf363
>--- /dev/null
>+++ b/package/odhcploc/Config.in
>@@ -0,0 +1,8 @@
>+config BR2_PACKAGE_ODHCPLOC
>+	bool "odhcploc"
>+	help
>+	  Open DHCP Locate (ODHCPLoc) is program to locate and
>+	  display active DHCP servers on a subnet.
>+	  Can be used to scan for rogue DHCP servers.
>+
>+	  http://odhcploc.sourceforge.net/
>diff --git a/package/odhcploc/odhcploc.mk b/package/odhcploc/odhcploc.mk
>new file mode 100644
>index 0000000..d99247c
>--- /dev/null
>+++ b/package/odhcploc/odhcploc.mk
>@@ -0,0 +1,21 @@
>+################################################################################
>+#
>+# odhcploc
>+#
>+################################################################################
>+
>+ODHCPLOC_VERSION = 20111021
>+ODHCPLOC_SOURCE = odhcploc-$(ODHCPLOC_VERSION).tar.gz

.tar.gz is the default, so this line can be removed.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/1] odhcploc: new package
  2014-08-09 18:06 [Buildroot] [PATCH 1/1] odhcploc: new package Floris Bos
  2014-08-10  7:03 ` Thomas De Schampheleire
@ 2014-08-17 19:34 ` Thomas Petazzoni
  2014-08-17 20:51   ` Floris Bos
  1 sibling, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2014-08-17 19:34 UTC (permalink / raw)
  To: buildroot

Dear Floris Bos,

On Sat,  9 Aug 2014 20:06:57 +0200, Floris Bos wrote:
> Adds odhcploc, a network utility to scan for (rogue) DHCP servers.
> 
> Signed-off-by: Floris Bos <bos@je-eigen-domein.nl>

Thanks, I've applied the patch to the next branch, after doing a few
changes, see below.

> +ODHCPLOC_VERSION = 20111021
> +ODHCPLOC_SOURCE = odhcploc-$(ODHCPLOC_VERSION).tar.gz

Line removed, after the suggestion from Thomas DS.

> +ODHCPLOC_SITE = http://downloads.sourceforge.net/project/odhcploc/$(ODHCPLOC_VERSION)
> +ODHCPLOC_LICENSE = ISC
> +ODHCPLOC_LICENSE_FILES = COPYING
> +
> +define ODHCPLOC_BUILD_CMDS
> +     $(MAKE) CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all

Used tab for indentation instead of spaces, and replaced CC=.. LD=.. by
$(TARGET_CONFIGURE_OPTS).

> +define ODHCPLOC_INSTALL_TARGET_CMDS
> +     $(INSTALL) -D -m 0755 $(@D)/odhcploc $(TARGET_DIR)/usr/bin/odhcploc

Used 'make install' instead of manually doing the installation.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/1] odhcploc: new package
  2014-08-17 19:34 ` Thomas Petazzoni
@ 2014-08-17 20:51   ` Floris Bos
  2014-08-18  7:46     ` Thomas Petazzoni
  0 siblings, 1 reply; 5+ messages in thread
From: Floris Bos @ 2014-08-17 20:51 UTC (permalink / raw)
  To: buildroot

On 08/17/2014 09:34 PM, Thomas Petazzoni wrote:
> On Sat,  9 Aug 2014 20:06:57 +0200, Floris Bos wrote:
>> Adds odhcploc, a network utility to scan for (rogue) DHCP servers.
>>
>> Signed-off-by: Floris Bos <bos@je-eigen-domein.nl>
> Thanks, I've applied the patch to the next branch, after doing a few
> changes, see below.

Thanks for applying.


> +define ODHCPLOC_BUILD_CMDS
> +     $(MAKE) CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all
> Used tab for indentation instead of spaces, and replaced CC=.. LD=.. by
> $(TARGET_CONFIGURE_OPTS).

Fine with me.
Had copied the CC=.. LD=.. construct from the manual though ( 
http://www.buildroot.org/downloads/manual/manual.html#_infrastructure_for_packages_with_specific_build_systems 
)
Perhaps mention $(TARGET_CONFIGURE_OPTS) there as well?

-- 
Yours sincerely,

Floris Bos

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/1] odhcploc: new package
  2014-08-17 20:51   ` Floris Bos
@ 2014-08-18  7:46     ` Thomas Petazzoni
  0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2014-08-18  7:46 UTC (permalink / raw)
  To: buildroot

Dear Floris Bos,

On Sun, 17 Aug 2014 22:51:14 +0200, Floris Bos wrote:

> > +define ODHCPLOC_BUILD_CMDS
> > +     $(MAKE) CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all
> > Used tab for indentation instead of spaces, and replaced CC=.. LD=.. by
> > $(TARGET_CONFIGURE_OPTS).
> 
> Fine with me.
> Had copied the CC=.. LD=.. construct from the manual though ( 
> http://www.buildroot.org/downloads/manual/manual.html#_infrastructure_for_packages_with_specific_build_systems 
> )
> Perhaps mention $(TARGET_CONFIGURE_OPTS) there as well?

Ah, yes, indeed. Care to send a patch ? :-)

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2014-08-18  7:46 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-09 18:06 [Buildroot] [PATCH 1/1] odhcploc: new package Floris Bos
2014-08-10  7:03 ` Thomas De Schampheleire
2014-08-17 19:34 ` Thomas Petazzoni
2014-08-17 20:51   ` Floris Bos
2014-08-18  7:46     ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox