* [Buildroot] [PATCH] package: libarchive: allow building as host package
@ 2014-09-26 23:23 Guido Martínez
2014-09-27 8:54 ` Yann E. MORIN
2014-10-11 17:27 ` Thomas Petazzoni
0 siblings, 2 replies; 6+ messages in thread
From: Guido Martínez @ 2014-09-26 23:23 UTC (permalink / raw)
To: buildroot
It works correctly without any changes, so just enable it.
Signed-off-by: Guido Mart?nez <guido@vanguardiasur.com.ar>
---
package/libarchive/libarchive.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/libarchive/libarchive.mk b/package/libarchive/libarchive.mk
index 8c6951d..22914c2 100644
--- a/package/libarchive/libarchive.mk
+++ b/package/libarchive/libarchive.mk
@@ -69,3 +69,4 @@ LIBARCHIVE_CONF_OPT += --without-zlib
endif
$(eval $(autotools-package))
+$(eval $(host-autotools-package))
--
2.1.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package: libarchive: allow building as host package
2014-09-26 23:23 [Buildroot] [PATCH] package: libarchive: allow building as host package Guido Martínez
@ 2014-09-27 8:54 ` Yann E. MORIN
2014-09-27 12:28 ` Guido Martínez
2014-09-28 9:04 ` Samuel Martin
2014-10-11 17:27 ` Thomas Petazzoni
1 sibling, 2 replies; 6+ messages in thread
From: Yann E. MORIN @ 2014-09-27 8:54 UTC (permalink / raw)
To: buildroot
Guido, All,
What is the rationale for building it as a host-package?
libarchive provides a library, but we have no in-tree host-package that
uses libarchive.
On 2014-09-26 20:23 -0300, Guido Mart?nez spake thusly:
> It works correctly without any changes, so just enable it.
This should not be part of the commit log. The commit log should just
explain why you enable host-libarchive, especially because we have no
in-tree user.
Regards,
Yann E. MORIN.
> Signed-off-by: Guido Mart?nez <guido@vanguardiasur.com.ar>
> ---
> package/libarchive/libarchive.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/libarchive/libarchive.mk b/package/libarchive/libarchive.mk
> index 8c6951d..22914c2 100644
> --- a/package/libarchive/libarchive.mk
> +++ b/package/libarchive/libarchive.mk
> @@ -69,3 +69,4 @@ LIBARCHIVE_CONF_OPT += --without-zlib
> endif
>
> $(eval $(autotools-package))
> +$(eval $(host-autotools-package))
> --
> 2.1.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package: libarchive: allow building as host package
2014-09-27 8:54 ` Yann E. MORIN
@ 2014-09-27 12:28 ` Guido Martínez
2014-09-27 12:37 ` Yann E. MORIN
2014-09-28 9:04 ` Samuel Martin
1 sibling, 1 reply; 6+ messages in thread
From: Guido Martínez @ 2014-09-27 12:28 UTC (permalink / raw)
To: buildroot
Hi Yann,
On Sat, Sep 27, 2014 at 10:54:44AM +0200, Yann E. MORIN wrote:
> Guido, All,
>
> What is the rationale for building it as a host-package?
>
> libarchive provides a library, but we have no in-tree host-package that
> uses libarchive.
I have a custom tool that uses it, and I wasn't aware that host packages
were only enabled as needed. It makes a lot sense now that I think about
that, so please ignore this patch.
Sorry!
>
> On 2014-09-26 20:23 -0300, Guido Mart?nez spake thusly:
> > It works correctly without any changes, so just enable it.
>
> This should not be part of the commit log. The commit log should just
> explain why you enable host-libarchive, especially because we have no
> in-tree user.
>
> Regards,
> Yann E. MORIN.
>
> > Signed-off-by: Guido Mart?nez <guido@vanguardiasur.com.ar>
> > ---
> > package/libarchive/libarchive.mk | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/package/libarchive/libarchive.mk b/package/libarchive/libarchive.mk
> > index 8c6951d..22914c2 100644
> > --- a/package/libarchive/libarchive.mk
> > +++ b/package/libarchive/libarchive.mk
> > @@ -69,3 +69,4 @@ LIBARCHIVE_CONF_OPT += --without-zlib
> > endif
> >
> > $(eval $(autotools-package))
> > +$(eval $(host-autotools-package))
> > --
> > 2.1.0
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
>
> --
> .-----------------.--------------------.------------------.--------------------.
> | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
> | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
> '------------------------------^-------^------------------^--------------------'
--
Guido Mart?nez, VanguardiaSur
www.vanguardiasur.com.ar
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package: libarchive: allow building as host package
2014-09-27 12:28 ` Guido Martínez
@ 2014-09-27 12:37 ` Yann E. MORIN
0 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2014-09-27 12:37 UTC (permalink / raw)
To: buildroot
Guido, All,
On 2014-09-27 09:28 -0300, Guido Mart?nez spake thusly:
> On Sat, Sep 27, 2014 at 10:54:44AM +0200, Yann E. MORIN wrote:
> > Guido, All,
> >
> > What is the rationale for building it as a host-package?
> >
> > libarchive provides a library, but we have no in-tree host-package that
> > uses libarchive.
> I have a custom tool that uses it, and I wasn't aware that host packages
> were only enabled as needed. It makes a lot sense now that I think about
> that, so please ignore this patch.
For the records, repeating here what I said on IRC:
I never said we do not want it, just that you have to justify it. We
tend to be conservative about adding host-packages, and only add
programs, and libraries those programs need. Adding a host library that
has no in-tree user should thus be realy justified.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package: libarchive: allow building as host package
2014-09-27 8:54 ` Yann E. MORIN
2014-09-27 12:28 ` Guido Martínez
@ 2014-09-28 9:04 ` Samuel Martin
1 sibling, 0 replies; 6+ messages in thread
From: Samuel Martin @ 2014-09-28 9:04 UTC (permalink / raw)
To: buildroot
Hi Yann, all,
On Sat, Sep 27, 2014 at 10:54 AM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> Guido, All,
>
> What is the rationale for building it as a host-package?
>
> libarchive provides a library, but we have no in-tree host-package that
> uses libarchive.
That's right and wrong at the same time! ;-)
There is at least 1 host package that can depend (among other things)
on libarchive: cmake.
But it seems that for this we currently rely on the host-system
libarchive or the one coming within the cmake sources.
My 2 cents. :-)
Regards,
--
Samuel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package: libarchive: allow building as host package
2014-09-26 23:23 [Buildroot] [PATCH] package: libarchive: allow building as host package Guido Martínez
2014-09-27 8:54 ` Yann E. MORIN
@ 2014-10-11 17:27 ` Thomas Petazzoni
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2014-10-11 17:27 UTC (permalink / raw)
To: buildroot
Dear Guido Mart?nez,
On Fri, 26 Sep 2014 20:23:15 -0300, Guido Mart?nez wrote:
> It works correctly without any changes, so just enable it.
>
> Signed-off-by: Guido Mart?nez <guido@vanguardiasur.com.ar>
> ---
> package/libarchive/libarchive.mk | 1 +
> 1 file changed, 1 insertion(+)
As was explained during the review, since there is no in-tree user for
this host package, we rejected the patch. If another package needs it
some day, then of course we'll accept such a patch.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-10-11 17:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-26 23:23 [Buildroot] [PATCH] package: libarchive: allow building as host package Guido Martínez
2014-09-27 8:54 ` Yann E. MORIN
2014-09-27 12:28 ` Guido Martínez
2014-09-27 12:37 ` Yann E. MORIN
2014-09-28 9:04 ` Samuel Martin
2014-10-11 17:27 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox