* [Buildroot] [PATCH 0/2] infra: BR2_PREFER_STATIC_LIB now selects static building of packages
@ 2014-10-12 16:34 Alexey Brodkin
2014-10-12 16:34 ` [Buildroot] [PATCH 1/2] Config.in: update description of BR2_PREFER_STATIC_LIB Alexey Brodkin
2014-10-12 16:34 ` [Buildroot] [PATCH 2/2] uclibc: explicitly set HAVE_SHARED depending on BR2_PREFER_STATIC_LIB Alexey Brodkin
0 siblings, 2 replies; 7+ messages in thread
From: Alexey Brodkin @ 2014-10-12 16:34 UTC (permalink / raw)
To: buildroot
This patch series corrects description of BR2_PREFER_STATIC_LIB so it matches
currenlty implemented ("do not build dynamic libs and build statically linked
applications") and also takes care of uClibc so it doesn't have built-in support
of shared libraries as well as no shared versions of libc libs are built.
Alexey Brodkin (2):
Config.in: update description of BR2_PREFER_STATIC_LIB
uclibc: explicitly set HAVE_SHARED depending on BR2_PREFER_STATIC_LIB
Config.in | 15 +++++++++------
package/uclibc/uClibc-0.9.31.config | 1 -
package/uclibc/uClibc-0.9.33.config | 1 -
package/uclibc/uClibc-snapshot.config | 1 -
package/uclibc/uclibc.mk | 11 +++++++++++
5 files changed, 20 insertions(+), 9 deletions(-)
--
1.9.3
^ permalink raw reply [flat|nested] 7+ messages in thread* [Buildroot] [PATCH 1/2] Config.in: update description of BR2_PREFER_STATIC_LIB 2014-10-12 16:34 [Buildroot] [PATCH 0/2] infra: BR2_PREFER_STATIC_LIB now selects static building of packages Alexey Brodkin @ 2014-10-12 16:34 ` Alexey Brodkin 2014-10-12 16:51 ` Thomas Petazzoni 2014-10-12 22:17 ` Peter Korsgaard 2014-10-12 16:34 ` [Buildroot] [PATCH 2/2] uclibc: explicitly set HAVE_SHARED depending on BR2_PREFER_STATIC_LIB Alexey Brodkin 1 sibling, 2 replies; 7+ messages in thread From: Alexey Brodkin @ 2014-10-12 16:34 UTC (permalink / raw) To: buildroot With time BR2_PREFER_STATIC_LIB option meaning changed from "prefer static libs when possible" to "do not build dynamic libs and build statically linked applications". This patch changes variable description. Note that variable name is kept unchanged on purpose - it will be modified later when real "prefer static" mode will be introduced. Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar> Cc: Peter Korsgaard <peter@korsgaard.com> --- Config.in | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/Config.in b/Config.in index 24aa883..66cea4a 100644 --- a/Config.in +++ b/Config.in @@ -536,15 +536,18 @@ comment "enabling Stack Smashing Protection requires support in the toolchain" depends on !BR2_TOOLCHAIN_HAS_SSP config BR2_PREFER_STATIC_LIB - bool "prefer static libraries" + bool "build statically linked applications, no dynamic libraries" help - Where possible, build and use static libraries for the target. - This potentially increases your code size and should only be + Build all application for the target statically linked. + This potentially increases your filesystem size and should only be used if you know what you do. - The default is to build dynamic libraries and use those on - the target filesystem. - WARNING: This is highly experimental at the moment. + Note that some applications cannot be build statically and so are + intentionally disabled. + + The default is to build dynamic libraries and dynamically linked + applications to use those on the target filesystem. + config BR2_PACKAGE_OVERRIDE_FILE string "location of a package override file" -- 1.9.3 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/2] Config.in: update description of BR2_PREFER_STATIC_LIB 2014-10-12 16:34 ` [Buildroot] [PATCH 1/2] Config.in: update description of BR2_PREFER_STATIC_LIB Alexey Brodkin @ 2014-10-12 16:51 ` Thomas Petazzoni 2014-10-12 17:22 ` Yann E. MORIN 2014-10-12 22:17 ` Peter Korsgaard 1 sibling, 1 reply; 7+ messages in thread From: Thomas Petazzoni @ 2014-10-12 16:51 UTC (permalink / raw) To: buildroot Dear Alexey Brodkin, On Sun, 12 Oct 2014 18:34:44 +0200, Alexey Brodkin wrote: > diff --git a/Config.in b/Config.in > index 24aa883..66cea4a 100644 > --- a/Config.in > +++ b/Config.in > @@ -536,15 +536,18 @@ comment "enabling Stack Smashing Protection requires support in the toolchain" > depends on !BR2_TOOLCHAIN_HAS_SSP > > config BR2_PREFER_STATIC_LIB > - bool "prefer static libraries" > + bool "build statically linked applications, no dynamic libraries" > help > - Where possible, build and use static libraries for the target. > - This potentially increases your code size and should only be > + Build all application for the target statically linked. > + This potentially increases your filesystem size and should only be > used if you know what you do. > - The default is to build dynamic libraries and use those on > - the target filesystem. > > - WARNING: This is highly experimental at the moment. > + Note that some applications cannot be build statically and so are > + intentionally disabled. > + > + The default is to build dynamic libraries and dynamically linked > + applications to use those on the target filesystem. "The default" should be clarified as "When this option is disabled". Also linked -> link. With this fixed (probably Peter can fix this when applying): Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/2] Config.in: update description of BR2_PREFER_STATIC_LIB 2014-10-12 16:51 ` Thomas Petazzoni @ 2014-10-12 17:22 ` Yann E. MORIN 0 siblings, 0 replies; 7+ messages in thread From: Yann E. MORIN @ 2014-10-12 17:22 UTC (permalink / raw) To: buildroot Alexey, All, On 2014-10-12 18:51 +0200, Thomas Petazzoni spake thusly: > Dear Alexey Brodkin, > > On Sun, 12 Oct 2014 18:34:44 +0200, Alexey Brodkin wrote: > > > diff --git a/Config.in b/Config.in > > index 24aa883..66cea4a 100644 > > --- a/Config.in > > +++ b/Config.in > > @@ -536,15 +536,18 @@ comment "enabling Stack Smashing Protection requires support in the toolchain" > > depends on !BR2_TOOLCHAIN_HAS_SSP > > > > config BR2_PREFER_STATIC_LIB > > - bool "prefer static libraries" > > + bool "build statically linked applications, no dynamic libraries" > > help > > - Where possible, build and use static libraries for the target. > > - This potentially increases your code size and should only be > > + Build all application for the target statically linked. ... all application_s_ ... Regards, Yann E. MORIN. > > + This potentially increases your filesystem size and should only be > > used if you know what you do. > > - The default is to build dynamic libraries and use those on > > - the target filesystem. > > > > - WARNING: This is highly experimental at the moment. > > + Note that some applications cannot be build statically and so are > > + intentionally disabled. > > + > > + The default is to build dynamic libraries and dynamically linked > > + applications to use those on the target filesystem. > > "The default" should be clarified as "When this option is disabled". > > Also linked -> link. > > With this fixed (probably Peter can fix this when applying): > > Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/2] Config.in: update description of BR2_PREFER_STATIC_LIB 2014-10-12 16:34 ` [Buildroot] [PATCH 1/2] Config.in: update description of BR2_PREFER_STATIC_LIB Alexey Brodkin 2014-10-12 16:51 ` Thomas Petazzoni @ 2014-10-12 22:17 ` Peter Korsgaard 1 sibling, 0 replies; 7+ messages in thread From: Peter Korsgaard @ 2014-10-12 22:17 UTC (permalink / raw) To: buildroot >>>>> "Alexey" == Alexey Brodkin <alexey.brodkin@gmail.com> writes: > With time BR2_PREFER_STATIC_LIB option meaning changed from "prefer static > libs when possible" to "do not build dynamic libs and build statically linked > applications". > This patch changes variable description. > Note that variable name is kept unchanged on purpose - it will be modified later > when real "prefer static" mode will be introduced. > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > Cc: Gustavo Zacarias <gustavo@zacarias.com.ar> > Cc: Peter Korsgaard <peter@korsgaard.com> Committed with the minor text tweaks suggested fixed, thanks. -- Venlig hilsen, Peter Korsgaard ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 2/2] uclibc: explicitly set HAVE_SHARED depending on BR2_PREFER_STATIC_LIB 2014-10-12 16:34 [Buildroot] [PATCH 0/2] infra: BR2_PREFER_STATIC_LIB now selects static building of packages Alexey Brodkin 2014-10-12 16:34 ` [Buildroot] [PATCH 1/2] Config.in: update description of BR2_PREFER_STATIC_LIB Alexey Brodkin @ 2014-10-12 16:34 ` Alexey Brodkin 2014-10-12 16:52 ` Thomas Petazzoni 1 sibling, 1 reply; 7+ messages in thread From: Alexey Brodkin @ 2014-10-12 16:34 UTC (permalink / raw) To: buildroot Now with change of BR2_PREFER_STATIC_LIB meaning to "do not build dynamic libs and build statically linked applications" it's possible to disable support of shared libs in uClibc as well as builting of shared libc libs. Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar> Cc: Peter Korsgaard <peter@korsgaard.com> --- package/uclibc/uClibc-0.9.31.config | 1 - package/uclibc/uClibc-0.9.33.config | 1 - package/uclibc/uClibc-snapshot.config | 1 - package/uclibc/uclibc.mk | 11 +++++++++++ 4 files changed, 11 insertions(+), 3 deletions(-) diff --git a/package/uclibc/uClibc-0.9.31.config b/package/uclibc/uClibc-0.9.31.config index e990178..90346fb 100644 --- a/package/uclibc/uClibc-0.9.31.config +++ b/package/uclibc/uClibc-0.9.31.config @@ -61,7 +61,6 @@ HAVE_DOT_CONFIG=y DOPIC=y # ARCH_HAS_NO_SHARED is not set # ARCH_HAS_NO_LDSO is not set -HAVE_SHARED=y # FORCE_SHAREABLE_TEXT_SEGMENTS is not set LDSO_LDD_SUPPORT=y # LDSO_CACHE_SUPPORT is not set diff --git a/package/uclibc/uClibc-0.9.33.config b/package/uclibc/uClibc-0.9.33.config index eb39df6..a32f886 100644 --- a/package/uclibc/uClibc-0.9.33.config +++ b/package/uclibc/uClibc-0.9.33.config @@ -83,7 +83,6 @@ HAVE_DOT_CONFIG=y DOPIC=y # ARCH_HAS_NO_SHARED is not set # ARCH_HAS_NO_LDSO is not set -HAVE_SHARED=y # FORCE_SHAREABLE_TEXT_SEGMENTS is not set LDSO_LDD_SUPPORT=y # LDSO_CACHE_SUPPORT is not set diff --git a/package/uclibc/uClibc-snapshot.config b/package/uclibc/uClibc-snapshot.config index 890aefd..ce10bb5 100644 --- a/package/uclibc/uClibc-snapshot.config +++ b/package/uclibc/uClibc-snapshot.config @@ -85,7 +85,6 @@ HAVE_DOT_CONFIG=y DOPIC=y # ARCH_HAS_NO_SHARED is not set # ARCH_HAS_NO_LDSO is not set -HAVE_SHARED=y # FORCE_SHAREABLE_TEXT_SEGMENTS is not set LDSO_LDD_SUPPORT=y # LDSO_CACHE_SUPPORT is not set diff --git a/package/uclibc/uclibc.mk b/package/uclibc/uclibc.mk index 1469f8d..a400dab 100644 --- a/package/uclibc/uclibc.mk +++ b/package/uclibc/uclibc.mk @@ -392,6 +392,16 @@ UCLIBC_STRIP_CONFIG = $(call KCONFIG_ENABLE_OPT,DOSTRIP,$(@D)/.config) endif # +# static/shared libs +# + +ifeq ($(BR2_PREFER_STATIC_LIB),y) +UCLIBC_SHARED_LIBS_CONFIG = $(call KCONFIG_DISABLE_OPT,HAVE_SHARED,$(@D)/.config) +else +UCLIBC_SHARED_LIBS_CONFIG = $(call KCONFIG_ENABLE_OPT,HAVE_SHARED,$(@D)/.config) +endif + +# # Commands # @@ -431,6 +441,7 @@ define UCLIBC_KCONFIG_FIXUP_CMDS $(UCLIBC_LOCALE_CONFIG) $(UCLIBC_WCHAR_CONFIG) $(UCLIBC_STRIP_CONFIG) + $(UCLIBC_SHARED_LIBS_CONFIG) endef ifeq ($(BR2_UCLIBC_INSTALL_TEST_SUITE),y) -- 1.9.3 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 2/2] uclibc: explicitly set HAVE_SHARED depending on BR2_PREFER_STATIC_LIB 2014-10-12 16:34 ` [Buildroot] [PATCH 2/2] uclibc: explicitly set HAVE_SHARED depending on BR2_PREFER_STATIC_LIB Alexey Brodkin @ 2014-10-12 16:52 ` Thomas Petazzoni 0 siblings, 0 replies; 7+ messages in thread From: Thomas Petazzoni @ 2014-10-12 16:52 UTC (permalink / raw) To: buildroot Dear Alexey Brodkin, On Sun, 12 Oct 2014 18:34:45 +0200, Alexey Brodkin wrote: > Now with change of BR2_PREFER_STATIC_LIB meaning to "do not build dynamic libs > and build statically linked applications" it's possible to disable support of > shared libs in uClibc as well as builting of shared libc libs. > > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> > > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > Cc: Gustavo Zacarias <gustavo@zacarias.com.ar> > Cc: Peter Korsgaard <peter@korsgaard.com> > --- > package/uclibc/uClibc-0.9.31.config | 1 - > package/uclibc/uClibc-0.9.33.config | 1 - > package/uclibc/uClibc-snapshot.config | 1 - > package/uclibc/uclibc.mk | 11 +++++++++++ > 4 files changed, 11 insertions(+), 3 deletions(-) Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-10-12 22:17 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-10-12 16:34 [Buildroot] [PATCH 0/2] infra: BR2_PREFER_STATIC_LIB now selects static building of packages Alexey Brodkin 2014-10-12 16:34 ` [Buildroot] [PATCH 1/2] Config.in: update description of BR2_PREFER_STATIC_LIB Alexey Brodkin 2014-10-12 16:51 ` Thomas Petazzoni 2014-10-12 17:22 ` Yann E. MORIN 2014-10-12 22:17 ` Peter Korsgaard 2014-10-12 16:34 ` [Buildroot] [PATCH 2/2] uclibc: explicitly set HAVE_SHARED depending on BR2_PREFER_STATIC_LIB Alexey Brodkin 2014-10-12 16:52 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox