* [Buildroot] [PATCH 1/2] package/nginx: disallow AIO support on arc
@ 2014-12-06 13:15 Samuel Martin
2014-12-06 13:15 ` [Buildroot] [PATCH 2/2] package/libnss: need dynamic library support Samuel Martin
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Samuel Martin @ 2014-12-06 13:15 UTC (permalink / raw)
To: buildroot
The nginx AIO support cannot build on arc, because it hardcodes
the usage of SYS_eventfd(), while it should just use eventfd() from
the C library.
Fixes:
http://autobuild.buildroot.org/results/f3e/f3e2c7a937517a5444f8c6cc0b02692af897b3e0/
Signed-off-by: Samuel Martin <s.martin49@gmail.com>
---
package/nginx/Config.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/nginx/Config.in b/package/nginx/Config.in
index c2a6af1..5b5c0b0 100644
--- a/package/nginx/Config.in
+++ b/package/nginx/Config.in
@@ -17,9 +17,10 @@ if BR2_PACKAGE_NGINX
config BR2_PACKAGE_NGINX_FILE_AIO
bool "file AIO support"
# Does not build, because nginx hardcodes using SYS_eventfd,
- # but it's not available on AArch64, only eventfd() is.
+ # but it's not available on AArch64, nor arc only eventfd() is.
# See https://bugs.launchpad.net/linaro-aarch64/+bug/1160013
depends on !BR2_aarch64
+ depends on !BR2_arc
config BR2_PACKAGE_NGINX_HTTP
bool "http server"
--
2.1.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Buildroot] [PATCH 2/2] package/libnss: need dynamic library support
2014-12-06 13:15 [Buildroot] [PATCH 1/2] package/nginx: disallow AIO support on arc Samuel Martin
@ 2014-12-06 13:15 ` Samuel Martin
2014-12-06 15:19 ` Thomas Petazzoni
2014-12-07 20:24 ` [Buildroot] [PATCH 1/2] package/nginx: disallow AIO support on arc Yann E. MORIN
2014-12-07 20:28 ` Thomas Petazzoni
2 siblings, 1 reply; 6+ messages in thread
From: Samuel Martin @ 2014-12-06 13:15 UTC (permalink / raw)
To: buildroot
Fixes:
http://autobuild.buildroot.net/results/e01733c4b8c23f62e2081f0c4aadc16e22c4a2c4/
Signed-off-by: Samuel Martin <s.martin49@gmail.com>
---
package/libnss/Config.in | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/package/libnss/Config.in b/package/libnss/Config.in
index 690f928..d57c7a2 100644
--- a/package/libnss/Config.in
+++ b/package/libnss/Config.in
@@ -6,6 +6,7 @@ config BR2_PACKAGE_LIBNSS
depends on BR2_LARGEFILE
depends on BR2_TOOLCHAIN_HAS_THREADS # libnspr
depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT # libnspr
+ depends on !BR2_PREFER_STATIC_LIB
help
Network Security Services (NSS) is a set of libraries designed
to support development of security-enabled client and server
@@ -15,6 +16,7 @@ config BR2_PACKAGE_LIBNSS
http://www.mozilla.org/projects/security/pki/nss/
-comment "libnss needs a toolchain w/ largefile, threads"
+comment "libnss needs a toolchain w/ largefile, threads, dynamic librairy"
depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT
- depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS
+ depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS \
+ BR2_PREFER_STATIC_LIB
--
2.1.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/2] package/libnss: need dynamic library support
2014-12-06 13:15 ` [Buildroot] [PATCH 2/2] package/libnss: need dynamic library support Samuel Martin
@ 2014-12-06 15:19 ` Thomas Petazzoni
2014-12-06 15:24 ` Samuel Martin
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2014-12-06 15:19 UTC (permalink / raw)
To: buildroot
Dear Samuel Martin,
On Sat, 6 Dec 2014 14:15:38 +0100, Samuel Martin wrote:
> Fixes:
> http://autobuild.buildroot.net/results/e01733c4b8c23f62e2081f0c4aadc16e22c4a2c4/
>
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> ---
> package/libnss/Config.in | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/package/libnss/Config.in b/package/libnss/Config.in
> index 690f928..d57c7a2 100644
> --- a/package/libnss/Config.in
> +++ b/package/libnss/Config.in
> @@ -6,6 +6,7 @@ config BR2_PACKAGE_LIBNSS
> depends on BR2_LARGEFILE
> depends on BR2_TOOLCHAIN_HAS_THREADS # libnspr
> depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT # libnspr
> + depends on !BR2_PREFER_STATIC_LIB
What about the reverse dependencies, such as ecryptfs-utils?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/2] package/libnss: need dynamic library support
2014-12-06 15:19 ` Thomas Petazzoni
@ 2014-12-06 15:24 ` Samuel Martin
0 siblings, 0 replies; 6+ messages in thread
From: Samuel Martin @ 2014-12-06 15:24 UTC (permalink / raw)
To: buildroot
On Sat, Dec 6, 2014 at 4:19 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Samuel Martin,
>
> On Sat, 6 Dec 2014 14:15:38 +0100, Samuel Martin wrote:
>> Fixes:
>> http://autobuild.buildroot.net/results/e01733c4b8c23f62e2081f0c4aadc16e22c4a2c4/
>>
>> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
>> ---
>> package/libnss/Config.in | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/package/libnss/Config.in b/package/libnss/Config.in
>> index 690f928..d57c7a2 100644
>> --- a/package/libnss/Config.in
>> +++ b/package/libnss/Config.in
>> @@ -6,6 +6,7 @@ config BR2_PACKAGE_LIBNSS
>> depends on BR2_LARGEFILE
>> depends on BR2_TOOLCHAIN_HAS_THREADS # libnspr
>> depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT # libnspr
>> + depends on !BR2_PREFER_STATIC_LIB
>
> What about the reverse dependencies, such as ecryptfs-utils?
oops! I missed that. I'll respin the patch
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
--
Samuel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/2] package/nginx: disallow AIO support on arc
2014-12-06 13:15 [Buildroot] [PATCH 1/2] package/nginx: disallow AIO support on arc Samuel Martin
2014-12-06 13:15 ` [Buildroot] [PATCH 2/2] package/libnss: need dynamic library support Samuel Martin
@ 2014-12-07 20:24 ` Yann E. MORIN
2014-12-07 20:28 ` Thomas Petazzoni
2 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2014-12-07 20:24 UTC (permalink / raw)
To: buildroot
Samuel, All,
On 2014-12-06 14:15 +0100, Samuel Martin spake thusly:
> The nginx AIO support cannot build on arc, because it hardcodes
> the usage of SYS_eventfd(), while it should just use eventfd() from
> the C library.
>
> Fixes:
> http://autobuild.buildroot.org/results/f3e/f3e2c7a937517a5444f8c6cc0b02692af897b3e0/
>
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> ---
> package/nginx/Config.in | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/package/nginx/Config.in b/package/nginx/Config.in
> index c2a6af1..5b5c0b0 100644
> --- a/package/nginx/Config.in
> +++ b/package/nginx/Config.in
> @@ -17,9 +17,10 @@ if BR2_PACKAGE_NGINX
> config BR2_PACKAGE_NGINX_FILE_AIO
> bool "file AIO support"
> # Does not build, because nginx hardcodes using SYS_eventfd,
> - # but it's not available on AArch64, only eventfd() is.
> + # but it's not available on AArch64, nor arc only eventfd() is.
but it's available on neither AArch64 nor arc, where only eventfd() is.
Otherwise, looks good:
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> # See https://bugs.launchpad.net/linaro-aarch64/+bug/1160013
> depends on !BR2_aarch64
> + depends on !BR2_arc
>
> config BR2_PACKAGE_NGINX_HTTP
> bool "http server"
> --
> 2.1.3
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/2] package/nginx: disallow AIO support on arc
2014-12-06 13:15 [Buildroot] [PATCH 1/2] package/nginx: disallow AIO support on arc Samuel Martin
2014-12-06 13:15 ` [Buildroot] [PATCH 2/2] package/libnss: need dynamic library support Samuel Martin
2014-12-07 20:24 ` [Buildroot] [PATCH 1/2] package/nginx: disallow AIO support on arc Yann E. MORIN
@ 2014-12-07 20:28 ` Thomas Petazzoni
2 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2014-12-07 20:28 UTC (permalink / raw)
To: buildroot
Dear Samuel Martin,
On Sat, 6 Dec 2014 14:15:37 +0100, Samuel Martin wrote:
> The nginx AIO support cannot build on arc, because it hardcodes
> the usage of SYS_eventfd(), while it should just use eventfd() from
> the C library.
>
> Fixes:
> http://autobuild.buildroot.org/results/f3e/f3e2c7a937517a5444f8c6cc0b02692af897b3e0/
>
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> ---
> package/nginx/Config.in | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Thanks, applied after slightly tweaking the comment as suggested by
Yann.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-12-07 20:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-06 13:15 [Buildroot] [PATCH 1/2] package/nginx: disallow AIO support on arc Samuel Martin
2014-12-06 13:15 ` [Buildroot] [PATCH 2/2] package/libnss: need dynamic library support Samuel Martin
2014-12-06 15:19 ` Thomas Petazzoni
2014-12-06 15:24 ` Samuel Martin
2014-12-07 20:24 ` [Buildroot] [PATCH 1/2] package/nginx: disallow AIO support on arc Yann E. MORIN
2014-12-07 20:28 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox