[Buildroot] [PATCH] perl: needs host-bison

[Buildroot] [PATCH] perl: needs host-bison

[Gustavo Zacarias]

It's from last bump, fixes:
http://autobuild.buildroot.net/results/1c2/1c261b09f5a4a314d5dcbc1e5811af9c7d18658a/

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 package/perl/perl.mk | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/package/perl/perl.mk b/package/perl/perl.mk
index 0636aba..81e6275 100644
--- a/package/perl/perl.mk
+++ b/package/perl/perl.mk
@@ -8,6 +8,7 @@ PERL_VERSION_MAJOR = 20
 PERL_VERSION = 5.$(PERL_VERSION_MAJOR).2
 PERL_SITE = http://www.cpan.org/src/5.0
 PERL_SOURCE = perl-$(PERL_VERSION).tar.bz2
+PERL_DEPENDENCIES = host-bison
 PERL_LICENSE = Artistic or GPLv1+
 PERL_LICENSE_FILES = Artistic Copying README
 PERL_INSTALL_STAGING = YES
@@ -88,7 +89,7 @@ define PERL_CONFIGURE_CMDS
 endef
 
 define PERL_BUILD_CMDS
-	$(MAKE1) -C $(@D) all
+	PATH=$(BR_PATH) $(MAKE1) -C $(@D) all
 endef
 
 define PERL_INSTALL_STAGING_CMDS
@@ -101,7 +102,7 @@ endef
 
 # We never want to have host-berkeleydb or host-gdbm as dependencies
 # of host-perl.
-HOST_PERL_DEPENDENCIES =
+HOST_PERL_DEPENDENCIES = host-bison
 
 HOST_PERL_CONF_OPTS = \
 	-des \
@@ -113,7 +114,7 @@ define HOST_PERL_CONFIGURE_CMDS
 endef
 
 define HOST_PERL_BUILD_CMDS
-	$(MAKE) -C $(@D)
+	PATH=$(BR_PATH) $(MAKE) -C $(@D)
 endef
 
 define HOST_PERL_INSTALL_CMDS
-- 
2.0.5

[Buildroot] [PATCH] perl: needs host-bison

[Thomas Petazzoni]

Dear Gustavo Zacarias,

On Tue,  3 Mar 2015 07:31:03 -0300, Gustavo Zacarias wrote:

>  define PERL_BUILD_CMDS
> -	$(MAKE1) -C $(@D) all
> +	PATH=$(BR_PATH) $(MAKE1) -C $(@D) all

Use $(TARGET_MAKE_ENV) instead.

>  define HOST_PERL_BUILD_CMDS
> -	$(MAKE) -C $(@D)
> +	PATH=$(BR_PATH) $(MAKE) -C $(@D)

and $(HOST_MAKE_ENV).

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] perl: needs host-bison

[Gustavo Zacarias]

On 03/03/2015 07:48 AM, Thomas Petazzoni wrote:

> Dear Gustavo Zacarias,
> 
> On Tue,  3 Mar 2015 07:31:03 -0300, Gustavo Zacarias wrote:
> 
>>  define PERL_BUILD_CMDS
>> -	$(MAKE1) -C $(@D) all
>> +	PATH=$(BR_PATH) $(MAKE1) -C $(@D) all
> 
> Use $(TARGET_MAKE_ENV) instead.
> 
>>  define HOST_PERL_BUILD_CMDS
>> -	$(MAKE) -C $(@D)
>> +	PATH=$(BR_PATH) $(MAKE) -C $(@D)
> 
> and $(HOST_MAKE_ENV).

For TARGET_MAKE_ENV maybe since it's only PATH, for HOST_MAKE_ENV it's
not and it'll need extra testing to see that perl's build system doesn't
fluke with the extras.
So splitting between BR_PATH and TARGET_MAKE_ENV is possible but not
visually consistent.
Which begs the question: why do other packages use BR_PATH in the same
way as well? (without using *_MAKE_ENV)
Regards.

[Buildroot] [PATCH] perl: needs host-bison

[Thomas Petazzoni]

Dear Gustavo Zacarias,

On Tue, 03 Mar 2015 07:54:42 -0300, Gustavo Zacarias wrote:

> For TARGET_MAKE_ENV maybe since it's only PATH, for HOST_MAKE_ENV it's
> not and it'll need extra testing to see that perl's build system doesn't
> fluke with the extras.

Worth trying IMO.

> So splitting between BR_PATH and TARGET_MAKE_ENV is possible but not
> visually consistent.
> Which begs the question: why do other packages use BR_PATH in the same
> way as well? (without using *_MAKE_ENV)

Because they should be using *_MAKE_ENV :-)

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] perl: needs host-bison

[Gustavo Zacarias]

On 03/03/2015 07:59 AM, Thomas Petazzoni wrote:

>> For TARGET_MAKE_ENV maybe since it's only PATH, for HOST_MAKE_ENV it's
>> not and it'll need extra testing to see that perl's build system doesn't
>> fluke with the extras.
> 
> Worth trying IMO.

Ehmm, i wouldn't want to touch much of the perl package with a 10-foot
pole, it's not my thing any more.
I've just conjured a quick fix to get rid of some redness in the
autobuilders (also it requires me to chroot and i don't like bare
minimal chroots!).

> Because they should be using *_MAKE_ENV :-)

Fair enough.
Regards.

[Buildroot] [PATCH] perl: needs host-bison

[Thomas Petazzoni]

Dear Gustavo Zacarias,

On Tue,  3 Mar 2015 07:31:03 -0300, Gustavo Zacarias wrote:
> It's from last bump, fixes:
> http://autobuild.buildroot.net/results/1c2/1c261b09f5a4a314d5dcbc1e5811af9c7d18658a/
> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>

I've applied Fran?ois fix instead:
http://git.buildroot.net/buildroot/commit/?id=8a4c8deee9af6fa1a1e906c52d7d49a32434464c.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com