From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/zmqpp: switch to the official git
Date: Sat, 14 Mar 2015 22:45:37 +0100 [thread overview]
Message-ID: <20150314214537.GE4009@free.fr> (raw)
In-Reply-To: <1426352489-19916-1-git-send-email-romain.naour@openwide.fr>
Romain, All,
On 2015-03-14 18:01 +0100, Romain Naour spake thusly:
> The git hash 36413487f05b165dfc82ad307a5a1c36a795e607 no
> longer refers to any commit id, even in the previous git tree.
>
> By reading the Makefile and CHANGELOG.md the last know
> release is 3.2.0.
>
> Switch to the official git tree and use the 3.2.0 release tag.
>
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Some comment, however...
> ---
> package/zmqpp/zmqpp.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/zmqpp/zmqpp.mk b/package/zmqpp/zmqpp.mk
> index fbb0260..7efd04b 100644
> --- a/package/zmqpp/zmqpp.mk
> +++ b/package/zmqpp/zmqpp.mk
> @@ -4,8 +4,8 @@
> #
> ################################################################################
>
> -ZMQPP_VERSION = 36413487f05b165dfc82ad307a5a1c36a795e607
> -ZMQPP_SITE = $(call github,benjamg,zmqpp,$(ZMQPP_VERSION))
> +ZMQPP_VERSION = 3.2.0
3.2.0 is 1.5-year old, and there has been quite some changes in the
repository since then. Would it make sense to use a more recent commit?
Regards,
Yann E. MORIN.
> +ZMQPP_SITE = $(call github,zeromq,zmqpp,$(ZMQPP_VERSION))
> ZMQPP_INSTALL_STAGING = YES
> ZMQPP_DEPENDENCIES = zeromq
> ZMQPP_LICENSE = LGPLv3+ with exceptions
> --
> 1.9.3
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-03-14 21:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-14 17:01 [Buildroot] [PATCH 1/2] package/zmqpp: switch to the official git Romain Naour
2015-03-14 17:01 ` [Buildroot] [PATCH 2/2] package/zmqpp: Blacklist Blackfin ADI toolchains Romain Naour
2015-03-14 21:45 ` Yann E. MORIN [this message]
2015-03-14 22:01 ` [Buildroot] [PATCH 1/2] package/zmqpp: switch to the official git Romain Naour
2015-03-15 13:39 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150314214537.GE4009@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox