[Buildroot] [PATCH 1/2] package/zmqpp: switch to the official git

[Buildroot] [PATCH 1/2] package/zmqpp: switch to the official git

[Romain Naour]

The git hash 36413487f05b165dfc82ad307a5a1c36a795e607 no
longer refers to any commit id, even in the previous git tree.

By reading the Makefile and CHANGELOG.md the last know
release is 3.2.0.

Switch to the official git tree and use the 3.2.0 release tag.

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
 package/zmqpp/zmqpp.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/zmqpp/zmqpp.mk b/package/zmqpp/zmqpp.mk
index fbb0260..7efd04b 100644
--- a/package/zmqpp/zmqpp.mk
+++ b/package/zmqpp/zmqpp.mk
@@ -4,8 +4,8 @@
 #
 ################################################################################
 
-ZMQPP_VERSION = 36413487f05b165dfc82ad307a5a1c36a795e607
-ZMQPP_SITE = $(call github,benjamg,zmqpp,$(ZMQPP_VERSION))
+ZMQPP_VERSION = 3.2.0
+ZMQPP_SITE = $(call github,zeromq,zmqpp,$(ZMQPP_VERSION))
 ZMQPP_INSTALL_STAGING = YES
 ZMQPP_DEPENDENCIES = zeromq
 ZMQPP_LICENSE = LGPLv3+ with exceptions
-- 
1.9.3

[Buildroot] [PATCH 2/2] package/zmqpp: Blacklist Blackfin ADI toolchains

[Romain Naour]

zmqpp recommand at least a c++ compiler g++ >= 4.7
[1] for c++11 support and won't be backward compatible
whith older compliler for the next release (4.x)
due to harcoded -std=c++11 flag [2]

Blackfin ADI toolchains use a g++ 4.3 which use an
experimental c++11 support (c++0x) has not enough c++11
support to build zmqpp.

Fixes:
http://autobuild.buildroot.net/results/4c3/4c34ce881e3eab47994cc893898cbc9129ce67b5/

And many more.

[1] https://github.com/zeromq/zmqpp
[2] https://github.com/zeromq/zmqpp/commit/f078fe9a5a775aff5c74dedbdc869f8158ddf123

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
 package/zmqpp/Config.in | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/package/zmqpp/Config.in b/package/zmqpp/Config.in
index 88973db..881877a 100644
--- a/package/zmqpp/Config.in
+++ b/package/zmqpp/Config.in
@@ -1,5 +1,8 @@
 config BR2_PACKAGE_ZMQPP
 	bool "zmqpp"
+	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2014R1 # Too old gcc
+	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2013R1 # Too old gcc
+	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2 # Too old gcc
 	depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_POWERPC201103 # c++0x support
 	depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_POWERPC201009 # c++0x support
 	depends on BR2_INSTALL_LIBSTDCPP
-- 
1.9.3

[Buildroot] [PATCH 1/2] package/zmqpp: switch to the official git

[Yann E. MORIN]

Romain, All,

On 2015-03-14 18:01 +0100, Romain Naour spake thusly:
> The git hash 36413487f05b165dfc82ad307a5a1c36a795e607 no
> longer refers to any commit id, even in the previous git tree.
> 
> By reading the Makefile and CHANGELOG.md the last know
> release is 3.2.0.
> 
> Switch to the official git tree and use the 3.2.0 release tag.
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Some comment, however...

> ---
>  package/zmqpp/zmqpp.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/zmqpp/zmqpp.mk b/package/zmqpp/zmqpp.mk
> index fbb0260..7efd04b 100644
> --- a/package/zmqpp/zmqpp.mk
> +++ b/package/zmqpp/zmqpp.mk
> @@ -4,8 +4,8 @@
>  #
>  ################################################################################
>  
> -ZMQPP_VERSION = 36413487f05b165dfc82ad307a5a1c36a795e607
> -ZMQPP_SITE = $(call github,benjamg,zmqpp,$(ZMQPP_VERSION))
> +ZMQPP_VERSION = 3.2.0

3.2.0 is 1.5-year old, and there has been quite some changes in the
repository since then. Would it make sense to use a more recent commit?

Regards,
Yann E. MORIN.

> +ZMQPP_SITE = $(call github,zeromq,zmqpp,$(ZMQPP_VERSION))
>  ZMQPP_INSTALL_STAGING = YES
>  ZMQPP_DEPENDENCIES = zeromq
>  ZMQPP_LICENSE = LGPLv3+ with exceptions
> -- 
> 1.9.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 1/2] package/zmqpp: switch to the official git

[Romain Naour]

Hi Yann, All,

Le 14/03/2015 22:45, Yann E. MORIN a ?crit :
> Romain, All,
> 
> On 2015-03-14 18:01 +0100, Romain Naour spake thusly:
>> The git hash 36413487f05b165dfc82ad307a5a1c36a795e607 no
>> longer refers to any commit id, even in the previous git tree.
>>
>> By reading the Makefile and CHANGELOG.md the last know
>> release is 3.2.0.
>>
>> Switch to the official git tree and use the 3.2.0 release tag.
>>
>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> 
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
> Some comment, however...
> 
>> ---
>>  package/zmqpp/zmqpp.mk | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/package/zmqpp/zmqpp.mk b/package/zmqpp/zmqpp.mk
>> index fbb0260..7efd04b 100644
>> --- a/package/zmqpp/zmqpp.mk
>> +++ b/package/zmqpp/zmqpp.mk
>> @@ -4,8 +4,8 @@
>>  #
>>  ################################################################################
>>  
>> -ZMQPP_VERSION = 36413487f05b165dfc82ad307a5a1c36a795e607
>> -ZMQPP_SITE = $(call github,benjamg,zmqpp,$(ZMQPP_VERSION))
>> +ZMQPP_VERSION = 3.2.0
> 
> 3.2.0 is 1.5-year old, and there has been quite some changes in the
> repository since then. Would it make sense to use a more recent commit?

There is a patch from Maxime to bump to 4.1.1 but this tag appear only on the
unofficial git repository.
http://patchwork.ozlabs.org/patch/403314/

For now, master branch is at 3.2.0 and the develop branch is at 4.1.1

Thanks for the review.

Best regards,
Romain

> 
> Regards,
> Yann E. MORIN.
> 
>> +ZMQPP_SITE = $(call github,zeromq,zmqpp,$(ZMQPP_VERSION))
>>  ZMQPP_INSTALL_STAGING = YES
>>  ZMQPP_DEPENDENCIES = zeromq
>>  ZMQPP_LICENSE = LGPLv3+ with exceptions
>> -- 
>> 1.9.3
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
> 

[Buildroot] [PATCH 1/2] package/zmqpp: switch to the official git

[Thomas Petazzoni]

Dear Romain Naour,

On Sat, 14 Mar 2015 18:01:28 +0100, Romain Naour wrote:
> The git hash 36413487f05b165dfc82ad307a5a1c36a795e607 no
> longer refers to any commit id, even in the previous git tree.
> 
> By reading the Makefile and CHANGELOG.md the last know
> release is 3.2.0.
> 
> Switch to the official git tree and use the 3.2.0 release tag.
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

Both patches applied, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com