From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] infra/pkg-kconfig: don't require a kconfig file for disabled packages
Date: Wed, 8 Apr 2015 22:30:18 +0200 [thread overview]
Message-ID: <20150408223018.6f1226af@free-electrons.com> (raw)
In-Reply-To: <25c5ce55fd15b63fae1635bdc6940527079acdf6.1428512591.git.yann.morin.1998@free.fr>
Dear Yann E. MORIN,
On Wed, 8 Apr 2015 19:08:34 +0200, Yann E. MORIN wrote:
> When a package is not enabled, we need not check that it provides
> a .config/defconfig file.
>
> So far, all our pkg-kconfig packages unconditionally set their
> _KCONFIG_FILE, even to an empty value. But some packages (e.g.
> at91bootstrap3) wanted to set it only when enabled, and broke.
>
> So, only do the check when the package is enabled.
>
> Reported-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com>
Applied, thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-04-08 20:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 17:08 [Buildroot] [PATCH 0/2] pkg-kconfig: fix checking .config file (branch yem/misc) Yann E. MORIN
2015-04-08 17:08 ` [Buildroot] [PATCH 1/2] infra/pkg-kconfig: don't require a kconfig file for disabled packages Yann E. MORIN
2015-04-08 20:13 ` Arnout Vandecappelle
2015-04-08 20:30 ` Thomas Petazzoni [this message]
2015-04-08 17:08 ` [Buildroot] [PATCH 2/2] infra/pkg-kconfig: require an non-empty KCONFIG_FILE Yann E. MORIN
2015-04-08 20:22 ` Arnout Vandecappelle
2015-04-08 20:49 ` Yann E. MORIN
2015-04-10 20:01 ` Arnout Vandecappelle
2015-04-10 20:40 ` Yann E. MORIN
2015-04-10 21:57 ` Arnout Vandecappelle
2015-06-10 7:38 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150408223018.6f1226af@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox