Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 0/2] pkg-kconfig: fix checking .config file (branch yem/misc)
Date: Wed,  8 Apr 2015 19:08:31 +0200	[thread overview]
Message-ID: <cover.1428512591.git.yann.morin.1998@free.fr> (raw)

Hello All!

This series tries to fix the pkg-kconfig infra for disabled packages.

Currently, the pkg-kconfig infra always checks that the specified
FOO_KCONFIG_FILE variable is set (and does not care if it's empty, as
long as it is set), even for packages that were not enabled by the user.

This is dubious at best, and forces kconfig-based packages to always set
that variable, even to an empty value.

Furthermore, it does not even check if the variable is non-empty.

Fix that in two ways:
  - only do the check when the package is actually enabled;
  - change the check to test if the variable is non-empty (instead of
    merely set).

Regards,
Yann E. MORIN.


The following changes since commit 2552729232b4d9c5cb63ad247d6d94ab83e48e49:

  package/mplayer: add optional libenca support (2015-04-07 23:27:23 +0200)

are available in the git repository at:

  git://git.busybox.net/~ymorin/git/buildroot yem/misc

for you to fetch changes up to c5c81694cabca70c5651fe42a7de99247275659c:

  infra/pkg-kconfig: require an non-empty KCONFIG_FILE (2015-04-08 19:01:54 +0200)

----------------------------------------------------------------
Yann E. MORIN (2):
      infra/pkg-kconfig: don't require a kconfig file for disabled packages
      infra/pkg-kconfig: require an non-empty KCONFIG_FILE

 package/pkg-kconfig.mk | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

             reply	other threads:[~2015-04-08 17:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-08 17:08 Yann E. MORIN [this message]
2015-04-08 17:08 ` [Buildroot] [PATCH 1/2] infra/pkg-kconfig: don't require a kconfig file for disabled packages Yann E. MORIN
2015-04-08 20:13   ` Arnout Vandecappelle
2015-04-08 20:30   ` Thomas Petazzoni
2015-04-08 17:08 ` [Buildroot] [PATCH 2/2] infra/pkg-kconfig: require an non-empty KCONFIG_FILE Yann E. MORIN
2015-04-08 20:22   ` Arnout Vandecappelle
2015-04-08 20:49     ` Yann E. MORIN
2015-04-10 20:01       ` Arnout Vandecappelle
2015-04-10 20:40         ` Yann E. MORIN
2015-04-10 21:57           ` Arnout Vandecappelle
2015-06-10  7:38   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1428512591.git.yann.morin.1998@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox