From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] infra/pkg-kconfig: require an non-empty KCONFIG_FILE
Date: Wed, 10 Jun 2015 09:38:42 +0200 [thread overview]
Message-ID: <20150610093842.289707b7@free-electrons.com> (raw)
In-Reply-To: <c5c81694cabca70c5651fe42a7de99247275659c.1428512591.git.yann.morin.1998@free.fr>
Dear Yann E. MORIN,
On Wed, 8 Apr 2015 19:08:35 +0200, Yann E. MORIN wrote:
> Currently, we only check that the variable is defined, which is not
> enough since we really want it to be non-empty.
>
> We however can't check it points to an existing file, because the
> package might well not be extracted yet, and we may use an internal
> defconfig. If that file does not eventually exist, there will be a
> failure down the road at build time when we try to copy it...
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com>
> ---
> package/pkg-kconfig.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-06-10 7:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 17:08 [Buildroot] [PATCH 0/2] pkg-kconfig: fix checking .config file (branch yem/misc) Yann E. MORIN
2015-04-08 17:08 ` [Buildroot] [PATCH 1/2] infra/pkg-kconfig: don't require a kconfig file for disabled packages Yann E. MORIN
2015-04-08 20:13 ` Arnout Vandecappelle
2015-04-08 20:30 ` Thomas Petazzoni
2015-04-08 17:08 ` [Buildroot] [PATCH 2/2] infra/pkg-kconfig: require an non-empty KCONFIG_FILE Yann E. MORIN
2015-04-08 20:22 ` Arnout Vandecappelle
2015-04-08 20:49 ` Yann E. MORIN
2015-04-10 20:01 ` Arnout Vandecappelle
2015-04-10 20:40 ` Yann E. MORIN
2015-04-10 21:57 ` Arnout Vandecappelle
2015-06-10 7:38 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150610093842.289707b7@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox