Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2 18/21] pkg-generic: propagate <pkg>_EXTRA_DOWNLOADS from target to host package
Date: Fri, 17 Apr 2015 17:27:14 +0200	[thread overview]
Message-ID: <20150417172714.2d74113e@free-electrons.com> (raw)
In-Reply-To: <552D8BC3.9040803@mind.be>

Dear Arnout Vandecappelle,

On Tue, 14 Apr 2015 23:50:59 +0200, Arnout Vandecappelle wrote:
> On 12/04/15 18:38, Thomas Petazzoni wrote:
> > Just like <pkg>_PATCH, <pkg>_SOURCE or <pkg>_SITE, the
> > <pkg>_EXTRA_DOWNLOADS variable of a host package should be
> > automatically inferred from the <pkg>_EXTRA_DOWNLOADS value of the
> > corresponding target package, unless an explicit value is being
> > defined for the host package. This commit implements this for
> > <pkg>_EXTRA_DOWNLOADS.
> 
>  I'm not so sure about this one. _EXTRA_DOWNLOADS is currently used for the
> blackfin toolchains and for perl. Toolchains are target packages so no issue
> there, but for perl, we really only need perl-cross for the target perl. At the
> moment, host-perl is only built as a dependency of perl so it doesn't hurt to
> download perl-cross for host-perl, but it is unnecessary.
> 
>  Is there a hidden reason why you want this (i.e. is it required for some later
> patch)?

Not that I remember of. The only reason was pure consistency: since
source, site, version and patch are all inherited from the target
variant to the host variant, is seemed to make sense as well for extra
downloads.

I can get rid of this aspect if you think it's not really appropriate,
since I indeed don't really have a use case for it, except a pure
consistency feeling.

Thanks for the review!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-04-17 15:27 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-12 16:37 [Buildroot] [PATCHv2 00/21] Package based 'source', 'legal-info', 'source-check' and 'external-deps' Thomas Petazzoni
2015-04-12 16:37 ` [Buildroot] [PATCHv2 01/21] pkg-kconfig: declare phony targets as such Thomas Petazzoni
2015-04-13 19:32   ` Yann E. MORIN
2015-04-12 16:37 ` [Buildroot] [PATCHv2 02/21] fs: " Thomas Petazzoni
2015-04-13 19:37   ` Yann E. MORIN
2015-04-14  8:13     ` Thomas Petazzoni
2015-04-12 16:37 ` [Buildroot] [PATCHv2 03/21] Makefile: targets are now declared phony by the appropriate infrastructures Thomas Petazzoni
2015-04-13 19:44   ` Yann E. MORIN
2015-04-14  8:17     ` Thomas Petazzoni
2015-04-12 16:37 ` [Buildroot] [PATCHv2 04/21] Makefile: rename TARGETS to PACKAGES Thomas Petazzoni
2015-04-13 20:01   ` Yann E. MORIN
2015-04-14  8:18     ` Thomas Petazzoni
2015-04-12 16:37 ` [Buildroot] [PATCHv2 05/21] fs: add rootfs dependencies " Thomas Petazzoni
2015-04-12 16:37 ` [Buildroot] [PATCHv2 06/21] Makefile: use <pkg>-all-legal-info to implement the legal-info target Thomas Petazzoni
2015-04-13 20:14   ` Yann E. MORIN
2015-04-12 16:37 ` [Buildroot] [PATCHv2 07/21] Makefile: simplify show-targets Thomas Petazzoni
2015-04-12 16:37 ` [Buildroot] [PATCHv2 08/21] Makefile: use the package infra based external-deps Thomas Petazzoni
2015-04-14  0:10   ` Arnout Vandecappelle
2015-04-14  7:52     ` Thomas Petazzoni
2015-04-14 11:22       ` Arnout Vandecappelle
2015-04-14 12:05         ` Thomas Petazzoni
2015-04-14 19:14           ` Arnout Vandecappelle
2015-04-12 16:37 ` [Buildroot] [PATCHv2 09/21] pkg-download: remove support for the SHOW_EXTERNAL_DEPS DL_MODE Thomas Petazzoni
2015-04-13 20:31   ` Yann E. MORIN
2015-04-13 20:33     ` Thomas Petazzoni
2015-04-13 20:40       ` Yann E. MORIN
2015-04-13 22:29         ` Arnout Vandecappelle
2015-04-13 20:38   ` Yann E. MORIN
2015-04-14 19:34   ` Arnout Vandecappelle
2015-04-12 16:37 ` [Buildroot] [PATCHv2 10/21] Makefile: move source-check outside of noconfig_targets Thomas Petazzoni
2015-04-13 20:49   ` Yann E. MORIN
2015-04-13 21:06     ` Thomas Petazzoni
2015-04-13 21:58       ` Yann E. MORIN
2015-04-13 22:18         ` Ryan Barnett
2015-04-14 19:42   ` Arnout Vandecappelle
2015-04-14 21:38     ` Yann E. MORIN
2015-04-17 15:49     ` Thomas Petazzoni
2015-04-12 16:37 ` [Buildroot] [PATCHv2 11/21] pkg-download: extend DOWNLOAD_INNER, add a SOURCE_CHECK macro Thomas Petazzoni
2015-04-13 21:00   ` Yann E. MORIN
2015-04-14 20:06     ` Arnout Vandecappelle
2015-04-14 22:25       ` Yann E. MORIN
2015-04-14 22:41         ` Arnout Vandecappelle
2015-04-17 10:38           ` Nicolas Cavallari
2015-04-17 14:00             ` Arnout Vandecappelle
2015-04-12 16:37 ` [Buildroot] [PATCHv2 12/21] pkg-generic: implement source-check targets Thomas Petazzoni
2015-04-13 21:05   ` Yann E. MORIN
2015-04-13 21:25     ` Yann E. MORIN
2015-04-13 21:36       ` Yann E. MORIN
2015-04-14 20:22   ` Arnout Vandecappelle
2015-04-12 16:37 ` [Buildroot] [PATCHv2 13/21] Makefile: implement a package based source-check target Thomas Petazzoni
2015-04-13 21:07   ` Yann E. MORIN
2015-04-14 20:30   ` Arnout Vandecappelle
2015-04-12 16:37 ` [Buildroot] [PATCHv2 14/21] pkg-generic: remove the .stamp_rsync_sourced fake stamp file Thomas Petazzoni
2015-04-14 20:55   ` Arnout Vandecappelle
2015-04-12 16:37 ` [Buildroot] [PATCHv2 15/21] pkg-generic: don't use DL_MODE in .stamp_downloaded Thomas Petazzoni
2015-04-14 21:36   ` Arnout Vandecappelle
2015-04-12 16:38 ` [Buildroot] [PATCHv2 16/21] pkg-download: get rid of DL_MODE Thomas Petazzoni
2015-04-14 21:46   ` Arnout Vandecappelle
2015-04-12 16:38 ` [Buildroot] [PATCHv2 17/21] pkg-download: fix indentation for SOURCE_CHECK_* macros Thomas Petazzoni
2015-04-14 21:41   ` Arnout Vandecappelle
2015-04-12 16:38 ` [Buildroot] [PATCHv2 18/21] pkg-generic: propagate <pkg>_EXTRA_DOWNLOADS from target to host package Thomas Petazzoni
2015-04-14 21:50   ` Arnout Vandecappelle
2015-04-17 15:27     ` Thomas Petazzoni [this message]
2015-04-12 16:38 ` [Buildroot] [PATCHv2 19/21] pkg-generic: introduce a <pkg>_ALL_DOWNLOADS variable and factorize code Thomas Petazzoni
2015-04-14 22:27   ` Arnout Vandecappelle
2015-04-12 16:38 ` [Buildroot] [PATCHv2 20/21] Makefile: implement the 'source' target using the package infrastructure Thomas Petazzoni
2015-04-14 22:31   ` Arnout Vandecappelle
2015-04-12 16:38 ` [Buildroot] [PATCHv2 21/21] Makefile: remove unneeded variables Thomas Petazzoni
2015-04-14 22:31   ` Arnout Vandecappelle
2015-04-12 17:16 ` [Buildroot] [PATCHv2 00/21] Package based 'source', 'legal-info', 'source-check' and 'external-deps' Thomas Petazzoni
2015-04-13 21:46 ` Yann E. MORIN
2015-04-14  8:20 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150417172714.2d74113e@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox