[Buildroot] [PATCHv2 11/21] pkg-download: extend DOWNLOAD_INNER, add a SOURCE_CHECK macro

[Nicolas Cavallari <Nicolas.Cavallari@green-communications.fr>]

On 15/04/2015 00:41, Arnout Vandecappelle wrote:
> On 15/04/15 00:25, Yann E. MORIN wrote:
>> In the ned, does source-check really makes sense?
>>
>> Let me rephrase...
>>
>> What's the purpose of source-check?
>>
>> As far as I can see, there are two use-cases:
>>
>>   - for us Buildroot devs: check that an upstream still provides a
>>     resource;
>>
>>   - for a standard user to check if he can get the source of his set of
>>     packages.
>>
>> But is that really necessary?
>>
>> For a user, what can he do if the package can't be downloaded (i.e. not
>> in upstream and not on our mirror)? Nothing...
>>
>> For us, all we need to know is that something can't be downloaded so we
>> can bump the package (or point it to our mirror). We have autobuilders
>> to catch download failures.
>>
>> So, does it make sense to keep source-check at all?
> 
> 
>  I was thinking the same thing, I can't really see a use case for it. Actually,
> same thing for external-deps.

external-deps is useful: We use it e.g. to clean a dl/ directory after
bumping package versions, or to copy only relevant files in dl/ to an
offline location.

Clearing the dl/ directory and running "make source" would end up with
the same thing, but it would redownloads everything so it would be
much slower.