[Buildroot] [PATCH 1/2] rpi-firmware: allow disabling installation of binary DTBs

[Buildroot] [PATCH 1/2] rpi-firmware: allow disabling installation of binary DTBs

[Floris Bos]

The binary .dtb files are not suitable for everyone as they are
kernel version specific.
Reintroduces BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS option.

Signed-off-by: Floris Bos <bos@je-eigen-domein.nl>
---
 package/rpi-firmware/Config.in       | 10 ++++++++++
 package/rpi-firmware/rpi-firmware.mk |  2 ++
 2 files changed, 12 insertions(+)

diff --git a/package/rpi-firmware/Config.in b/package/rpi-firmware/Config.in
index cd45be4..2de26e3 100644
--- a/package/rpi-firmware/Config.in
+++ b/package/rpi-firmware/Config.in
@@ -45,4 +45,14 @@ config BR2_PACKAGE_RPI_FIRMWARE_BOOT
 	default "_x"    if BR2_PACKAGE_RPI_FIRMWARE_X
 	default "_cd"   if BR2_PACKAGE_RPI_FIRMWARE_CD
 
+config BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS
+	bool "Install Device Tree Blobs (DTBs)"
+	default "y"
+	help
+	  Say 'y' here if you want to install the binary DTB files which
+	  are suitable for a rpi-3.18.y branch Linux kernel.
+
+	  Say 'n' here if you intend to compile the device tree files
+	  from kernel source instead.
+
 endif # BR2_PACKAGE_RPI_FIRMWARE
diff --git a/package/rpi-firmware/rpi-firmware.mk b/package/rpi-firmware/rpi-firmware.mk
index cbcf790..9cccb38 100644
--- a/package/rpi-firmware/rpi-firmware.mk
+++ b/package/rpi-firmware/rpi-firmware.mk
@@ -13,6 +13,7 @@ RPI_FIRMWARE_INSTALL_IMAGES = YES
 
 RPI_FIRMWARE_DEPENDENCIES += host-rpi-firmware
 
+ifeq ($(BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS),y)
 define RPI_FIRMWARE_INSTALL_DTB
 	$(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b.dtb
 	$(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b-plus.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b-plus.dtb
@@ -21,6 +22,7 @@ define RPI_FIRMWARE_INSTALL_DTB
 		$(INSTALL) -D -m 0644 $${ovldtb} $(BINARIES_DIR)/rpi-firmware/overlays/$${ovldtb##*/} || exit 1; \
 	done
 endef
+endif
 
 define RPI_FIRMWARE_INSTALL_IMAGES_CMDS
 	$(INSTALL) -D -m 0644 $(@D)/boot/bootcode.bin $(BINARIES_DIR)/rpi-firmware/bootcode.bin
-- 
2.1.4

[Buildroot] [PATCH 2/2] rpi-firmware: modify settings for Pi 2

[Floris Bos]

Remove low-level settings from config.txt like arm_freq and sdram_freq.
The defaults should be good for most and differ by Pi model.
E.g. the Pi 2 runs at 900 Mhz by default, setting arm_freq=700
like we had previously would underclock it.

Add short description in comments to options.
Mention initramfs option.

Remove obsolete options from cmdline.txt

Signed-off-by: Floris Bos <bos@je-eigen-domein.nl>
---
 package/rpi-firmware/cmdline.txt |  2 +-
 package/rpi-firmware/config.txt  | 14 ++++++++++----
 2 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/package/rpi-firmware/cmdline.txt b/package/rpi-firmware/cmdline.txt
index 061e54b..38aa378 100644
--- a/package/rpi-firmware/cmdline.txt
+++ b/package/rpi-firmware/cmdline.txt
@@ -1 +1 @@
-dwc_otg.fiq_fix_enable=1 sdhci-bcm2708.sync_after_dma=0 dwc_otg.lpm_enable=0 console=tty1 root=/dev/mmcblk0p2 rootwait
+root=/dev/mmcblk0p2 rootwait
diff --git a/package/rpi-firmware/config.txt b/package/rpi-firmware/config.txt
index 994972b..aa8d2ab 100644
--- a/package/rpi-firmware/config.txt
+++ b/package/rpi-firmware/config.txt
@@ -4,11 +4,17 @@
 # See http://buildroot.org/downloads/manual/manual.html#rootfs-custom
 # and http://elinux.org/RPiconfig for a description of config.txt syntax
 
-arm_freq=700
-core_freq=250
 kernel=zImage
+
+# To use an external initramfs file
+#initramfs rootfs.cpio.gz
+
+# Disable overscan assuming the display supports displaying the full resolution
+# If the text shown on the screen disappears off the edge, comment this out
 disable_overscan=1
+
+# How much memory in MB to assign to the GPU on Pi models having
+# 256, 512 or 1024 MB total memory
 gpu_mem_256=100
 gpu_mem_512=100
-sdram_freq=400
-over_voltage=0
+gpu_mem_1024=100
-- 
2.1.4

[Buildroot] [PATCH v2] php.ini: set date.timezone

[Floris Bos]

Set date.timezone in php.ini to match time zone settings.
Prevents a warning being logged about it not being set
each time a PHP date/time method is used.

Signed-off-by: Floris Bos <bos@je-eigen-domein.nl>

---
v2: follows Arnout's suggestion, using BR2_TARGET_LOCALTIME
---
 package/php/php.mk | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/package/php/php.mk b/package/php/php.mk
index 3b9a117..47811ff 100644
--- a/package/php/php.mk
+++ b/package/php/php.mk
@@ -24,6 +24,12 @@ PHP_CONF_ENV = \
 	ac_cv_func_strcasestr=yes \
 	EXTRA_LIBS="$(PHP_EXTRA_LIBS)"
 
+ifeq ($(BR2_TARGET_LOCALTIME),)
+PHP_LOCALTIME = UTC
+else
+PHP_LOCALTIME = $(BR2_TARGET_LOCALTIME)
+endif
+
 # PHP can't be AUTORECONFed the standard way unfortunately
 PHP_DEPENDENCIES += host-autoconf host-automake host-libtool
 define PHP_BUILDCONF
@@ -288,6 +294,8 @@ define PHP_INSTALL_FIXUP
 	rm -f $(TARGET_DIR)/usr/bin/phpize
 	$(INSTALL) -D -m 0755 $(PHP_DIR)/php.ini-production \
 		$(TARGET_DIR)/etc/php.ini
+	$(SED) 's%;date.timezone =.*%date.timezone = $(PHP_LOCALTIME)%' \
+		$(TARGET_DIR)/etc/php.ini
 endef
 
 PHP_POST_INSTALL_TARGET_HOOKS += PHP_INSTALL_FIXUP
-- 
2.1.4

[Buildroot] [PATCH v2] php.ini: set date.timezone

[Arnout Vandecappelle]

On 02/05/15 17:10, Floris Bos wrote:
> Set date.timezone in php.ini to match time zone settings.
> Prevents a warning being logged about it not being set
> each time a PHP date/time method is used.
> 
> Signed-off-by: Floris Bos <bos@je-eigen-domein.nl>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 Regards,
 Arnout

> 
> ---
> v2: follows Arnout's suggestion, using BR2_TARGET_LOCALTIME
> ---
>  package/php/php.mk | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/package/php/php.mk b/package/php/php.mk
> index 3b9a117..47811ff 100644
> --- a/package/php/php.mk
> +++ b/package/php/php.mk
> @@ -24,6 +24,12 @@ PHP_CONF_ENV = \
>  	ac_cv_func_strcasestr=yes \
>  	EXTRA_LIBS="$(PHP_EXTRA_LIBS)"
>  
> +ifeq ($(BR2_TARGET_LOCALTIME),)
> +PHP_LOCALTIME = UTC
> +else
> +PHP_LOCALTIME = $(BR2_TARGET_LOCALTIME)
> +endif
> +
>  # PHP can't be AUTORECONFed the standard way unfortunately
>  PHP_DEPENDENCIES += host-autoconf host-automake host-libtool
>  define PHP_BUILDCONF
> @@ -288,6 +294,8 @@ define PHP_INSTALL_FIXUP
>  	rm -f $(TARGET_DIR)/usr/bin/phpize
>  	$(INSTALL) -D -m 0755 $(PHP_DIR)/php.ini-production \
>  		$(TARGET_DIR)/etc/php.ini
> +	$(SED) 's%;date.timezone =.*%date.timezone = $(PHP_LOCALTIME)%' \
> +		$(TARGET_DIR)/etc/php.ini
>  endef
>  
>  PHP_POST_INSTALL_TARGET_HOOKS += PHP_INSTALL_FIXUP
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

[Buildroot] [PATCH 2/2] rpi-firmware: modify settings for Pi 2

[Yann E. MORIN]

Floris, All,

On 2015-05-02 17:10 +0200, Floris Bos spake thusly:
> Remove low-level settings from config.txt like arm_freq and sdram_freq.
> The defaults should be good for most and differ by Pi model.
> E.g. the Pi 2 runs at 900 Mhz by default, setting arm_freq=700
> like we had previously would underclock it.
> 
> Add short description in comments to options.
> Mention initramfs option.
> 
> Remove obsolete options from cmdline.txt
> 
> Signed-off-by: Floris Bos <bos@je-eigen-domein.nl>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/rpi-firmware/cmdline.txt |  2 +-
>  package/rpi-firmware/config.txt  | 14 ++++++++++----
>  2 files changed, 11 insertions(+), 5 deletions(-)
> 
> diff --git a/package/rpi-firmware/cmdline.txt b/package/rpi-firmware/cmdline.txt
> index 061e54b..38aa378 100644
> --- a/package/rpi-firmware/cmdline.txt
> +++ b/package/rpi-firmware/cmdline.txt
> @@ -1 +1 @@
> -dwc_otg.fiq_fix_enable=1 sdhci-bcm2708.sync_after_dma=0 dwc_otg.lpm_enable=0 console=tty1 root=/dev/mmcblk0p2 rootwait
> +root=/dev/mmcblk0p2 rootwait
> diff --git a/package/rpi-firmware/config.txt b/package/rpi-firmware/config.txt
> index 994972b..aa8d2ab 100644
> --- a/package/rpi-firmware/config.txt
> +++ b/package/rpi-firmware/config.txt
> @@ -4,11 +4,17 @@
>  # See http://buildroot.org/downloads/manual/manual.html#rootfs-custom
>  # and http://elinux.org/RPiconfig for a description of config.txt syntax
>  
> -arm_freq=700
> -core_freq=250
>  kernel=zImage
> +
> +# To use an external initramfs file
> +#initramfs rootfs.cpio.gz
> +
> +# Disable overscan assuming the display supports displaying the full resolution
> +# If the text shown on the screen disappears off the edge, comment this out
>  disable_overscan=1
> +
> +# How much memory in MB to assign to the GPU on Pi models having
> +# 256, 512 or 1024 MB total memory
>  gpu_mem_256=100
>  gpu_mem_512=100
> -sdram_freq=400
> -over_voltage=0
> +gpu_mem_1024=100
> -- 
> 2.1.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 2/2] rpi-firmware: modify settings for Pi 2

[Thomas Petazzoni]

Dear Floris Bos,

On Sat,  2 May 2015 17:10:14 +0200, Floris Bos wrote:
> Remove low-level settings from config.txt like arm_freq and sdram_freq.
> The defaults should be good for most and differ by Pi model.
> E.g. the Pi 2 runs at 900 Mhz by default, setting arm_freq=700
> like we had previously would underclock it.
> 
> Add short description in comments to options.
> Mention initramfs option.
> 
> Remove obsolete options from cmdline.txt
> 
> Signed-off-by: Floris Bos <bos@je-eigen-domein.nl>
> ---
>  package/rpi-firmware/cmdline.txt |  2 +-
>  package/rpi-firmware/config.txt  | 14 ++++++++++----
>  2 files changed, 11 insertions(+), 5 deletions(-)

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH v2] php.ini: set date.timezone

[Thomas Petazzoni]

Dear Floris Bos,

On Sat,  2 May 2015 17:10:15 +0200, Floris Bos wrote:

> +ifeq ($(BR2_TARGET_LOCALTIME),)
> +PHP_LOCALTIME = UTC
> +else
> +PHP_LOCALTIME = $(BR2_TARGET_LOCALTIME)

I suppose you tested that a qstrip call is not needed here.

So, I applied with Arnout Reviewed-by.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH v2] php.ini: set date.timezone

[Floris Bos]

On 05/02/2015 07:18 PM, Thomas Petazzoni wrote:
> Dear Floris Bos,
>
> On Sat,  2 May 2015 17:10:15 +0200, Floris Bos wrote:
>
>> +ifeq ($(BR2_TARGET_LOCALTIME),)
>> +PHP_LOCALTIME = UTC
>> +else
>> +PHP_LOCALTIME = $(BR2_TARGET_LOCALTIME)
> I suppose you tested that a qstrip call is not needed here.

Yes.
Quotes are fine in php.ini


Yours sincerely,

Floris Bos

[Buildroot] [PATCH v2] php.ini: set date.timezone

[Thomas Petazzoni]

Hello,

On Sat, 02 May 2015 19:22:05 +0200, Floris Bos wrote:

> Yes.
> Quotes are fine in php.ini

Great, thanks for the confirmation.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/2] rpi-firmware: allow disabling installation of binary DTBs

[Yann E. MORIN]

floris, All,

On 2015-05-02 17:10 +0200, Floris Bos spake thusly:
> The binary .dtb files are not suitable for everyone as they are
> kernel version specific.
> Reintroduces BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS option.

I am revisitng this one now that I have a little tiny bit of time.

Indeed, using the DTBs from rpi-firmware is not working with linux 3.19
or 4.0, although they do work with 3.18.

> Signed-off-by: Floris Bos <bos@je-eigen-domein.nl>
> ---
>  package/rpi-firmware/Config.in       | 10 ++++++++++
>  package/rpi-firmware/rpi-firmware.mk |  2 ++
>  2 files changed, 12 insertions(+)
> 
> diff --git a/package/rpi-firmware/Config.in b/package/rpi-firmware/Config.in
> index cd45be4..2de26e3 100644
> --- a/package/rpi-firmware/Config.in
> +++ b/package/rpi-firmware/Config.in
> @@ -45,4 +45,14 @@ config BR2_PACKAGE_RPI_FIRMWARE_BOOT
>  	default "_x"    if BR2_PACKAGE_RPI_FIRMWARE_X
>  	default "_cd"   if BR2_PACKAGE_RPI_FIRMWARE_CD
>  
> +config BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS
> +	bool "Install Device Tree Blobs (DTBs)"
> +	default "y"
> +	help
> +	  Say 'y' here if you want to install the binary DTB files which
> +	  are suitable for a rpi-3.18.y branch Linux kernel.
> +
> +	  Say 'n' here if you intend to compile the device tree files
> +	  from kernel source instead.

I would rephrase that as:

    If you are using a Linux kernel <= 3.18, you should say 'y' here.

    If you are using a Linux kernel >= 3.19, you should say 'n' here,
    and enable BR2_LINUX_KERNEL_DTS_SUPPORT to let the kernel build
    the DTB.

> +
>  endif # BR2_PACKAGE_RPI_FIRMWARE
> diff --git a/package/rpi-firmware/rpi-firmware.mk b/package/rpi-firmware/rpi-firmware.mk
> index cbcf790..9cccb38 100644
> --- a/package/rpi-firmware/rpi-firmware.mk
> +++ b/package/rpi-firmware/rpi-firmware.mk
> @@ -13,6 +13,7 @@ RPI_FIRMWARE_INSTALL_IMAGES = YES
>  
>  RPI_FIRMWARE_DEPENDENCIES += host-rpi-firmware
>  
> +ifeq ($(BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS),y)
>  define RPI_FIRMWARE_INSTALL_DTB
>  	$(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b.dtb
>  	$(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b-plus.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b-plus.dtb
> @@ -21,6 +22,7 @@ define RPI_FIRMWARE_INSTALL_DTB
>  		$(INSTALL) -D -m 0644 $${ovldtb} $(BINARIES_DIR)/rpi-firmware/overlays/$${ovldtb##*/} || exit 1; \
>  	done
>  endef
> +endif

I'd put the overlays out of the conditional block, because they are
*not* built by the Linux kernel.

Also, I think we'd want an option to enable/disable installign the
overlays.

I'll take your patch here and repsin a bit later tonight.

Thanks! :-)

Regards,
Yann E. MORIN.

>  define RPI_FIRMWARE_INSTALL_IMAGES_CMDS
>  	$(INSTALL) -D -m 0644 $(@D)/boot/bootcode.bin $(BINARIES_DIR)/rpi-firmware/bootcode.bin
> -- 
> 2.1.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 1/2] rpi-firmware: allow disabling installation of binary DTBs

[Floris Bos]

On 06/19/2015 10:30 PM, Yann E. MORIN wrote:
> +config BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS
> +	bool "Install Device Tree Blobs (DTBs)"
> +	default "y"
> +	help
> +	  Say 'y' here if you want to install the binary DTB files which
> +	  are suitable for a rpi-3.18.y branch Linux kernel.
> +
> +	  Say 'n' here if you intend to compile the device tree files
> +	  from kernel source instead.
> I would rephrase that as:
>
>      If you are using a Linux kernel <= 3.18, you should say 'y' here.
>
>      If you are using a Linux kernel >= 3.19, you should say 'n' here,
>      and enable BR2_LINUX_KERNEL_DTS_SUPPORT to let the kernel build
>      the DTB.
>

Rephrashing is fine with me.

>   endif # BR2_PACKAGE_RPI_FIRMWARE
> diff --git a/package/rpi-firmware/rpi-firmware.mk b/package/rpi-firmware/rpi-firmware.mk
> index cbcf790..9cccb38 100644
> --- a/package/rpi-firmware/rpi-firmware.mk
> +++ b/package/rpi-firmware/rpi-firmware.mk
> @@ -13,6 +13,7 @@ RPI_FIRMWARE_INSTALL_IMAGES = YES
>   
>   RPI_FIRMWARE_DEPENDENCIES += host-rpi-firmware
>   
> +ifeq ($(BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS),y)
>   define RPI_FIRMWARE_INSTALL_DTB
>   	$(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b.dtb
>   	$(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b-plus.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b-plus.dtb
> @@ -21,6 +22,7 @@ define RPI_FIRMWARE_INSTALL_DTB
>   		$(INSTALL) -D -m 0644 $${ovldtb} $(BINARIES_DIR)/rpi-firmware/overlays/$${ovldtb##*/} || exit 1; \
>   	done
>   endef
> +endif
> I'd put the overlays out of the conditional block, because they are
> *not* built by the Linux kernel.

They do seem to be part of the rpi Linux source tree: 
https://github.com/raspberrypi/linux/tree/rpi-3.18.y/arch/arm/boot/dts/overlays
Isn't it a matter of adding overlay/name-of-overlay to 
BR2_LINUX_KERNEL_INTREE_DTS_NAME if someone wants an overlay build?



Yours sincerely,

Floris Bos

[Buildroot] [PATCH 1/2] rpi-firmware: allow disabling installation of binary DTBs

[Yann E. MORIN]

Floris, All,

On 2015-06-19 22:52 +0200, Floris Bos spake thusly:
> On 06/19/2015 10:30 PM, Yann E. MORIN wrote:
> >+config BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS
> >+	bool "Install Device Tree Blobs (DTBs)"
> >+	default "y"
> >+	help
> >+	  Say 'y' here if you want to install the binary DTB files which
> >+	  are suitable for a rpi-3.18.y branch Linux kernel.
> >+
> >+	  Say 'n' here if you intend to compile the device tree files
> >+	  from kernel source instead.
> >I would rephrase that as:
> >
> >     If you are using a Linux kernel <= 3.18, you should say 'y' here.
> >
> >     If you are using a Linux kernel >= 3.19, you should say 'n' here,
> >     and enable BR2_LINUX_KERNEL_DTS_SUPPORT to let the kernel build
> >     the DTB.
> 
> Rephrashing is fine with me.

OK, thanks.

> >  endif # BR2_PACKAGE_RPI_FIRMWARE
> >diff --git a/package/rpi-firmware/rpi-firmware.mk b/package/rpi-firmware/rpi-firmware.mk
> >index cbcf790..9cccb38 100644
> >--- a/package/rpi-firmware/rpi-firmware.mk
> >+++ b/package/rpi-firmware/rpi-firmware.mk
> >@@ -13,6 +13,7 @@ RPI_FIRMWARE_INSTALL_IMAGES = YES
> >  RPI_FIRMWARE_DEPENDENCIES += host-rpi-firmware
> >+ifeq ($(BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS),y)
> >  define RPI_FIRMWARE_INSTALL_DTB
> >  	$(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b.dtb
> >  	$(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b-plus.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b-plus.dtb
> >@@ -21,6 +22,7 @@ define RPI_FIRMWARE_INSTALL_DTB
> >  		$(INSTALL) -D -m 0644 $${ovldtb} $(BINARIES_DIR)/rpi-firmware/overlays/$${ovldtb##*/} || exit 1; \
> >  	done
> >  endef
> >+endif
> >I'd put the overlays out of the conditional block, because they are
> >*not* built by the Linux kernel.
> 
> They do seem to be part of the rpi Linux source tree:
> https://github.com/raspberrypi/linux/tree/rpi-3.18.y/arch/arm/boot/dts/overlays

Ah, indeed. I was mislead by looking at the rpi-4.0.y branch, which does
not have that sub-directory. But looking further, the overlays are all
along side the standard DTS, not in a sub-directory.

I'll see what I can do with that.

> Isn't it a matter of adding overlay/name-of-overlay to
> BR2_LINUX_KERNEL_INTREE_DTS_NAME if someone wants an overlay build?

It would seem so. I'll test that.

Thanks for the tips! :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 1/2] rpi-firmware: allow disabling installation of binary DTBs

[Yann E. MORIN]

Floris, All,

On 2015-06-19 23:07 +0200, Yann E. MORIN spake thusly:
> On 2015-06-19 22:52 +0200, Floris Bos spake thusly:
> > On 06/19/2015 10:30 PM, Yann E. MORIN wrote:
[--SNIP--]
> > >I'd put the overlays out of the conditional block, because they are
> > >*not* built by the Linux kernel.
> > 
> > They do seem to be part of the rpi Linux source tree:
> > https://github.com/raspberrypi/linux/tree/rpi-3.18.y/arch/arm/boot/dts/overlays
> 
> Ah, indeed. I was mislead by looking at the rpi-4.0.y branch, which does
> not have that sub-directory. But looking further, the overlays are all
> along side the standard DTS, not in a sub-directory.

OK, so I was a bit mislead. I was looking at the rpi-3.19.y branch,
which has all the overlays alongside the standard dts. the rpi-3.18.y
and rpi4.0.y branches indeed have them in a specific sub-dir, as you
pointed out.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 1/2] rpi-firmware: allow disabling installation of binary DTBs

[Yann E. MORIN]

Floris, All,

On 2015-06-19 22:52 +0200, Floris Bos spake thusly:
> On 06/19/2015 10:30 PM, Yann E. MORIN wrote:
[--SNIP--]
> >I'd put the overlays out of the conditional block, because they are
> >*not* built by the Linux kernel.
> 
> They do seem to be part of the rpi Linux source tree: https://github.com/raspberrypi/linux/tree/rpi-3.18.y/arch/arm/boot/dts/overlays
> Isn't it a matter of adding overlay/name-of-overlay to
> BR2_LINUX_KERNEL_INTREE_DTS_NAME if someone wants an overlay build?

In fact, no, it does not work.

We would need to do some changes in Buildroot for how we handle DTB
generation to be able to generate the DTB overlays.

So, I've postponed that change for later, and introduced a new Kconfig
knob to install DTB overlays:
    https://patchwork.ozlabs.org/patch/489181/

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'