From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v8 2/7] package/opencv: add gstreamer-1.x support
Date: Sun, 5 Jul 2015 11:49:10 +0200 [thread overview]
Message-ID: <20150705094910.GJ3647@free.fr> (raw)
In-Reply-To: <1436089229-21103-3-git-send-email-s.martin49@gmail.com>
Samuel, All,
On 2015-07-05 11:40 +0200, Samuel Martin spake thusly:
> Starting with the 2.4.10 release, OpenCV supports both Gstreamer-0.10
> and Gstreamer-1, but only one can be enabled at the same time (OpenCV
> chooses Gstreamer-1 over Gstreamer-0.10 when both are available).
>
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> changes v7->v8:
> - fix depends on comments (Yann)
> - fix help text (Yann)
> - rework gst/gst1 if-block in opencv.mk (Yann)
>
> changes v6->v7:
> - move gstreamer1 comment inside the choice (Yann)
> - remove extra endif in opencv.mk (catched by Yann)
>
> changes v5->v6:
> - rebase
> - use a choice
>
> changes v4->v5:
> - rebase
> - update a/r/t tags
> - rework gst-X backend selection (use similar structure for qt)
> - remove patch merged upstream
>
> changes v3->v4:
> - new patch
> ---
> package/opencv/Config.in | 15 +++++++++++++++
> package/opencv/opencv.mk | 11 +++++++++--
> 2 files changed, 24 insertions(+), 2 deletions(-)
>
> diff --git a/package/opencv/Config.in b/package/opencv/Config.in
> index 4838a0c..079730e 100644
> --- a/package/opencv/Config.in
> +++ b/package/opencv/Config.in
> @@ -175,6 +175,8 @@ config BR2_PACKAGE_OPENCV_WITH_FFMPEG
>
> choice
> prompt "gstreamer support"
> + help
> + OpenCV prefers gstreamer-1 over gstreamer-0.10.
>
> config BR2_PACKAGE_OPENCV_WITHOUT_GSTREAMER
> bool "none"
> @@ -192,6 +194,19 @@ comment "gstreamer-0.10 support needs a toolchain w/ wchar, threads"
> depends on BR2_USE_MMU
> depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
>
> +config BR2_PACKAGE_OPENCV_WITH_GSTREAMER1
> + bool "gstreamer-1.x"
> + depends on BR2_USE_MMU # gstreamer1 -> libglib2
> + depends on BR2_USE_WCHAR # gstreamer1 -> libglib2
> + depends on BR2_TOOLCHAIN_HAS_THREADS # gstreamer1 -> libglib2
> + select BR2_PACKAGE_GSTREAMER1
> + select BR2_PACKAGE_GST1_PLUGINS_BASE
> + select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_APP
> +
> +comment "gstreamer-1.x support needs a toolchain w/ wchar, threads"
> + depends on BR2_USE_MMU
> + depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
> +
> endchoice
>
> config BR2_PACKAGE_OPENCV_WITH_GTK
> diff --git a/package/opencv/opencv.mk b/package/opencv/opencv.mk
> index 633c2bf..0e5cf77 100644
> --- a/package/opencv/opencv.mk
> +++ b/package/opencv/opencv.mk
> @@ -223,10 +223,17 @@ OPENCV_CONF_OPTS += -DWITH_FFMPEG=OFF
> endif
>
> ifeq ($(BR2_PACKAGE_OPENCV_WITH_GSTREAMER),y)
> -OPENCV_CONF_OPTS += -DWITH_GSTREAMER=ON -DWITH_GSTREAMER_0_10=ON
> +OPENCV_CONF_OPTS += -DWITH_GSTREAMER_0_10=ON
> OPENCV_DEPENDENCIES += gstreamer gst-plugins-base
> else
> -OPENCV_CONF_OPTS += -DWITH_GSTREAMER=OFF -DWITH_GSTREAMER_0_10=OFF
> +OPENCV_CONF_OPTS += -DWITH_GSTREAMER_0_10=OFF
> +endif
> +
> +ifeq ($(BR2_PACKAGE_OPENCV_WITH_GSTREAMER1),y)
> +OPENCV_CONF_OPTS += -DWITH_GSTREAMER=ON
> +OPENCV_DEPENDENCIES += gstreamer1 gst1-plugins-base
> +else
> +OPENCV_CONF_OPTS += -DWITH_GSTREAMER=OFF
> endif
>
> ifeq ($(BR2_PACKAGE_OPENCV_WITH_GTK),y)
> --
> 2.4.5
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-07-05 9:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-05 9:40 [Buildroot] [PATCH v8 0/7] OpenCV bump Samuel Martin
2015-07-05 9:40 ` [Buildroot] [PATCH v8 1/7] package/opencv: add a choice for selecting gstreamer support Samuel Martin
2015-07-05 12:51 ` Thomas Petazzoni
2015-07-05 9:40 ` [Buildroot] [PATCH v8 2/7] package/opencv: add gstreamer-1.x support Samuel Martin
2015-07-05 9:49 ` Yann E. MORIN [this message]
2015-07-05 12:51 ` Thomas Petazzoni
2015-07-05 9:40 ` [Buildroot] [PATCH v8 3/7] package/opencv: add a choice for selecting the gui toolkit Samuel Martin
2015-07-05 12:53 ` Thomas Petazzoni
2015-07-05 12:56 ` Samuel Martin
2015-07-05 9:40 ` [Buildroot] [PATCH v8 4/7] package/opencv: add qt5 support Samuel Martin
2015-07-05 12:57 ` Thomas Petazzoni
2015-07-05 13:01 ` Samuel Martin
2015-07-05 13:33 ` Thomas Petazzoni
2015-07-05 9:40 ` [Buildroot] [PATCH v8 5/7] package/opencv: add gtk3 support Samuel Martin
2015-07-05 12:59 ` Thomas Petazzoni
2015-07-05 13:07 ` Samuel Martin
2015-07-05 9:40 ` [Buildroot] [PATCH v8 6/7] package/opencv: add opengl support Samuel Martin
2015-07-05 9:40 ` [Buildroot] [PATCH v8 7/7] package/vlc: add opencv support Samuel Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150705094910.GJ3647@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox