From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v8 4/7] package/opencv: add qt5 support
Date: Sun, 5 Jul 2015 15:33:22 +0200 [thread overview]
Message-ID: <20150705153322.4fd06f32@free-electrons.com> (raw)
In-Reply-To: <CAHXCMML=1J6=y1MFGetN19GAC_jMUEprzedFsJhn-Tp46B5V0Q@mail.gmail.com>
Dear Samuel Martin,
On Sun, 5 Jul 2015 15:01:40 +0200, Samuel Martin wrote:
> >> -comment "qt4 needs a toolchain w/ C++"
> >> +comment "qt4 support needs qt"
> >> depends on BR2_USE_MMU # qt
> >> - depends on !BR2_INSTALL_LIBSTDCPP
> >> + depends on !BR2_PACKAGE_QT && !BR2_PACKAGE_QT5
> >
> > Why !qt && !qt5 ?
> >
> > Just do depends on !qt. Remember, you are inside a choice, so anyway the
> > user can only select *either* qt4 *or* qt5.
>
> Because in BR, we don't support both qt4 and qt5 enabled at the same time.
> So if Qt5 is already enabled in the package selection, this comment
> should not be visible; hence the !qt5
Hum, ok. One could say that we could use just "depends on !qt", and
then have the user be smart enough to realize that if he wants to
enable qt, he has to disable qt5.
But ok, fair enough. What about the other comments I made on the same
patch?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-07-05 13:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-05 9:40 [Buildroot] [PATCH v8 0/7] OpenCV bump Samuel Martin
2015-07-05 9:40 ` [Buildroot] [PATCH v8 1/7] package/opencv: add a choice for selecting gstreamer support Samuel Martin
2015-07-05 12:51 ` Thomas Petazzoni
2015-07-05 9:40 ` [Buildroot] [PATCH v8 2/7] package/opencv: add gstreamer-1.x support Samuel Martin
2015-07-05 9:49 ` Yann E. MORIN
2015-07-05 12:51 ` Thomas Petazzoni
2015-07-05 9:40 ` [Buildroot] [PATCH v8 3/7] package/opencv: add a choice for selecting the gui toolkit Samuel Martin
2015-07-05 12:53 ` Thomas Petazzoni
2015-07-05 12:56 ` Samuel Martin
2015-07-05 9:40 ` [Buildroot] [PATCH v8 4/7] package/opencv: add qt5 support Samuel Martin
2015-07-05 12:57 ` Thomas Petazzoni
2015-07-05 13:01 ` Samuel Martin
2015-07-05 13:33 ` Thomas Petazzoni [this message]
2015-07-05 9:40 ` [Buildroot] [PATCH v8 5/7] package/opencv: add gtk3 support Samuel Martin
2015-07-05 12:59 ` Thomas Petazzoni
2015-07-05 13:07 ` Samuel Martin
2015-07-05 9:40 ` [Buildroot] [PATCH v8 6/7] package/opencv: add opengl support Samuel Martin
2015-07-05 9:40 ` [Buildroot] [PATCH v8 7/7] package/vlc: add opencv support Samuel Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150705153322.4fd06f32@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox