From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v8 3/7] package/opencv: add a choice for selecting the gui toolkit
Date: Sun, 5 Jul 2015 14:53:50 +0200 [thread overview]
Message-ID: <20150705145350.5b5d56b2@free-electrons.com> (raw)
In-Reply-To: <1436089229-21103-4-git-send-email-s.martin49@gmail.com>
Dear Samuel Martin,
On Sun, 5 Jul 2015 11:40:25 +0200, Samuel Martin wrote:
> +choice
> + prompt "gui toolkit"
> + depends on BR2_PACKAGE_OPENCV_LIB_HIGHGUI
> + help
> + GUI toolkit for opencv_highgui module.
> +
> + The best toolkit to work with OpenCV are, in decreasing order of
> + preference by the OpenCV build system):
> + - Qt4
> + - gtk2
> +
> + Note that, whatever you choose here will be used by OpenCV, even
> + if you also enabled a more preferred toolkit in your Buildroot
> + configuration.
This comment really doesn't make sense. Why do we care about the
preferred order of OpenCV for GUI toolkit, since we are anyway
overriding it by the below options? Why don't you simply have:
help
GUI toolkit to be used by the opencv_highgui module.
The additional comments about the preferred order by OpenCV build
system are simply confusing and useless, IMO. If you agree, I can apply
this patch after reworking the comment.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-07-05 12:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-05 9:40 [Buildroot] [PATCH v8 0/7] OpenCV bump Samuel Martin
2015-07-05 9:40 ` [Buildroot] [PATCH v8 1/7] package/opencv: add a choice for selecting gstreamer support Samuel Martin
2015-07-05 12:51 ` Thomas Petazzoni
2015-07-05 9:40 ` [Buildroot] [PATCH v8 2/7] package/opencv: add gstreamer-1.x support Samuel Martin
2015-07-05 9:49 ` Yann E. MORIN
2015-07-05 12:51 ` Thomas Petazzoni
2015-07-05 9:40 ` [Buildroot] [PATCH v8 3/7] package/opencv: add a choice for selecting the gui toolkit Samuel Martin
2015-07-05 12:53 ` Thomas Petazzoni [this message]
2015-07-05 12:56 ` Samuel Martin
2015-07-05 9:40 ` [Buildroot] [PATCH v8 4/7] package/opencv: add qt5 support Samuel Martin
2015-07-05 12:57 ` Thomas Petazzoni
2015-07-05 13:01 ` Samuel Martin
2015-07-05 13:33 ` Thomas Petazzoni
2015-07-05 9:40 ` [Buildroot] [PATCH v8 5/7] package/opencv: add gtk3 support Samuel Martin
2015-07-05 12:59 ` Thomas Petazzoni
2015-07-05 13:07 ` Samuel Martin
2015-07-05 9:40 ` [Buildroot] [PATCH v8 6/7] package/opencv: add opengl support Samuel Martin
2015-07-05 9:40 ` [Buildroot] [PATCH v8 7/7] package/vlc: add opencv support Samuel Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150705145350.5b5d56b2@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox