Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] wpa_supplicant: Add NL80211 support option
Date: Mon, 13 Jul 2015 11:29:47 +0200	[thread overview]
Message-ID: <20150713112947.7e14fd64@free-electrons.com> (raw)
In-Reply-To: <55A383CC.8030809@green-communications.fr>

Dear Nicolas Cavallari,

On Mon, 13 Jul 2015 11:24:28 +0200, Nicolas Cavallari wrote:

> >> +config BR2_PACKAGE_WPA_SUPPLICANT_NL80211
> >> +	bool "Enable NL80211"
> >> +	default y if BR2_PACKAGE_LIBNL
> >> +	select BR2_PACKAGE_LIBNL
> >> +	help
> >> +	  Enable support for NL80211.
> > 
> > In which cases would you want to *not* have NL80211 support if you
> > already have libnl enabled? What is the reason/use-case?
> 
> The author made it clear that it is not the main reason.  The main
> reason is that wpa_supplicant's usefulness is pretty reduced if
> nl80211 is not enabled;
> 
> With a default kernel configuration, only nl80211 is supported since
> the deprecated wext compatibility is disabled by default, so you may
> even end up with a wpa_supplicant binary that can not manage any wifi
> device if you forgot about enabling libnl to have nl80211.
> 
> And wpa_supplicant is not entirely useless without nl80211 either: you
> may want to only use the wired driver to do 802.1x on Ethernet
> networks, or you may only need the wext driver because you are using
> some old/unmaintained out-of-tree linux driver that only knows about wext.
> 
> In either case, it is useful to have an option to enable nl80211, and
> I would even suggest it to be enabled by default (and removing the
> automatic dependency, of course).  I'm quite sure that some features
> which are already optional (such as HS20 or WPS) are useless/dead code
> without nl80211.

Then fair enough: what we need is a patch that adds an option as
suggested by the original author, but also remove the "automatic
optional dependency" handling that is currently in wpa_supplicant.mk.

Would you be willing to work on such a patch?

Thanks for the feedback!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-07-13  9:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-08 16:17 [Buildroot] [PATCH v2] wpa_supplicant: Add NL80211 support option Jean-Baptiste Theou
2015-07-12 17:25 ` Thomas Petazzoni
2015-07-13  9:24   ` Nicolas Cavallari
2015-07-13  9:29     ` Thomas Petazzoni [this message]
2015-07-16 13:02       ` [Buildroot] [PATCH 1/2] wpa_supplicant: Add an explicit option to enable nl80211 Nicolas Cavallari
2015-07-16 13:02         ` [Buildroot] [PATCH 2/2] wpa_supplicant: Have Hotspot 2.0 depend on nl80211 Nicolas Cavallari
2015-07-17  6:41           ` Baruch Siach
2015-07-17  7:45             ` Thomas Petazzoni
2015-07-17  8:00               ` Nicolas Cavallari
2015-07-17 10:00               ` Baruch Siach
2015-07-17  6:39         ` [Buildroot] [PATCH 1/2] wpa_supplicant: Add an explicit option to enable nl80211 Baruch Siach
2015-07-17  7:49           ` Nicolas Cavallari
2015-07-17  7:59             ` [Buildroot] [PATCH 1/2 v2] " Nicolas Cavallari
2015-07-17  7:59               ` [Buildroot] [PATCH 2/2 v2] wpa_supplicant: Have Hotspot 2.0 depend on nl80211 Nicolas Cavallari
2015-09-17 15:31                 ` [Buildroot] [2/2, " Gary Bisson
2015-09-17 17:21                   ` Nicolas Cavallari
2016-01-10 13:10                     ` Yann E. MORIN
2015-09-17 15:26               ` [Buildroot] [1/2, v2] wpa_supplicant: Add an explicit option to enable nl80211 Gary Bisson
2015-10-11 12:47         ` [Buildroot] [PATCH 1/2] " Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150713112947.7e14fd64@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox