From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] wpa_supplicant: Add an explicit option to enable nl80211.
Date: Sun, 11 Oct 2015 14:47:01 +0200 [thread overview]
Message-ID: <20151011144701.66672b8e@free-electrons.com> (raw)
In-Reply-To: <1437051754-24060-1-git-send-email-nicolas.cavallari@green-communications.fr>
Dear Nicolas Cavallari,
On Thu, 16 Jul 2015 15:02:33 +0200, Nicolas Cavallari wrote:
> Currently, nl80211 support is conditional with libnl being enabled,
> using implicit dependencies. This causes problems since it is not
> obvious and wpa_supplicant without nl80211 isn't what most user expects.
>
> If nl80211 isn't enabled, then buildroot only enables the wext driver,
> which will only work if some deprecated kernel feature isn't left
> disabled, or if using a outdated out-of-tree linux driver which doesn't
> use the cfg80211 infrastructure.
>
> This makes nl80211 support an explicit option, which
> "select BR2_PACKAGE_LIBNL" accordingly. To handle upgrades nicely, it
> would have been nice to have "default y if BR2_PACKAGE_LIBNL", but
> Kconfig treats this as a circular dependency. So instead, this enables
> the option by default, which is less worse than not enabling nl80211
> when it was previously implicitly enabled.
>
> Signed-off-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
> ---
> package/wpa_supplicant/Config.in | 16 ++++++++++++++++
> package/wpa_supplicant/wpa_supplicant.mk | 2 +-
> 2 files changed, 17 insertions(+), 1 deletion(-)
I've applied after doing some minor fixes:
[Thomas:
- rewrap Config.in help text
- add comment about thread dependency.]
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-10-11 12:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 16:17 [Buildroot] [PATCH v2] wpa_supplicant: Add NL80211 support option Jean-Baptiste Theou
2015-07-12 17:25 ` Thomas Petazzoni
2015-07-13 9:24 ` Nicolas Cavallari
2015-07-13 9:29 ` Thomas Petazzoni
2015-07-16 13:02 ` [Buildroot] [PATCH 1/2] wpa_supplicant: Add an explicit option to enable nl80211 Nicolas Cavallari
2015-07-16 13:02 ` [Buildroot] [PATCH 2/2] wpa_supplicant: Have Hotspot 2.0 depend on nl80211 Nicolas Cavallari
2015-07-17 6:41 ` Baruch Siach
2015-07-17 7:45 ` Thomas Petazzoni
2015-07-17 8:00 ` Nicolas Cavallari
2015-07-17 10:00 ` Baruch Siach
2015-07-17 6:39 ` [Buildroot] [PATCH 1/2] wpa_supplicant: Add an explicit option to enable nl80211 Baruch Siach
2015-07-17 7:49 ` Nicolas Cavallari
2015-07-17 7:59 ` [Buildroot] [PATCH 1/2 v2] " Nicolas Cavallari
2015-07-17 7:59 ` [Buildroot] [PATCH 2/2 v2] wpa_supplicant: Have Hotspot 2.0 depend on nl80211 Nicolas Cavallari
2015-09-17 15:31 ` [Buildroot] [2/2, " Gary Bisson
2015-09-17 17:21 ` Nicolas Cavallari
2016-01-10 13:10 ` Yann E. MORIN
2015-09-17 15:26 ` [Buildroot] [1/2, v2] wpa_supplicant: Add an explicit option to enable nl80211 Gary Bisson
2015-10-11 12:47 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151011144701.66672b8e@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox