Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gary Bisson <gary.bisson@boundarydevices.com>
To: buildroot@busybox.net
Subject: [Buildroot] [2/2, v2] wpa_supplicant: Have Hotspot 2.0 depend on nl80211
Date: Thu, 17 Sep 2015 17:31:27 +0200	[thread overview]
Message-ID: <20150917153127.GA28715@t450s.lan> (raw)
In-Reply-To: <1437119950-25976-2-git-send-email-nicolas.cavallari@green-communications.fr>

Hi Nicolas,

On Fri, Jul 17, 2015 at 09:59:10AM +0200, Nicolas Cavallari wrote:
> Hotspot 2.0 uses ANQP whose implementation needs offchannel/
> remain-on-channel capabilities from the driver, which only exist in the
> nl80211 driver.  Compiling would work, but the feature would not work.
> 
> Signed-off-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
> ---
> 
> v2: added signoff.
>  package/wpa_supplicant/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/wpa_supplicant/Config.in b/package/wpa_supplicant/Config.in
> index 29dc4b9..22cf7f8 100644
> --- a/package/wpa_supplicant/Config.in
> +++ b/package/wpa_supplicant/Config.in
> @@ -41,6 +41,7 @@ config BR2_PACKAGE_WPA_SUPPLICANT_EAP
>  
>  config BR2_PACKAGE_WPA_SUPPLICANT_HOTSPOT
>  	bool "Enable HS20"
> +	depends on BR2_PACKAGE_WPA_SUPPLICANT_NL80211
>  	help
>  	  Enable Hotspot 2.0 and IEEE 802.11u interworking functionality.
>

First I'm not sure on the procedure to test the Hotspot 2.0 but I think
we should at least add a comment like:

comment "HS20 needs NL80211 support"
	depends on !BR2_PACKAGE_WPA_SUPPLICANT_NL80211

Because right now if you unselect NL80211 WPA option the HS20 just
disappears.

Or maybe selecting NL80211 would be even better if absolutely required
at runtime.

Regards,
Gary

  reply	other threads:[~2015-09-17 15:31 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-08 16:17 [Buildroot] [PATCH v2] wpa_supplicant: Add NL80211 support option Jean-Baptiste Theou
2015-07-12 17:25 ` Thomas Petazzoni
2015-07-13  9:24   ` Nicolas Cavallari
2015-07-13  9:29     ` Thomas Petazzoni
2015-07-16 13:02       ` [Buildroot] [PATCH 1/2] wpa_supplicant: Add an explicit option to enable nl80211 Nicolas Cavallari
2015-07-16 13:02         ` [Buildroot] [PATCH 2/2] wpa_supplicant: Have Hotspot 2.0 depend on nl80211 Nicolas Cavallari
2015-07-17  6:41           ` Baruch Siach
2015-07-17  7:45             ` Thomas Petazzoni
2015-07-17  8:00               ` Nicolas Cavallari
2015-07-17 10:00               ` Baruch Siach
2015-07-17  6:39         ` [Buildroot] [PATCH 1/2] wpa_supplicant: Add an explicit option to enable nl80211 Baruch Siach
2015-07-17  7:49           ` Nicolas Cavallari
2015-07-17  7:59             ` [Buildroot] [PATCH 1/2 v2] " Nicolas Cavallari
2015-07-17  7:59               ` [Buildroot] [PATCH 2/2 v2] wpa_supplicant: Have Hotspot 2.0 depend on nl80211 Nicolas Cavallari
2015-09-17 15:31                 ` Gary Bisson [this message]
2015-09-17 17:21                   ` [Buildroot] [2/2, " Nicolas Cavallari
2016-01-10 13:10                     ` Yann E. MORIN
2015-09-17 15:26               ` [Buildroot] [1/2, v2] wpa_supplicant: Add an explicit option to enable nl80211 Gary Bisson
2015-10-11 12:47         ` [Buildroot] [PATCH 1/2] " Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150917153127.GA28715@t450s.lan \
    --to=gary.bisson@boundarydevices.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox