[Buildroot] [PATCH] c-icap: fix config script by adding $(STAGING_DIR) prefix to link path. It fixes c-icap-modules build.

[Buildroot] [PATCH] c-icap: fix config script by adding $(STAGING_DIR) prefix to link path. It fixes c-icap-modules build.

[Guillaume GARDET]

Reported-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Guillaume GARDET <guillaume.gardet@oliseo.fr>

---
 package/c-icap/c-icap.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/c-icap/c-icap.mk b/package/c-icap/c-icap.mk
index 0f42b6c..00a250b 100644
--- a/package/c-icap/c-icap.mk
+++ b/package/c-icap/c-icap.mk
@@ -57,6 +57,8 @@ define C_ICAP_TUNE_INSTALLATION
 		$(STAGING_DIR)/usr/bin/{c-icap,c-icap-libicapapi}-config
 	$(SED) 's%INCDIR2=.*%INCDIR2=$(STAGING_DIR)/usr/include/c_icap%' \
 		$(STAGING_DIR)/usr/bin/{c-icap,c-icap-libicapapi}-config
+	$(SED) 's%LIBS="-L%LIBS="-L$(STAGING_DIR)%' \
+		$(STAGING_DIR)/usr/bin/c-icap-libicapapi-config
 endef
 
 C_ICAP_POST_INSTALL_TARGET_HOOKS += C_ICAP_TUNE_INSTALLATION
-- 
1.8.4.5

[Buildroot] [PATCH] c-icap: fix config script by adding $(STAGING_DIR) prefix to link path. It fixes c-icap-modules build.

[Thomas Petazzoni]

Guillaume,

Thanks for the patch!

On Wed, 22 Jul 2015 14:40:41 +0200, Guillaume GARDET wrote:
> Reported-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: Guillaume GARDET <guillaume.gardet@oliseo.fr>
> 
> ---
>  package/c-icap/c-icap.mk | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/c-icap/c-icap.mk b/package/c-icap/c-icap.mk
> index 0f42b6c..00a250b 100644
> --- a/package/c-icap/c-icap.mk
> +++ b/package/c-icap/c-icap.mk
> @@ -57,6 +57,8 @@ define C_ICAP_TUNE_INSTALLATION
>  		$(STAGING_DIR)/usr/bin/{c-icap,c-icap-libicapapi}-config
>  	$(SED) 's%INCDIR2=.*%INCDIR2=$(STAGING_DIR)/usr/include/c_icap%' \
>  		$(STAGING_DIR)/usr/bin/{c-icap,c-icap-libicapapi}-config
> +	$(SED) 's%LIBS="-L%LIBS="-L$(STAGING_DIR)%' \
> +		$(STAGING_DIR)/usr/bin/c-icap-libicapapi-config

Ah, right, I missed this one! However, I think it's useless to keep
this -L option, this $(STAGING_DIR)/usr/lib is already in the library
search path for the cross-compiler.

What about just:

	$(SED) 's%-L$LIBDIR %%' $(STAGING_DIR)/usr/bin/c-icap-libicapapi-config

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] c-icap: fix config script by adding $(STAGING_DIR) prefix to link path. It fixes c-icap-modules build.

[Guillaume GARDET - Oliséo]

Le 22/07/2015 14:55, Thomas Petazzoni a ?crit :
> Guillaume,
>
> Thanks for the patch!
>
> On Wed, 22 Jul 2015 14:40:41 +0200, Guillaume GARDET wrote:
>> Reported-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>> Signed-off-by: Guillaume GARDET <guillaume.gardet@oliseo.fr>
>>
>> ---
>>   package/c-icap/c-icap.mk | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/package/c-icap/c-icap.mk b/package/c-icap/c-icap.mk
>> index 0f42b6c..00a250b 100644
>> --- a/package/c-icap/c-icap.mk
>> +++ b/package/c-icap/c-icap.mk
>> @@ -57,6 +57,8 @@ define C_ICAP_TUNE_INSTALLATION
>>   		$(STAGING_DIR)/usr/bin/{c-icap,c-icap-libicapapi}-config
>>   	$(SED) 's%INCDIR2=.*%INCDIR2=$(STAGING_DIR)/usr/include/c_icap%' \
>>   		$(STAGING_DIR)/usr/bin/{c-icap,c-icap-libicapapi}-config
>> +	$(SED) 's%LIBS="-L%LIBS="-L$(STAGING_DIR)%' \
>> +		$(STAGING_DIR)/usr/bin/c-icap-libicapapi-config
> Ah, right, I missed this one! However, I think it's useless to keep
> this -L option, this $(STAGING_DIR)/usr/lib is already in the library
> search path for the cross-compiler.
>
> What about just:
>
> 	$(SED) 's%-L$LIBDIR %%' $(STAGING_DIR)/usr/bin/c-icap-libicapapi-config

Ok, but $ sign must be escaped with another $:
         $(SED) 's%-L$$LIBDIR %%' $(STAGING_DIR)/usr/bin/c-icap-libicapapi-config

Do you want a I send a V2 with this solution?


Guillaume

>
> Thanks,
>
> Thomas

[Buildroot] [PATCH] c-icap: fix config script by adding $(STAGING_DIR) prefix to link path. It fixes c-icap-modules build.

[Thomas Petazzoni]

Guillaume,

On Wed, 22 Jul 2015 15:30:54 +0200, Guillaume GARDET - Olis?o wrote:

> > What about just:
> >
> > 	$(SED) 's%-L$LIBDIR %%' $(STAGING_DIR)/usr/bin/c-icap-libicapapi-config
> 
> Ok, but $ sign must be escaped with another $:
>          $(SED) 's%-L$$LIBDIR %%' $(STAGING_DIR)/usr/bin/c-icap-libicapapi-config

Ah, yes, indeed. I missed that since I quickly tested the solution in a
shell.

> Do you want a I send a V2 with this solution?

Yes, please!

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH V2] c-icap: fix config script by adding $(STAGING_DIR) prefix to link path. It fixes c-icap-modules build.

[Guillaume GARDET]

Reported-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Guillaume GARDET <guillaume.gardet@oliseo.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

---
 package/c-icap/c-icap.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/c-icap/c-icap.mk b/package/c-icap/c-icap.mk
index 0f42b6c..0e27cc4 100644
--- a/package/c-icap/c-icap.mk
+++ b/package/c-icap/c-icap.mk
@@ -57,6 +57,7 @@ define C_ICAP_TUNE_INSTALLATION
 		$(STAGING_DIR)/usr/bin/{c-icap,c-icap-libicapapi}-config
 	$(SED) 's%INCDIR2=.*%INCDIR2=$(STAGING_DIR)/usr/include/c_icap%' \
 		$(STAGING_DIR)/usr/bin/{c-icap,c-icap-libicapapi}-config
+	$(SED) 's%-L$$LIBDIR %%' $(STAGING_DIR)/usr/bin/c-icap-libicapapi-config
 endef
 
 C_ICAP_POST_INSTALL_TARGET_HOOKS += C_ICAP_TUNE_INSTALLATION
-- 
1.8.4.5

[Buildroot] [PATCH V2] c-icap: fix config script by adding $(STAGING_DIR) prefix to link path. It fixes c-icap-modules build.

[Thomas Petazzoni]

Dear Guillaume GARDET,

On Thu, 23 Jul 2015 10:45:47 +0200, Guillaume GARDET wrote:
> Reported-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: Guillaume GARDET <guillaume.gardet@oliseo.fr>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

I applied, but quite a few things were still wrong with the patch:

 * The commit title is too long. It should be less than 80 characters.
   The commit title should only be a summary of the commit log itself.

 * The commit title is wrong: you're no longer adding $(STAGING_DIR) to
   the link path

 * The commit log was missing a reference to the autobuilder failure
   that this patch is fixing.

I've fixed those problems and applied. See:

  http://git.buildroot.net/buildroot/commit/?id=6c73215493335f1ede26cad2d3898ef543d871d6

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH V2] c-icap: fix config script by adding $(STAGING_DIR) prefix to link path. It fixes c-icap-modules build.

[Guillaume GARDET - Oliséo]

Le 23/07/2015 23:11, Thomas Petazzoni a ?crit :
> Dear Guillaume GARDET,
>
> On Thu, 23 Jul 2015 10:45:47 +0200, Guillaume GARDET wrote:
>> Reported-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>> Signed-off-by: Guillaume GARDET <guillaume.gardet@oliseo.fr>
>> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> I applied, but quite a few things were still wrong with the patch:
>
>   * The commit title is too long. It should be less than 80 characters.
>     The commit title should only be a summary of the commit log itself.
>
>   * The commit title is wrong: you're no longer adding $(STAGING_DIR) to
>     the link path
>
>   * The commit log was missing a reference to the autobuilder failure
>     that this patch is fixing.
>
> I've fixed those problems and applied. See:
>
>    http://git.buildroot.net/buildroot/commit/?id=6c73215493335f1ede26cad2d3898ef543d871d6

Thanks.
I copy/paste V1 to V2 too quickly. Sorry.


Guillaume

>
> Thanks,
>
> Thomas