[Buildroot] [PATCH 1/3] package/rng-tools: needs argp-standalone with musl toolchains

[Buildroot] [PATCH 1/3] package/rng-tools: needs argp-standalone with musl toolchains

[Romain Naour]

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
 package/rng-tools/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/rng-tools/Config.in b/package/rng-tools/Config.in
index 43c5a1c..469b60e 100644
--- a/package/rng-tools/Config.in
+++ b/package/rng-tools/Config.in
@@ -1,6 +1,6 @@
 config BR2_PACKAGE_RNG_TOOLS
 	bool "rng-tools"
-	select BR2_PACKAGE_ARGP_STANDALONE if BR2_TOOLCHAIN_USES_UCLIBC
+	select BR2_PACKAGE_ARGP_STANDALONE if BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_MUSL
 	# For rdrand ligcrypt is required and it's not obvious to users
 	select BR2_PACKAGE_LIBGCRYPT if BR2_i386 || BR2_x86_64
 	help
-- 
2.4.3

[Buildroot] [PATCH 2/3] package/eflutils: needs argp-standalone with musl toolchains

[Romain Naour]

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
 package/elfutils/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/elfutils/Config.in b/package/elfutils/Config.in
index 6c6856e..ea0ae62 100644
--- a/package/elfutils/Config.in
+++ b/package/elfutils/Config.in
@@ -4,7 +4,7 @@ comment "elfutils needs a toolchain w/ wchar, dynamic library"
 
 config BR2_PACKAGE_ELFUTILS
 	bool "elfutils"
-	select BR2_PACKAGE_ARGP_STANDALONE if BR2_TOOLCHAIN_USES_UCLIBC
+	select BR2_PACKAGE_ARGP_STANDALONE if BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_MUSL
 	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT
 	depends on BR2_USE_WCHAR
 	depends on !BR2_STATIC_LIBS
-- 
2.4.3

[Buildroot] [PATCH 3/3] package/libv4l: needs argp-standalone with musl toolchains

[Romain Naour]

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
 package/libv4l/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/libv4l/Config.in b/package/libv4l/Config.in
index 0437ba1..0ae12d1 100644
--- a/package/libv4l/Config.in
+++ b/package/libv4l/Config.in
@@ -5,7 +5,7 @@ config BR2_PACKAGE_LIBV4L
 	depends on !BR2_STATIC_LIBS # dlopen()
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 # media headers
-	select BR2_PACKAGE_ARGP_STANDALONE if BR2_TOOLCHAIN_USES_UCLIBC
+	select BR2_PACKAGE_ARGP_STANDALONE if BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_MUSL
 	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
 	help
 	  libv4l is a collection of libraries which adds a thin abstraction
-- 
2.4.3

[Buildroot] [PATCH 1/3] package/rng-tools: needs argp-standalone with musl toolchains

[Yann E. MORIN]

Romain, All,

On 2015-08-01 18:55 +0200, Romain Naour spake thusly:
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
>  package/rng-tools/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/rng-tools/Config.in b/package/rng-tools/Config.in
> index 43c5a1c..469b60e 100644
> --- a/package/rng-tools/Config.in
> +++ b/package/rng-tools/Config.in
> @@ -1,6 +1,6 @@
>  config BR2_PACKAGE_RNG_TOOLS
>  	bool "rng-tools"
> -	select BR2_PACKAGE_ARGP_STANDALONE if BR2_TOOLCHAIN_USES_UCLIBC
> +	select BR2_PACKAGE_ARGP_STANDALONE if BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_MUSL

You also need to adjust the build dependencies in the .mk .

Regards,
Yann E. MORIN.

>  	# For rdrand ligcrypt is required and it's not obvious to users
>  	select BR2_PACKAGE_LIBGCRYPT if BR2_i386 || BR2_x86_64
>  	help
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 2/3] package/eflutils: needs argp-standalone with musl toolchains

[Yann E. MORIN]

Romain, All,

On 2015-08-01 18:55 +0200, Romain Naour spake thusly:
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
>  package/elfutils/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/elfutils/Config.in b/package/elfutils/Config.in
> index 6c6856e..ea0ae62 100644
> --- a/package/elfutils/Config.in
> +++ b/package/elfutils/Config.in
> @@ -4,7 +4,7 @@ comment "elfutils needs a toolchain w/ wchar, dynamic library"
>  
>  config BR2_PACKAGE_ELFUTILS
>  	bool "elfutils"
> -	select BR2_PACKAGE_ARGP_STANDALONE if BR2_TOOLCHAIN_USES_UCLIBC
> +	select BR2_PACKAGE_ARGP_STANDALONE if BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_MUSL

Ditto, you also need to adjust the build dependencies in the .mk .

Regards,
Yann E. MORIN.

>  	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT
>  	depends on BR2_USE_WCHAR
>  	depends on !BR2_STATIC_LIBS
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 3/3] package/libv4l: needs argp-standalone with musl toolchains

[Yann E. MORIN]

Romain, All,

On 2015-08-01 18:55 +0200, Romain Naour spake thusly:
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
>  package/libv4l/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/libv4l/Config.in b/package/libv4l/Config.in
> index 0437ba1..0ae12d1 100644
> --- a/package/libv4l/Config.in
> +++ b/package/libv4l/Config.in
> @@ -5,7 +5,7 @@ config BR2_PACKAGE_LIBV4L
>  	depends on !BR2_STATIC_LIBS # dlopen()
>  	depends on BR2_INSTALL_LIBSTDCPP
>  	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 # media headers
> -	select BR2_PACKAGE_ARGP_STANDALONE if BR2_TOOLCHAIN_USES_UCLIBC
> +	select BR2_PACKAGE_ARGP_STANDALONE if BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_MUSL

Ditto, you also need to adjust the build dependencies in the .mk .

However, that one is doing things differently than the other two. It
currently build-depends on argp-standalone and links with it as soon as
the package is enabled.

I'm nt sure that's the best soltuion; it should only do that if built
against uClibc or musl, like rng-tools and elfutils currently do.

Regards,
Yann E. MORIN.

>  	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
>  	help
>  	  libv4l is a collection of libraries which adds a thin abstraction
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 2/3] package/eflutils: needs argp-standalone with musl toolchains

[Thomas Petazzoni]

Dear Romain Naour,

On Sat,  1 Aug 2015 18:55:17 +0200, Romain Naour wrote:
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
>  package/elfutils/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/elfutils/Config.in b/package/elfutils/Config.in
> index 6c6856e..ea0ae62 100644
> --- a/package/elfutils/Config.in
> +++ b/package/elfutils/Config.in
> @@ -4,7 +4,7 @@ comment "elfutils needs a toolchain w/ wchar, dynamic library"
>  
>  config BR2_PACKAGE_ELFUTILS
>  	bool "elfutils"
> -	select BR2_PACKAGE_ARGP_STANDALONE if BR2_TOOLCHAIN_USES_UCLIBC
> +	select BR2_PACKAGE_ARGP_STANDALONE if BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_MUSL

This is not sufficient to get elfutils to build with musl. Lots of
other changes are needed (TEMP_FAILURE_RETRY, <error.h>, etc.).

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 3/3] package/libv4l: needs argp-standalone with musl toolchains

[Thomas Petazzoni]

Dear Yann E. MORIN,

On Sun, 2 Aug 2015 17:29:03 +0200, Yann E. MORIN wrote:

> Ditto, you also need to adjust the build dependencies in the .mk .
> 
> However, that one is doing things differently than the other two. It
> currently build-depends on argp-standalone and links with it as soon as
> the package is enabled.
> 
> I'm nt sure that's the best soltuion; it should only do that if built
> against uClibc or musl, like rng-tools and elfutils currently do.

Since argp-standalone/Config.in has:

	depends on !BR2_TOOLCHAIN_USES_GLIBC

then there is really no difference between:

ifeq ($(BR2_PACKAGE_ARGP_STANDALONE),y)
...
endif

and

ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC)$(BR2_TOOLCHAIN_USES_MUSL),y)
...
endif

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 3/3] package/libv4l: needs argp-standalone with musl toolchains

[Yann E. MORIN]

Thomas, All,

On 2015-08-03 11:16 +0200, Thomas Petazzoni spake thusly:
> On Sun, 2 Aug 2015 17:29:03 +0200, Yann E. MORIN wrote:
> > Ditto, you also need to adjust the build dependencies in the .mk .
> > 
> > However, that one is doing things differently than the other two. It
> > currently build-depends on argp-standalone and links with it as soon as
> > the package is enabled.
> > 
> > I'm nt sure that's the best soltuion; it should only do that if built
> > against uClibc or musl, like rng-tools and elfutils currently do.
> 
> Since argp-standalone/Config.in has:
> 
> 	depends on !BR2_TOOLCHAIN_USES_GLIBC
> 
> then there is really no difference between:
> 
> ifeq ($(BR2_PACKAGE_ARGP_STANDALONE),y)
> ...
> endif
> 
> and
> 
> ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC)$(BR2_TOOLCHAIN_USES_MUSL),y)
> ...
> endif

OK, but in this case the two other packages should be changed to use the
same conditional code.

In the end, I don't mind which we use, as lon as we use it consistently
across packages.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'