[Buildroot] [PATCH 1/1] rapidxml: new package

[Buildroot] [PATCH 1/1] rapidxml: new package

[Jonathan Ben-Avraham]

From: Jonathan Ben Avraham <yba@tkos.co.il>

Signed-off-by: Jonathan Ben Avraham <yba@tkos.co.il>
---
 package/Config.in              |    1 +
 package/rapidxml/Config.in     |   10 ++++++++++
 package/rapidxml/rapidxml.hash |    1 +
 package/rapidxml/rapidxml.mk   |   25 +++++++++++++++++++++++++
 4 files changed, 37 insertions(+)
 create mode 100644 package/rapidxml/Config.in
 create mode 100644 package/rapidxml/rapidxml.hash
 create mode 100644 package/rapidxml/rapidxml.mk

diff --git a/package/Config.in b/package/Config.in
index ae00758..0a3386a 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -915,6 +915,7 @@ menu "JSON/XML"
 	source "package/libyaml/Config.in"
 	source "package/mxml/Config.in"
 	source "package/rapidjson/Config.in"
+	source "package/rapidxml/Config.in"
 	source "package/tinyxml/Config.in"
 	source "package/tinyxml2/Config.in"
 	source "package/xerces/Config.in"
diff --git a/package/rapidxml/Config.in b/package/rapidxml/Config.in
new file mode 100644
index 0000000..d17d838
--- /dev/null
+++ b/package/rapidxml/Config.in
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_RAPIDXML
+	bool "rapidxml"
+	help
+	  RapidXml is an attempt to create the fastest XML parser
+	  possible, while retaining useability, portability and
+	  reasonable W3C compatibility. It is an in-situ parser
+	  with parsing speed approaching speed of strlen function
+	  executed on the same data.
+
+	  http://sourceforge.net/projects/rapidxml/
diff --git a/package/rapidxml/rapidxml.hash b/package/rapidxml/rapidxml.hash
new file mode 100644
index 0000000..8c7366c
--- /dev/null
+++ b/package/rapidxml/rapidxml.hash
@@ -0,0 +1 @@
+sha256	c3f0b886374981bb20fabcf323d755db4be6dba42064599481da64a85f5b3571  rapidxml-1.13.zip
diff --git a/package/rapidxml/rapidxml.mk b/package/rapidxml/rapidxml.mk
new file mode 100644
index 0000000..af6b374
--- /dev/null
+++ b/package/rapidxml/rapidxml.mk
@@ -0,0 +1,25 @@
+################################################################################
+#
+# rapidxml
+#
+################################################################################
+
+RAPIDXML_VERSION = 1.13
+RAPIDXML_SOURCE = rapidxml-$(RAPIDXML_VERSION).zip
+
+#RAPIDXML_SITE = http://sourceforge.net/projects/rapidxml/files/latest/download
+RAPIDXML_SITE = http://garr.dl.sourceforge.net/project/rapidxml/rapidxml/rapidxml%201.13/
+RAPIDXML_LICENSE = MIT
+RAPIDXML_LICENSE_FILES = license.txt
+RAPIDXML_INSTALL_TARGET = NO
+RAPIDXML_INSTALL_STAGING = YES
+
+define RAPIDXML_EXTRACT_CMDS
+	$(UNZIP) -d $(@D) $(DL_DIR)/$(RAPIDXML_SOURCE)
+endef
+
+define RAPIDXML_INSTALL_STAGING_CMDS
+	cp -dpfr $(@D)/rapidxml-$(RAPIDXML_VERSION)/*hpp $(STAGING_DIR)/usr/include
+endef
+
+$(eval $(generic-package))
-- 
1.7.9.5

[Buildroot] [PATCH 1/1] rapidxml: new package

[Baruch Siach]

Hi Yonatan,

On Mon, Aug 03, 2015 at 09:04:14PM +0300, Jonathan Ben-Avraham wrote:
> +RAPIDXML_VERSION = 1.13
> +RAPIDXML_SOURCE = rapidxml-$(RAPIDXML_VERSION).zip
> +
> +#RAPIDXML_SITE = http://sourceforge.net/projects/rapidxml/files/latest/download

Please remove.

> +RAPIDXML_SITE = http://garr.dl.sourceforge.net/project/rapidxml/rapidxml/rapidxml%201.13/

Does

RAPIDXML_SITE = http://sourceforge.net/project/rapidxml/rapidxml/rapidxml%20$(RAPIDXML_VERSION)/

work?

> +RAPIDXML_LICENSE = MIT
> +RAPIDXML_LICENSE_FILES = license.txt
> +RAPIDXML_INSTALL_TARGET = NO

This needs an explanation comment. Is this a header only package?

> +RAPIDXML_INSTALL_STAGING = YES
> +
> +define RAPIDXML_EXTRACT_CMDS
> +	$(UNZIP) -d $(@D) $(DL_DIR)/$(RAPIDXML_SOURCE)
> +endef
> +
> +define RAPIDXML_INSTALL_STAGING_CMDS
> +	cp -dpfr $(@D)/rapidxml-$(RAPIDXML_VERSION)/*hpp $(STAGING_DIR)/usr/include
> +endef
> +
> +$(eval $(generic-package))

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

[Buildroot] [PATCH 1/1] rapidxml: new package

[Jonathan Ben Avraham]

Hi Baruch,

On Mon, 3 Aug 2015, Baruch Siach wrote:

> Date: Mon, 3 Aug 2015 22:57:42 +0300
> From: Baruch Siach <baruch@tkos.co.il>
> To: Jonathan Ben-Avraham <yba@tkos.co.il>
> Cc: buildroot at buildroot.org
> Subject: Re: [Buildroot] [PATCH 1/1] rapidxml: new package
> 
> Hi Yonatan,
>
> On Mon, Aug 03, 2015 at 09:04:14PM +0300, Jonathan Ben-Avraham wrote:
>> +RAPIDXML_VERSION = 1.13
>> +RAPIDXML_SOURCE = rapidxml-$(RAPIDXML_VERSION).zip
>> +
>> +#RAPIDXML_SITE = http://sourceforge.net/projects/rapidxml/files/latest/download
>
> Please remove.
>
>> +RAPIDXML_SITE = http://garr.dl.sourceforge.net/project/rapidxml/rapidxml/rapidxml%201.13/
>
> Does
>
> RAPIDXML_SITE = http://sourceforge.net/project/rapidxml/rapidxml/rapidxml%20$(RAPIDXML_VERSION)/
>
> work?
>
>> +RAPIDXML_LICENSE = MIT
>> +RAPIDXML_LICENSE_FILES = license.txt
>> +RAPIDXML_INSTALL_TARGET = NO
>
> This needs an explanation comment. Is this a header only package?
>
>> +RAPIDXML_INSTALL_STAGING = YES
>> +
>> +define RAPIDXML_EXTRACT_CMDS
>> +	$(UNZIP) -d $(@D) $(DL_DIR)/$(RAPIDXML_SOURCE)
>> +endef
>> +
>> +define RAPIDXML_INSTALL_STAGING_CMDS
>> +	cp -dpfr $(@D)/rapidxml-$(RAPIDXML_VERSION)/*hpp $(STAGING_DIR)/usr/include
>> +endef
>> +
>> +$(eval $(generic-package))
>
> baruch

I removed the commented line and added the version variable to the 
RAPIDXML_SITE value as per your request in the v2 patch submitted just 
now.

Regarding "This needs an explanation comment. Is this a header only 
package?", you can see from RAPIDXML_INSTALL_TARGET = NO and 
RAPIDXML_INSTALL_STAGING = YES that the answer must be "yes". I did not 
see a need to add a comment since the precedent package "rapidjson", also 
has no comment.

  - yba


-- 
  9590 8E58 D30D 1660 C349  673D B205 4FC4 B8F5 B7F9  ~. .~  Tk Open Systems
=}-------- Jonathan Ben-Avraham ("yba") ----------ooO--U--Ooo------------{=
mailto:yba at tkos.co.il tel:+972.52.486.3386 http://tkos.co.il skype:benavrhm

[Buildroot] [PATCH 1/1] rapidxml: new package

[Baruch Siach]

Hi Yonatan,

On Tue, Aug 04, 2015 at 07:37:14PM +0300, Jonathan Ben Avraham wrote:
> >On Mon, Aug 03, 2015 at 09:04:14PM +0300, Jonathan Ben-Avraham wrote:
> >>+RAPIDXML_INSTALL_TARGET = NO
> >
> >This needs an explanation comment. Is this a header only package?
> >
> >>+RAPIDXML_INSTALL_STAGING = YES

[snip]

> Regarding "This needs an explanation comment. Is this a header only
> package?", you can see from RAPIDXML_INSTALL_TARGET = NO and
> RAPIDXML_INSTALL_STAGING = YES that the answer must be "yes". I did not see
> a need to add a comment since the precedent package "rapidjson", also has no
> comment.

Set precedents are not always a good guide. That's the case here, IMO.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -