* [Buildroot] [PATCH 2/3] Fix elf2flt build when LTO is enabled
@ 2015-09-05 16:33 Douglas RAILLARD
2015-09-06 13:24 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Douglas RAILLARD @ 2015-09-05 16:33 UTC (permalink / raw)
To: buildroot
Signed-off-by: Douglas RAILLARD <public.douglas.raillard@gmail.com>
---
package/elf2flt/elf2flt.mk | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/package/elf2flt/elf2flt.mk b/package/elf2flt/elf2flt.mk
index 3fcada4..d028259 100644
--- a/package/elf2flt/elf2flt.mk
+++ b/package/elf2flt/elf2flt.mk
@@ -21,6 +21,12 @@ HOST_ELF2FLT_CONF_OPTS = \
--with-libiberty=$(HOST_BINUTILS_DIR)/libiberty/libiberty.a \
--target=$(GNU_TARGET_NAME)
+
HOST_ELF2FLT_CONF_ENV = LIBS=-lz
+ifeq ($(BR2_GCC_ENABLE_LTO),y)
+ HOST_ELF2FLT_CONF_ENV = LIBS="-lz -ldl"
+endif
+
+
$(eval $(host-autotools-package))
--
2.5.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 2/3] Fix elf2flt build when LTO is enabled
2015-09-05 16:33 [Buildroot] [PATCH 2/3] Fix elf2flt build when LTO is enabled Douglas RAILLARD
@ 2015-09-06 13:24 ` Thomas Petazzoni
2015-09-06 15:48 ` [Buildroot] [PATCH v2 2/3] elf2flt: fix " Douglas RAILLARD
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2015-09-06 13:24 UTC (permalink / raw)
To: buildroot
Dear Douglas RAILLARD,
On Sat, 5 Sep 2015 18:33:29 +0200, Douglas RAILLARD wrote:
> diff --git a/package/elf2flt/elf2flt.mk b/package/elf2flt/elf2flt.mk
> index 3fcada4..d028259 100644
> --- a/package/elf2flt/elf2flt.mk
> +++ b/package/elf2flt/elf2flt.mk
> @@ -21,6 +21,12 @@ HOST_ELF2FLT_CONF_OPTS = \
> --with-libiberty=$(HOST_BINUTILS_DIR)/libiberty/libiberty.a \
> --target=$(GNU_TARGET_NAME)
>
> +
Unnecessary new line addition.
> HOST_ELF2FLT_CONF_ENV = LIBS=-lz
>
> +ifeq ($(BR2_GCC_ENABLE_LTO),y)
> + HOST_ELF2FLT_CONF_ENV = LIBS="-lz -ldl"
Don't intend variables.
Also, please change this to:
HOST_ELF2FLT_LIBS = -lz
ifeq ($(BR2_GCC_ENABLE_LTO),y)
HOST_ELF2FLT_LIBS += -ldl
endif
HOST_ELF2FLT_CONF_ENV = LIBS="$(HOST_ELF2FLT_LIBS)"
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v2 2/3] elf2flt: fix build when LTO is enabled
2015-09-06 13:24 ` Thomas Petazzoni
@ 2015-09-06 15:48 ` Douglas RAILLARD
2015-09-06 20:51 ` Yann E. MORIN
2015-09-20 13:45 ` Thomas Petazzoni
0 siblings, 2 replies; 5+ messages in thread
From: Douglas RAILLARD @ 2015-09-06 15:48 UTC (permalink / raw)
To: buildroot
Signed-off-by: Douglas RAILLARD <public.douglas.raillard@gmail.com>
---
package/elf2flt/elf2flt.mk | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/package/elf2flt/elf2flt.mk b/package/elf2flt/elf2flt.mk
index 3fcada4..bec270b 100644
--- a/package/elf2flt/elf2flt.mk
+++ b/package/elf2flt/elf2flt.mk
@@ -21,6 +21,12 @@ HOST_ELF2FLT_CONF_OPTS = \
--with-libiberty=$(HOST_BINUTILS_DIR)/libiberty/libiberty.a \
--target=$(GNU_TARGET_NAME)
-HOST_ELF2FLT_CONF_ENV = LIBS=-lz
+HOST_ELF2FLT_LIBS = -lz
+
+ifeq ($(BR2_GCC_ENABLE_LTO),y)
+HOST_ELF2FLT_LIBS += -ldl
+endif
+
+HOST_ELF2FLT_CONF_ENV = LIBS="$(HOST_ELF2FLT_LIBS)"
$(eval $(host-autotools-package))
--
2.5.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v2 2/3] elf2flt: fix build when LTO is enabled
2015-09-06 15:48 ` [Buildroot] [PATCH v2 2/3] elf2flt: fix " Douglas RAILLARD
@ 2015-09-06 20:51 ` Yann E. MORIN
2015-09-20 13:45 ` Thomas Petazzoni
1 sibling, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2015-09-06 20:51 UTC (permalink / raw)
To: buildroot
Douglas, All,
On 2015-09-06 17:48 +0200, Douglas RAILLARD spake thusly:
> Signed-off-by: Douglas RAILLARD <public.douglas.raillard@gmail.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/elf2flt/elf2flt.mk | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/package/elf2flt/elf2flt.mk b/package/elf2flt/elf2flt.mk
> index 3fcada4..bec270b 100644
> --- a/package/elf2flt/elf2flt.mk
> +++ b/package/elf2flt/elf2flt.mk
> @@ -21,6 +21,12 @@ HOST_ELF2FLT_CONF_OPTS = \
> --with-libiberty=$(HOST_BINUTILS_DIR)/libiberty/libiberty.a \
> --target=$(GNU_TARGET_NAME)
>
> -HOST_ELF2FLT_CONF_ENV = LIBS=-lz
> +HOST_ELF2FLT_LIBS = -lz
> +
> +ifeq ($(BR2_GCC_ENABLE_LTO),y)
> +HOST_ELF2FLT_LIBS += -ldl
> +endif
> +
> +HOST_ELF2FLT_CONF_ENV = LIBS="$(HOST_ELF2FLT_LIBS)"
>
> $(eval $(host-autotools-package))
> --
> 2.5.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v2 2/3] elf2flt: fix build when LTO is enabled
2015-09-06 15:48 ` [Buildroot] [PATCH v2 2/3] elf2flt: fix " Douglas RAILLARD
2015-09-06 20:51 ` Yann E. MORIN
@ 2015-09-20 13:45 ` Thomas Petazzoni
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2015-09-20 13:45 UTC (permalink / raw)
To: buildroot
Dear Douglas RAILLARD,
On Sun, 6 Sep 2015 17:48:19 +0200, Douglas RAILLARD wrote:
> Signed-off-by: Douglas RAILLARD <public.douglas.raillard@gmail.com>
> ---
> package/elf2flt/elf2flt.mk | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-09-20 13:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-05 16:33 [Buildroot] [PATCH 2/3] Fix elf2flt build when LTO is enabled Douglas RAILLARD
2015-09-06 13:24 ` Thomas Petazzoni
2015-09-06 15:48 ` [Buildroot] [PATCH v2 2/3] elf2flt: fix " Douglas RAILLARD
2015-09-06 20:51 ` Yann E. MORIN
2015-09-20 13:45 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox